Hi all,

Den, there are missing some types in 1.54 for QLCLItemDelegate, pls add it so I can update bindings.

QLCLItemDelegate_createEditor_Override = procedure (parent : QWidgetH; option:
QStyleOptionViewItemH; index: QModelIndexH; out editor: QWidgetH) of object
cdecl;
QLCLItemDelegate_setEditorData_Override = procedure (editor : QWidgetH; index:
QModelIndexH) of object cdecl;
QLCLItemDelegate_setModelData_Override = procedure (editor : QWidgetH; model:
QAbstractItemModelH; index: QModelIndexH) of object cdecl;
QLCLItemDelegate_updateEditorGeometry_Override = procedure (editor : QWidgetH;
option: QStyleOptionViewItemH; index: QModelIndexH) of object cdecl;
QLCLItemDelegate_editorEvent_Override = procedure (event : QEventH; model:
QAbstractItemModelH; option: QStyleOptionViewItemH; index: QModelIndexH;
retval: PBoolean) of object cdecl;

zeljko

pm zeljko wrote

Den, there are missing some types in 1.54 for QLCLItemDelegate, pls add it so I can update bindings.

When code reviewing this I noticed an error in setModelData. The function call provides as parameter twice "editor". The second time it should be "model". Did you already use this function ? :)

void setModelData(QWidget * editor, QAbstractItemModel * model, const QModelIndex & index ) const {

if (setModelDataOverride.func) {

      typedef void (*func_type)(void *data, QWidgetH editor,
QAbstractItemModelH model, const QModelIndexH index);
      (*(func_type)setModelDataOverride.func)(setModelDataOverride.data,
(QWidgetH) editor, (QAbstractItemModelH) editor, (const QModelIndexH)&index);
                                                                    ^^^^
      }
     else QItemDelegate::setModelData(editor,model,index);
  }

pm Den Jean wrote

> Den, there are missing some types in 1.54 for QLCLItemDelegate, pls add > it so I can update bindings.

Done.

hm...I think not, but it is definitelly bug, pls. fix it and then update .... :)

tnx,
zeljko

tnx Den ,

zeljko

there won't be qt-4.2 bindings update ? should I commit 1.54 as it is ?

bug was fixed and Qt 4.2 has been added.
I will be away Monday till Thursday.

I assume you will update the win32 dll too? Then I will fix the installer build script to use the dll from svn.

Vincent

pm Vincent Snijders wrote

I assume you will update the win32 dll too? Then I will fix the installer build script to use the dll from svn.

I never made 2 version for windows. You punish me already enough asking for a binary for windows :-).
Switching from konsole to a dos box is not my ideay of fun.

I would prefer you make Qt 4.3 the default.
In Mandriva 2008, the packaged Qt 4 is a Qt 4.3 already. I suppose in other up-to-date distro's Qt 4.3 is also the packaged one.

regards,

Den Jean

windows have 4.3 by default.

Best regards,
Paul Ishenin.

Sorry, if this was confusing. My question was a reminder for Zeljko to update http://www.freepascal.org/cgi-bin/viewcvs.cgi/binaries/i386-win32/qt/?root=lazarus&rev=HEAD if he changes the qt4.pas

Which he just did. :-)

Thanks.

Vincent