Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-pascal / 2016-05

CustApp.pp missing semi-colons

2 messages · 2 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Graeme Geldenhuys

Hi,

RE: http://mantis.freepascal.org/view.php?id=30114

I was told to discuss this here. Not really sure what to discuss. The code style of custapp.pp uses semi-colons all over the place to signify an end of a statement or code block.

I found 3 locations in the code where this was not done. No, it doesn't cause a compilation error. Yes, it is a very minor patch. At least with this patch all code then conforms with all surrounding code. So I really see no harm in his patch.

Your thoughts?

Regards,
Graeme

fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal http://fpgui.sourceforge.net/ My public PGP key: http://tinyurl.com/graeme-pgp

Reply by email

Michael Van Canneyt
to Graeme Geldenhuys
Graeme Geldenhuys wrote 14 lines
Hi, RE: http://mantis.freepascal.org/view.php?id=30114 I was told to discuss this here. Not really sure what to discuss. The code style of custapp.pp uses semi-colons all over the place to signify an end of a statement or code block. I found 3 locations in the code where this was not done. No, it doesn't cause a compilation error. Yes, it is a very minor patch. At least with this patch all code then conforms with all surrounding code. So I really see no harm in his patch. Your thoughts?

I have committed the patch, rev. 33772.

I often commit patches that somehow involve coding style.

Michael.

Reply by email