Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / fpc-pascal / 2014-04

Blobtype fix - correct?

3 messages · 3 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

LacaK
to Reinier Olislagers: Is the patch I uploaded to http://bugs.freepascal.org/view.php?id=26064 correct? Reinier

Hi,
I know , that I am bit late ;-), but:
- for compatibility reasons I would choose another path (mentioned by Michael as "second"). As it was mentioned in comments in bug tracker there are two similar methods:
-- SetDataType (protected)
-- SetFieldType (public with checks ... see in fields.inc)

Please see also:
http://docwiki.embarcadero.com/Libraries/XE4/en/Data.DB.TBlobField.SetFieldType And "Note: Calling *SetFieldType* does the same thing as setting the BlobType
<http://docwiki.embarcadero.com/Libraries/XE4/en/Data.DB.TBlobField.BlobType> property."

So I would use patch in bug tracker and second in all TBlobFields descendants use SetFieldType instead of SetDataType in their constructors.

Side question is if there can be situation, where DataType BlobType. I did not test in Delphi, but in our current implementation it is possible, because setting BlobType does not change DataType

Bye
-Laco.

Show quoted text 13 lines
Hi guys, Is the patch I uploaded to http://bugs.freepascal.org/view.php?id=26064 correct? Thanks, Reinier _______________________________________________ fpc-pascal maillist - http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal