Catalog · How the catalog works
gitlab_windows1251
Gitlab Windows-1251 encoding fix
- ★ 11 on GitHub
Anyone may press Interesting, signed in or not. It helps others find this project.
README
Gitlab windows1251 issue fix
Current FIX
Version Gitlab 11.1.4
encoding_helper.rb
- Source file: encoding_helper.rb
- Path (on the file system): /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/encoding_helper.rb
- Fix: https://github.com/xRayDev/gitlab_windows1251/commit/1cdf4dd7db94e254c4487edeeea8675c8db7aa72#diff-c8cc55e6dc0de3038e6e5875cc74197c
- Link to a source file in the repository Gitlab: encoding_helper.rb
grit_ext.rb
- Source file: grit_ext.rb
- Path (on the file system): /opt/gitlab/embedded/lib/ruby/gems/2.4.0/gems/gitlab-grit-2.8.2/lib/grit_ext.rb
- Fix: https://github.com/xRayDev/gitlab_windows1251/commit/1cdf4dd7db94e254c4487edeeea8675c8db7aa72#diff-e55f3c175cd7224582f98cacd85da9ca
- Link to a source file in the repository Gitlab: grit_ext.rb
The paths to the files on the file system are specified for omnibus-gitlab.
In english
In Gitlab Windows-1251 encoding is still broken in the file viewer and the commit viewer. In this repository i posted sample with there bug. And put fix for Gitlab.
This issue is subject to the projects in which the source code is not encoded in UTF-8.
The first mention of the problem https://github.com/gitlabhq/gitlabhq/issues/5493 This discussion of the problem was closed. Discussion moved here https://gitlab.com/gitlab-org/gitlab-ce/issues/14048
Source of the problem
Ruby-gem charlock_holmes, responsible for the recognition of source coding and transferring them to UTF-8, can not understand what gives Windows-1251 to him.
Original source patch for old Gitlab version (from 31.10.2012) http://www.jackyfox.com/2012/10/31/gitlab-non-utf-8-russian-comments/
На русском
В Gitlab кодировка Windows-1251 по-прежнему сломана в просмотрщике файлов и просмотрщике фиксаций. В этом хранилище я разместил образец с ошибкой. И положил исправление для Gitlab.
Этой проблеме подвержены проекты в которых исходный код не в кодировке UTF-8.
Первые упоминания о проблеме https://github.com/gitlabhq/gitlabhq/issues/5493 Это обсуждение проблемы было закрыто. Обсуждение переместилось сюда https://gitlab.com/gitlab-org/gitlab-ce/issues/14048
Источник проблемы
Ruby-гем charlock_holmes, отвечающий за распознавание кодировки исходников и перевода их в UTF-8, не может понять, что дают ему Windows-1251.
Первоначальный источник исправлений для старой версии GitLab (от 31.10.2012) http://www.jackyfox.com/2012/10/31/gitlab-non-utf-8-russian-comments/