Hi,
I've had some free time this morning to implement TArrow, but cannot make decision on my own.
Pls, look at screenshoot and give a vote for arrows look. Left arrows are like winXp ones, right arrows are my idea. Also each arrow have different shadow type (I didn't see implementation of ShadowType on winXp & linux ).Is this correct or shadow have to be around arrow ?

zeljko
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tarrows.png
Type: image/png
Size: 7797 bytes
Desc: not available
URL: <http://lists.lazarus.freepascal.org/pipermail/qt/attachments/20070705/f3633265/attachment.png>

How are you implementing this? Using custom drawing?

If so, shouldn't lcl draw this itself?

Felipe Monteiro de Carvalho wrote

How are you implementing this? Using custom drawing?

winapi.Polygon(), but of course it can be custom drawed (right arrows from 1st screenshoot are custom drawed).

If so, shouldn't lcl draw this itself?

yes, via polygon, but seem that last 1.40 bindings messed up points. now it looks like s**t.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tarrows1.png
Type: image/png
Size: 8016 bytes
Desc: not available
URL: <http://lists.lazarus.freepascal.org/pipermail/qt/attachments/20070705/5cb66bbf/attachment.png>

zeljko wrote

yes, via polygon, but seem that last 1.40 bindings messed up points. now it looks like s**t. that should be fixed instead.

Drawing our own TArrow will just hide the real problem.

what ? polygon() or bindings ? seem that points are reversed now on linux.

Drawing our own TArrow will just hide the real problem.

we'll draw it via LCL definitelly.

zeljko wrote

what ? polygon() or bindings ? seem that points are reversed now on linux.

One of the two, I'm not sure which. If the points are really wrong on linux, then it's the bindings.

This code doesn't work as of 1.40 (with 1.37 it was ok). procedure QPainter_drawPolygon(handle: QPainterH; points: PPoint; pointCount: Integer; fillRule: QtFillRule = QtOddEvenFill); which is used in qtwinapi.Polygon() doesn't work anymore.
Seem that PPoints aren't properly copied to QPoint under linux. Den ?

Take a look at QToolButton, also good looking.

pm zeljko wrote

yes, via polygon, but seem that last 1.40 bindings messed up points. now it looks like s**t. already noticed. This is due to QPoint copying for DARWIN.

There are many procedures with a QPoint * parameter, that is not a single point, but an array of QPoint. The binding cannot know that and copies the provided PPoint into one QPoint .....

I cannot reliably fix this, so I will remove the DARWIN QPoint copiers and use a different pascal Point type. Please be aware of the obvious consequence: never to mix Types.Point and TQtPoint.

void drawConvexPolygon ( const QPoint * points, int pointCount )

becomes:

void QPainter_drawConvexPolygon3(QPainterH handle, PPoint points, int pointCount)
{

	QPoint t_points;
	if ( points )
		copyPPointToQPoint(points, t_points);
	((QPainter *)handle)->drawConvexPolygon(points ? &t_points : NULL,

pointCount);

----- Original Message -----

Theres procedure in lclintf called DrawArrow() which do the job, so arrow can look like gtk one (very ugly), or win32, whatever ... It's already implemented at my svn copy, but I'm waiting for bindings update and fixation of points problem.

in neither gtk or windows was able to draw any frame, in fact I don't know what ShadowType means, will try to find out next time I boot linux.

Think that's frame of the widget, not arrow, but could be also arrow frame, didn't found anywhere in docs what it could be.

zeljko

It's already implemented at my svn copy, but I'm waiting for bindings update and fixation of points problem.

I did a quick release. Can you test and report back. After that I will make a windows binary.

I will also see for Qt4.2.3 releases.
Perhaps source only for windows, I do not know yet if I can get 2 Qt's on my windows machine

regards,

Den Jean

I will also see for Qt4.2.3 releases. Perhaps source only for windows, I do not know yet if I can get 2 Qt's on my windows machine

This should be enougth.

pm Felipe Monteiro de Carvalho wrote

This should be enougth.

thanks, done