Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / pas2js / 2020-11

Open Source build of compatible pas2js_Widgetset

5 messages · 3 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Sven Barth
to peruginia
peruginia wrote 11 lines
I published any my implementation with all the source of pas2js_widgetset. If you want to try it and let me know if you find any problems. if you are interested in extending it we may cooperate. https://github.com/peruginia/Pas2JS_Widget Thank you Alessandro p.s. change from standard pas2js packages\rtl\classes.pas for tstream char problem

Is there a reason why you didn't *fork* your repo from the original one at https://github.com/heliosroots/Pas2JS_Widget? Without that one can't easily know that your repository is based on that.

Also you included *.bak files. And in my opinion including the binaries as well as the code from pas2js itself is unnecessary.

Regards,
Sven

Reply by email

Michael Van Canneyt
to peruginia
peruginia wrote
I apologize if my inexperience has created problems. it was just a test and they continued to modify the cusromdraw components of lazarus. At the moment, to avoid violating some rules such as publishing executables, I deleted the project. Excuse me

There is no need to apologize. You're not breaking or violating any rules :)

I think your effort is valuable.

If you want to share it, try to publish only the code you are maintaining or working on. As Sven indicated, it's mainly confusing for other people if you publish everything you have on your harddisk :)

Maybe you can try to fork the original repository where you got the code from, and publish your modifications in your forked repository.

If some patches to pas2js code are needed to make it work: simply include a .diff file in the repository and write up some instructions in a README.md file.

I hope this helps,

Michael.

Reply by email

Sven Barth
to peruginia: I apologize if my inexperience has created problems. it was just a test and they…
peruginia wrote
I apologize if my inexperience has created problems. it was just a test and they continued to modify the cusromdraw components of lazarus. At the moment, to avoid violating some rules such as publishing executables, I deleted the project. Excuse me

As Michael said, I didn't say that you violated some rules. It's more an inconvenience: without looking at the code no one will know where it originally came from. Binaries are definitely inconvenient and I personally prefer my own pas2js checkout.

So if you clean up your repository, fork it correctly, then nothings speak against your changes being up. That's the beauty of open source after all.

Regards,
Sven

Reply by email