There are an issue on the ExtractFileName function | win64 platform

...an workaround would be:

function ExtractFileName(str: String): String;
begin
  asm
    Result = str.split('\\').pop().split('/').pop();
  end;
end;
function ExtractFileNameWithoutExt(str: String): String;
begin
  asm
    Result = str.split('\\').pop().split('/').pop().split('.')[0];
  end;
end;

Can you please tell us what the issue is, give a sample program that demonstrates it ?

These functions come from the FPC RTL, if there was an issue, it would probably have been reported a long time ago ?

Michael.

var
  fullFileName : string;
begin
  // Set up a full file name with drive and path
  fullFileName := 'C:\Program Files\Borland\Delphi7\Projects\Unit1.dcu';
// Show the component parts of this full name
  console.log('Drive = '+ExtractFileDrive (fullFileName));
  console.log('Dir   = '+ExtractFileDir   (fullFileName));
  console.log('Path  = '+ExtractFilePath  (fullFileName));
  console.log('Name  = '+extractfilename  (fullFileName));
  console.log('Ext   = '+ExtractFileExt   (fullFileName));
  console.log(ExtractFileName_(fullFileName));
  console.log(ExtractFileNameWithoutExt_(fullFileName));
(* outputs this:

Drive = C: // ---> OK
Dir = C: // ----> should be C:\Program
Files\Borland\Delphi7\Projects
Path = C: //----> should be C:\Program
Files\Borland\Delphi7\Projects\
Name = \Program Files\Borland\Delphi7\Projects\Unit1.dcu // ---> should be Unit1.dcu
Ext = .dcu // ----> OK

Unit1.dcu // ---> OK
Unit1 // ---> OK

*)

Hello,

Did you set the PathDelim and AllowDirectorySeparators variables correctly ?

By default they are set to URL separators:

   PathDelim : Char = '/';
   AllowDirectorySeparators : Set of Char = ['/'];

If you want to use the native windows characters you must set them in the startup of your program, like this:

   PathDelim : Char = '\';
   AllowDirectorySeparators : Set of Char = ['/','\'];

Otherwise it will not work.

Your proposed solution is wrong for unix or the web (URL), because you hardcode \ which is correct only on windows.

The nodejsapp unit could probably detect the correct setting and set the variables automatically.

Michael.

Windows uses the backslash (\) for the file system delimiter. For everything else the forward slash is used (/).

If I define the path using forward slash (/).

fullFileName : String = 'C:/Program
Files/Borland\Delphi7/Projects/Unit1.dcu';

outputs this:

Drive = C:
Dir = C:/Program Files/Borland\Delphi7/Projects
Path = C:/Program Files/Borland\Delphi7/Projects/ Name = Unit1.dcu
Ext = .dcu

Unit1.dcu
Unit1

See my other mail.

Michael.

AllowDirectorySeparators := ['\'];
fullFileName : String = 'C:\Program
Files\Borland\Delphi7\Projects\Unit1.dcu';
// Show the component parts of this full name
  console.log('Drive = '+ExtractFileDrive (fullFileName));
  console.log('Dir   = '+ExtractFileDir   (fullFileName));
  console.log('Path  = '+ExtractFilePath  (fullFileName));
  console.log('Name  = '+extractfilename  (fullFileName));
  console.log('Ext   = '+ExtractFileExt   (fullFileName));

outputs correctly
===========
Drive = C:
Dir = C:\Program Files\Borland\Delphi7\Projects
Path = C:\Program Files\Borland\Delphi7\Projects\ Name = Unit1.dcu
Ext = .dcu

warleyalex wrote

AllowDirectorySeparators := ['\'];

You should set AllowDirectorySeparators to ['\', '/'], because Windows allows *both* and a mixture of them as well.

Regards,
Sven