Regarding issue :
https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/39338

The issue is about passing project info .lpi files etc. through cmd line for a running Lazarus IDE instance.
However the same code is used for drag/drop which makes it a bigger improvement than I thought initially.
I would like to merge this to 2.2. Does anybody see potential problems? Please test.

Regards,
Juha
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus-ide.org/pipermail/lazarus/attachments/20211113/b1b76908/attachment.html>

PM Juha Manninen wrote

I would like to merge this to 2.2. Does anybody see potential problems? Please test.

Isn't the policy to not merge new features, but only bugfixes?

On Sat, Nov 13, 2021 at 11:46 PM Bart via lazarus <

wrote: Isn't the policy to not merge new features, but only bugfixes?

Yes but this one is clearly a bugfix.
A project and a file name passed as cmd line parameters behaved differently depending on Lazarus being already running or not. When it was not running, all worked as expected.
When a running Lazarus instance got those parameters, unexpected things happened.
It turned out the same faulty code was used for drag'n'drop. It also behaved in an unexpected way.
I am quite happy with the result. My only worry is that the change could cause regressions. Thus I ask people to test it.
Fortunately most changes were refactoring. The moved code already worked elsewhere for the same purpose.
No problems have come up in my tests. I will mark it for merging in a few days.

Regards,
Juha
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus-ide.org/pipermail/lazarus/attachments/20211114/14d9de2e/attachment.html>

PM Juha Manninen wrote

> Isn't the policy to not merge new features, but only bugfixes? Yes but this one is clearly a bugfix.

Sorry, I misunderstood then.

This must be tested with the patch: --pcp= parameter, which is used in IDE shortcuts from fpcupdeluxe. What if different --pcp content is passed (1st instance has another --pcp).

Alexey

On Sun, Nov 14, 2021 at 2:52 AM Alexey Tor. via lazarus <

My commit only changed the way the parameters are interpreted. *.lpi is interpreted as a project always, *.lpk as a package. It does not affect the logic of how a single instance / multiple instances are opened.
Do you see a problem in how it behaves?

Juha
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus-ide.org/pipermail/lazarus/attachments/20211116/86feca9b/attachment.html>