Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / lazarus / 2021-09

Request for Gitlab access rights for Cocoa

5 messages · 3 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Martin Frb
to Alexey Tor.
Alexey Tor. wrote 9 lines
Hello. As you see on Gitlab comments: https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/39372 Dmitry (Cocoa WS supporter) has no Gitlab rights and he wants to pass these rights to me - Gitlab account Alexey-T1. Please do so. Dmitry is busy and has no enough wish to talk here. But he continues his work in his public GitHUB fork.

Looking at the issue referred, this reads to me as "someone who will make individual merge requests of the work provided".

We (the team) are currently looking at the situation, and it looks like we found an internal solution to it, saving the extra step. Results of this should hopefully manifest in the coming days.

So thanks, but we think its easier if we can do it directly.

Reply by email

Alexey Tor.
to Martin Frb

Thanks, here are 3 patches which I wanted to merge on start

1- TListItem.MakeVisible does not work on MacOS
<https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/39379>

2- [Cocoa] TListView.GetItemAt returns wrong item when ShowColumnHeaders=true
<https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/39372>

3- forum, patch by Zoe, Demo to benchmark TextOut on win64/gtk2/Cocoa - Cocoa is very slow
<https://forum.lazarus.freepascal.org/index.php/topic,55431.0.html>

Alexey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus-ide.org/pipermail/lazarus/attachments/20210929/0d1600fe/attachment.html>

Reply by email

Zoë Peterson
to Alexey Tor.
Alexey Tor. wrote 6 lines
Thanks, here are 3 patches which I wanted to merge on start 3- forum, patch by Zoe, Demo to benchmark TextOut on win64/gtk2/Cocoa - Cocoa is very slow <https://forum.lazarus.freepascal.org/index.php/topic,55431.0.html>

This patch is absolutely not ready to be merged.  It's a proof of concept that was intended to spur further research.  I didn't verify that it works for all cases, and I expect the final fix to be more invasive,  since the testing showed that the caching that the Cocoa GDI objects are currently doing is ineffective.  I don't have time for that myself right now, and hope that either Dmitry or David will look into it further when they have time.  If/when we have something that we're confident of, we'll submit it through the bug tracker.

Zoë Peterson Scooter Software -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.lazarus-ide.org/pipermail/lazarus/attachments/20210929/5a02bd39/attachment.html>

Reply by email

Martin Frb
to Alexey Tor.: Thanks, here are 3 patches which I wanted to merge on start 1- TListItem.MakeVisible does…
Alexey Tor. wrote 14 lines
Thanks, here are 3 patches which I wanted to merge on start 1- TListItem.MakeVisible does not work on MacOS <https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/39379> 2- [Cocoa] TListView.GetItemAt returns wrong item when ShowColumnHeaders=true <https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/39372> 3- forum, patch by Zoe, Demo to benchmark TextOut on win64/gtk2/Cocoa - Cocoa is very slow <https://forum.lazarus.freepascal.org/index.php/topic,55431.0.html>

If/Once they are in Dmitry's branch they will get merged. My understanding (and that coincides with Dmitry's feedback yesterday) is that he is managing the Cocoa development.

From what I can see (issue comments) both issues have a fix in that branch. So they should get handled.

About the issue on the forum.
Forum posts get lost over time. And they do not always get noted by the core team member that could help.
Therefore
- if your/everyones intend is to wait for other forum members to help => all is fine.
- if you like the attention of a core team member, and currently no member has stated they are looking at it, you may have to reach out beyond the forum.
  Not all team members are all the time active on the forum. You may try to reach out on the mail list.

If you can't get anyones attention now, the report on the bugtracker, giving a link to the forum and a brief summary.
When and if a team member has time, they will have a look. Notes about the nature of the post (proof of concept / only for testing / intend to inspire) can be added on the forum and/or the issue.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus-ide.org/pipermail/lazarus/attachments/20210929/d00c12e7/attachment.html>

Reply by email