Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / lazarus / 2021-03

Type used in function TListItem.GetState()

1 message · 1 person ·

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Juha Manninen

Partly related to issue
https://bugs.freepascal.org/view.php?id=38565

I changed function TListItem.GetState to use enum TListItemState directly instead of casting it to an integer.
It allows to remove many ugly typecasts.
I don't see any problems caused by it. None of the properties are published, thus component streaming is not a problem. However I don't know TListView very well, somebody may spot a potential problem.
So, is it safe to apply? Please see the attached patch.

Juha
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus-ide.org/pipermail/lazarus/attachments/20210321/b791551e/attachment.html> -------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-State-index-TListItemState.patch
Type: text/x-patch
Size: 4872 bytes
Desc: not available
URL: <http://lists.lazarus-ide.org/pipermail/lazarus/attachments/20210321/b791551e/attachment.bin>

Reply by email