Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / lazarus / 2018-10

IDE Scout issue

4 messages · 3 people ·

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Juha Manninen
to Michael Van Canneyt
PM Michael Van Canneyt wrote 7 lines
Most if not all commands in the editor are registered, but do not do anything. The source editor simply looks up the key combination in the commands, and then invokes the main menu. The TIDECommand.Execute does method not do anything. This is a design error in the IDE, it needs to be fixed at a fundamental level.

Indeed, I remember the commands are invoked in different ways which feels wrong. I don't remember details, it was some time ago I looked at them.
Maybe AlexeyT could take a look.

Regards,
Juha

Reply by email

Michael Van Canneyt
to Juha Manninen
Juha Manninen wrote 16 lines
On Sun, Oct 14, 2018 at 7:55 PM Michael Van Canneyt via Lazarus wrote: > Most if not all commands in the editor are registered, but do not do > anything. The source editor simply looks up the key combination in the > commands, and then invokes the main menu. > The TIDECommand.Execute does method not do anything. > > This is a design error in the IDE, it needs to be fixed at a fundamental > level. Indeed, I remember the commands are invoked in different ways which feels wrong. I don't remember details, it was some time ago I looked at them. Maybe AlexeyT could take a look. From what I can see, it should be sufficient to create a descendent of

TIDECommand with the ec* editor command constant as a property, and register this descendant as an IDE command with the main menu callback as the command callback, and the source editor, after looking up the command using the key combination, must simply call .execute instead of calling the main menu function...

Unless of course there are some hidden pitfalls :)

Michael.

Reply by email