Hello,

I've polished something that was started during the Lazarus Pro conference in Bonn the last days, the IDE Spotter (this is a "Working Title").

The idea is to have a command box such as it exists in Atom or Visual code studio.

Press ALt-Shift-P (or Meta-Shift-P on Mac) to access it.

Type the command you wish (e.g. open), navigate with arrows or click on the correct match. The command will be executed. You can type multiple words. all parts must be matched (and are colorized).

You can find the package under 'components/idespotter' in SVN. It should also work under 1.8.4/2.0rc1 for those that want to try it.

There are some options under Tools - Options - Environment - IDE Spotter.

Ideas for improvements are currently:
- Shrink window list if the match list is "small".
- Search in recent files (projects/units/packages)
- ... ?

Please testdrive it.
Ideas for improvements/comments/bugreports welcome (well, the latter not so much ;)).

Thanks go to James Ralston for pitching the idea, and Mattias for including it in SVN !

Michael.

Michael Van Canneyt wrote

Please testdrive it. Ideas for improvements/comments/bugreports welcome (well, the latter not so much ;)).

Unit IDESpotterOptions missing in svn?

Ahaha.... The infamous 'forgot to add units' problem in SVN :)

I added them, thanks !

Michael.

Seems not work on windows though, even after I assigned another shortcut.

Hm. What does not work, showing the form ?

It's also in the menu under View - IDE internals - IDE spotter. Does it work then ?

Strange, I tested both Mac and Linux.

Michael.

If you are using a docked IDE, I just fixed positioning the spotter for that case.

Mattias

Indeed, this fixed it, thanks.

Ah. That's what your change meant...

Good you left a comment now, many thanks! :)

(I guess everyone now guessed, I don't use the docking IDE...)

Michael.

PM Michael Van Canneyt wrote

(I guess everyone now guessed, I don't u

I thought that I was the last one not using a docked IDE :)

Marcos Douglas

Marcos Douglas B. Santos wrote

On Sun, Sep 23, 2018 at 2:28 PM Michael Van Canneyt via Lazarus wrote: > (I guess everyone now guessed, I don't u I thought that I was the last one not using a docked IDE :)

Docked IDE (unless the term is used differently from how I understand it) doesn't make much sense if you have a multi-screen setup, IMHO...

Ralf

---
This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

It does if the second screen is not mainly for development. E.g. I myself use both Lazarus and Visual Studio on my primary monitor while I have the browser open on the other. And sometimes if I need to look at two documents at once I can open a new editor window in both IDEs and move it to the second screen to better compare them or whatever I need to do. :)

Regards,
Sven

Well, I just like to move the separate windows across the screens, basic IDE with project info on the default screen, usually the debugging.messaging stuff on it as well, and the editor windows on the second one. For a time, I even had a 3 screen setup, with the application output (or research browser, depending on the development stage) on the third screen...

Ralf

---
This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

Docked SDI.

Docked means you can attach windows together. You can still distribute windows over various screens.

Mattias

Tested IDE Spotter on Linux / GTK2.
Looks promising although it leaks memory.

Regards,
Juha

---
Heap dump by heaptrc unit
4466835 memory blocks allocated : 800495659/813452344 4464534 memory blocks freed : 800391839/813341848 2301 unfreed memory blocks : 103820
True heap size : 4259840
True free heap : 3778816
Should be : 3854816
Call trace for block $00007F710BF15940 size 20
$00000000013CB5CC line 179 of frmspotter.pas
$0000000000667CE0 line 652 of include/customedit.inc $0000000000667C5A line 644 of include/customedit.inc $00000000005E7E74 line 1203 of include/control.inc $0000000000431B9F
$00000000005D8DD7 line 5425 of include/wincontrol.inc $0000000000667557 line 528 of include/customedit.inc $000000000082BCE0 line 112 of lclmessageglue.pas
Call trace for block $00007F712645C680 size 20
$00000000013CB5CC line 179 of frmspotter.pas
$0000000000667CE0 line 652 of include/customedit.inc $0000000000667C5A line 644 of include/customedit.inc $00000000005E7E74 line 1203 of include/control.inc $0000000000431B9F
$00000000005D8DD7 line 5425 of include/wincontrol.inc $0000000000667557 line 528 of include/customedit.inc $000000000082BCE0 line 112 of lclmessageglue.pas
Call trace for block $00007F712645C800 size 20
$00000000013CB5CC line 179 of frmspotter.pas
$0000000000667CE0 line 652 of include/customedit.inc $0000000000667C5A line 644 of include/customedit.inc $00000000005E7E74 line 1203 of include/control.inc $0000000000431B9F
$00000000005D8DD7 line 5425 of include/wincontrol.inc $0000000000667557 line 528 of include/customedit.inc $000000000082BCE0 line 112 of lclmessageglue.pas
Call trace for block $00007F712645C8C0 size 20
$00000000013CB5CC line 179 of frmspotter.pas
$0000000000667CE0 line 652 of include/customedit.inc $0000000000667C5A line 644 of include/customedit.inc $00000000005E7E74 line 1203 of include/control.inc $0000000000431B9F
$00000000005D8DD7 line 5425 of include/wincontrol.inc $0000000000667557 line 528 of include/customedit.inc $000000000082BCE0 line 112 of lclmessageglue.pas
Call trace for block $00007F712645B300 size 20
$00000000013CB5CC line 179 of frmspotter.pas
$0000000000667CE0 line 652 of include/customedit.inc $0000000000667C5A line 644 of include/customedit.inc $00000000005E7E74 line 1203 of include/control.inc $0000000000431B9F
$00000000005D8DD7 line 5425 of include/wincontrol.inc $0000000000667557 line 528 of include/customedit.inc $000000000082BCE0 line 112 of lclmessageglue.pas
Call trace for block $00007F712645CD40 size 20
$00000000013CB5CC line 179 of frmspotter.pas
$0000000000667CE0 line 652 of include/customedit.inc $0000000000667C5A line 644 of include/customedit.inc $00000000005E7E74 line 1203 of include/control.inc $0000000000431B9F
$00000000005D8DD7 line 5425 of include/wincontrol.inc $0000000000667557 line 528 of include/customedit.inc $000000000082BCE0 line 112 of lclmessageglue.pas
Call trace for block $00007F712645A7C0 size 20
$00000000013CB5CC line 179 of frmspotter.pas
$0000000000667CE0 line 652 of include/customedit.inc $0000000000667C5A line 644 of include/customedit.inc $00000000005E7E74 line 1203 of include/control.inc $0000000000431B9F
$00000000005D8DD7 line 5425 of include/wincontrol.inc $0000000000667557 line 528 of include/customedit.inc $000000000082BCE0 line 112 of lclmessageglue.pas
Call trace for block $00007F712645CF80 size 20
$00000000013CB5CC line 179 of frmspotter.pas
$0000000000667CE0 line 652 of include/customedit.inc $0000000000667C5A line 644 of include/customedit.inc $00000000005E7E74 line 1203 of include/control.inc

Juha Manninen wrote

Tested IDE Spotter on Linux / GTK2. Looks promising although it leaks memory.

Hm. How to fix this ? because line 179 is:

if SpotterForm=Nil then
   begin
   SpotterForm:=TSpotterForm.Create(Application);

The form is owned by the TApplication instance. If the application is freed, the form should also be freed. That's TComponent 101...

From your stack trace, it would seem that the form is created multiple

times, which is also strange, since it's a singleton pattern.

The form is set to do coHide on close, so it should not be freed on close.

Michael.

The stack trace is highly misleading.

I applied a possible fix; Please test and report.

Michael.

This is a great idea. My window manager, i3, works very well with a feature like this. Sadly a lot of actions are application specific and require that specific application to support "hinting" (to work with a general solution) or to implement their own solution.

You may want to look at https://pwmt.org/projects/girara/, which provides a vim-like input for an application. It finds use in Zathura (PDF reader) and Jumanji (browser, not usable iirc).

Cheers,
R0b0t1

AM Michael Van Canneyt wrote

I applied a possible fix; Please test and report.

The Subversion server and bug tracker are down. I will try later again.

Juha

They work here ?

Michael.

1- If i hold Up/Down key (edit is focused), i dont get many up/down moves in listbox.
(only one move. Ubuntu 18 gtk2).

2- colors (red, green) are configurable?

Alex

3- input (edit) is not autosized, so height is small on Ubuntu.

4- if window is narrow: hotkey overlaps caption. better do: caption overlaps hotkey.

Alex

5- on opening window, list is empty. i type "d", backspace, now list is _not empty?

Alex

AlexeyT wrote

1- If i hold Up/Down key (edit is focused), i dont get many up/down moves in listbox. (only one move. Ubuntu 18 gtk2).

Don't keep it pressed. press multiple times.

2- colors (red, green) are configurable?

Yes. See "Tools - Options - Environment - IDE Spotter".

This is actually documented in the Readme.txt file of the package.

The readme.txt is mandatory for lazarus packages.
Seems like a waste of effort :(

Michael.

AlexeyT wrote

3- input (edit) is not autosized, so height is small on Ubuntu.

So ?

4- if window is narrow: hotkey overlaps caption. better do: caption overlaps hotkey.

I disagree. I specially chose it like this.

Michael.

AlexeyT wrote

5- on opening window, list is empty. i type "d", backspace, now list is _not empty?

I will change this.

Michael.

Maybe add a small button for settings.

This is actually documented in the Readme.txt file of the package. The readme.txt is mandatory for lazarus packages. Seems like a waste of effort :(

The readme.txt is for those browsing the folders, while the description in the lpk is for those installing a package. It's ok to use a short description and then point to the full description - location of your choice.
And you can add a help button for users.

Mattias

OK. How to open the settings dialog on a particular tab ?

The readme.txt is contained in the package files.
So you can see it in the list. This seems kind of redundant.

But I have referred to the readme in the description... Small effort after all.

It's ok to use a short description and then point to the full description - location of your choice. And you can add a help button for users.

Nono, I think the window should be as minimalistic as possible.

I even think the settings button is already a violation of my almost non-existing esthetic feelings... :)

Michael.

Done.

Originally there were some resizing problems. At some point I indeed disabled AutoSize, because the effect of AutoSize for an edit is totally unclear to me.

Michael.

 >I think the window should be as minimalistic as possible.

good to add: spacing around edit (top, left, right) and listbox (left, right, bottom), 4-6pixels.

R0b0t1 wrote

IDE Spotter (this is a "Working Title").

Sublime Text and CudaText and Atom: name is Command Palette, better use this.

1- better use default color purple (or dark blue, Navy) instead of red.

2- w/o opened source editor, spotter don't called by hotkey. instead Project mainmenu pops up.

AlexeyT wrote

On 24.09.2018 13:26, R0b0t1 via Lazarus wrote: > IDE Spotter (this is a "Working Title"). Sublime Text and CudaText and Atom: name is Command Palette, better use this.

Originally I did exactly that. But Mattias wanted a more catchy name.

We still plan to add search in recent items, in which case it will be more than just commands...

Michael.

AlexeyT wrote

1- better use default color purple (or dark blue, Navy) instead of red.

Good point. Will change.

2- w/o opened source editor, spotter don't called by hotkey. instead Project mainmenu pops up.

Seems like a bug in the shortcut key handling of Lazarus... ? (Alt-P activates the 'Project' menu)

Michael.

I suggest shorter title - Runner.

3- better add inner (inside listbox) left indent of text: 3-4pix.

4- right indent is too big (15-20pix even with scrollbar), use same 3-4pix as left (considering scrollbar)

AlexeyT wrote

3- better add inner (inside listbox) left indent of text: 3-4pix.

Will do.

4- right indent is too big (15-20pix even with scrollbar), use same 3-4pix as left (considering scrollbar)

Currently, the scroll bar width as reported is always used as indent, plus The 'W' width. Without it, the shortcut key was never drawn correctly.

How do I know if the scrollbar is visible ?

Michael.

OK, thank you.
But should not the Rect in the ListBox OnDrawItem already take this into account ?

Michael.

TEdit.Autosize does autosizing of edit's Height to its Font (mainly font.size or font.height). It does not affect edit's Width. V.

[...] > Maybe add a small button for settings. OK. How to open the settings dialog on a particular tab ?

Something like this
LazarusIDE.DoOpenIDEOptions(TYourIDEOptionsFrame);

There are multiple entry points to find your help, yes.

But I have referred to the readme in the description... Small effort after all.

:)

Mattias

auto-key-repeat is ignored?

I don't know what messages are sent when the key is held down. I assume when you keep the key down, only key-down messages are sent. At this moment, the key-up event is used. I will investigate it.

Michael.

KeyPress

I assume when you keep the key down, only key-down messages are sent. At this moment, the key-up event is used. I will investigate it.

Mattias

I doubt that.

procedure TSpotterForm.ESearchKeyPress(Sender: TObject; var Key: char);

This signature cannot handle an arrow key or shift state. Those are only available in key down/up events.

Michael.

I committed a new version with some visual improvements and bugfixes:

* Actually load saved options on startup :)
* Button to go to settings
* Margins around controls
* Better Left and right margin inside listbox
* Use different default colors (maroon, navy)
* Handle keydown instead of key up, so repeat is enabled...

Michael.

A further issue: Spotter appears not to know about menu items added by some packages.

For instance, LazProfiler adds three new menu items to the IDE, but Spotter does not list them.

Howard

I don't know how lazprofiler installs itself, so I can't comment.

But in general, I suppose that is possible. It only lists available commands. If a package installs a menu item without a command, then it will not be visible in the spotter...

See it as an incentive for package maintainers to install commands instead of simply menu items : I can imagine that installing commands also makes them available for e.g. the editor toolbar.

But I suppose some lazarus dev needs to comment on the exact inner workings.

Michael.

1. Standard for margins around controls in Lazarus is 6 pixels. Now is lesser. This is very noticeable visually.

2. Spotter does not respect IDE option "Prefer double-click over single-click". It is very uncomfortable for people who prefer double click in lists.

Really ? You must have 100/10 vision. I don't see any difference.

But I can say with certainty the IDE is not consistent in this regard, e.g. the project inspector uses different spacing than the IDE Options dialog. The only reason I saw that is because of your remark I started putting things side by side.

2. Spotter does not respect IDE option "Prefer double-click over single-click". It is very uncomfortable for people who prefer double click in lists.

Really ? I did not know all these things.

The single click was chosen because this is how it works in Atom.

Where are all these options or rules described ?

Because the IDE Tools - Options page does not contain such a setting. Or at least, I didn't find it.

If I select something, it's always single click.
Project inspector, IDE Tools - Options treeview. Everywhere.

Michael.

Read wiki:
http://wiki.lazarus.freepascal.org/GUI_design_guidelines#Spacings_and_sizes

"Spacing between elements: 6 pixels."

Don't forget about filter. Just insert "do".
It placed here:
Tools/Options/Environment/General/Section "Mouse Action", Checkbox "Prefer double-click over single-click".

If I select something, it's always single click. Project inspector, IDE Tools - Options treeview. Everywhere.

This option has an impact, in particular, on "Search results" form, "ToDo List" and etc. 

More suitable quote from wiki:
http://wiki.lazarus.freepascal.org/GUI_design_guidelines#BorderSpacing  

"A typical borderspacing of 6 pixels around a component is used."

I already found it.
It's not available in packages, only forms internal to the IDE can access this setting.

> If I select something, it's always single click. > Project inspector, IDE Tools - Options treeview. Everywhere. This option has an impact, in particular, on "Search results" form, "ToDo List" and etc. 

I discussed this with Mattias.
While the option you mention is useful for the windows you mention, We think the IDE spotter is more like a dropdown in functionality. So single click.

But I will change the spacing.

Michael.