Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / lazarus / 2017-11

[PATCH] Menu item "Rename identifier" shows as inactive if caret is placed at the end of an identifier

6 messages · 3 people ·

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Dmitry D. Chernov

This is slightly related with recently fixed #32606: my patch fixes only wrong inactive state, patch for #32606 fixes determination of the identifier under the carriage, as a whole.

This bug is very annoying when you selecting identifier to rename by double-clicking LMB on it.

___

Dmitry D. Chernov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: synedit.pp.patch
Type: text/x-diff
Size: 637 bytes
Desc: not available
URL: <http://lists.lazarus-ide.org/pipermail/lazarus/attachments/20171114/41537c93/attachment.patch>

Reply by email

Juha Manninen
to Dmitry D. Chernov
Dmitry D. Chernov wrote
This is slightly related with recently fixed #32606: my patch fixes only wrong inactive state, patch for #32606 fixes determination of the identifier under the carriage, as a whole. This bug is very annoying when you selecting identifier to rename by double-clicking LMB on it.

Sorry I did not understand what the problem is.
Inactive state of what? Are you renaming an identifier (F2)?

Juha

Reply by email

Mattias Gaertner
to Dmitry D. Chernov: This is slightly related with recently fixed #32606: my patch fixes only wrong inactive…
This is slightly related with recently fixed #32606: my patch fixes only wrong inactive state, patch for #32606 fixes determination of the identifier under the carriage, as a whole. This bug is very annoying when you selecting identifier to rename by double-clicking LMB on it.

You don't need to select an identifier. You simply place the caret at it.

Mattias

Reply by email

Dmitry D. Chernov
to Mattias Gaertner

Sorry, but it's just about convenience, because F2 is working now in this case (after patching #32606), unlike the corresponding menu item.

14.11.2017, 02:51, "Mattias Gaertner via Lazarus" :

Show quoted text 16 lines
On Tue, 14 Nov 2017 01:26:32 +1000 "Dmitry D. Chernov via Lazarus" wrote: >  This is slightly related with recently fixed #32606: my patch fixes only wrong inactive state, patch for #32606 fixes determination of the identifier under the carriage, as a whole. > >  This bug is very annoying when you selecting identifier to rename by double-clicking LMB on it. You don't need to select an identifier. You simply place the caret at it. Mattias -- _______________________________________________ Lazarus mailing list https://lists.lazarus-ide.org/listinfo/lazarus

Reply by email

Dmitry D. Chernov
to Juha Manninen: On Mon, Nov 13, 2017 at 5:26 PM, Dmitry D. Chernov via Lazarus Sorry I did not understand…

Here's a video with the demonstration of the bug in Lazarus 1.6.4. https://yadi.sk/i/QkJEi53d3PfKiU

14.11.2017, 02:32, "Juha Manninen via Lazarus" :

Show quoted text 15 lines
On Mon, Nov 13, 2017 at 5:26 PM, Dmitry D. Chernov via Lazarus wrote: >  This is slightly related with recently fixed #32606: my patch fixes only wrong inactive state, patch for #32606 fixes determination of the identifier under the carriage, as a whole. > >  This bug is very annoying when you selecting identifier to rename by double-clicking LMB on it. Sorry I did not understand what the problem is. Inactive state of what? Are you renaming an identifier (F2)? Juha -- _______________________________________________ Lazarus mailing list https://lists.lazarus-ide.org/listinfo/lazarus

Reply by email