In Lazarus trunk, the message window and object inspector is alwas on top and hides everything thats behind it. It also hides the code completion window (ctrl+space) so you cant read some of it. See screenshot. This happened 1-2 months ago. I was about to report this in the bugtracker when I saw that it is only for up to Laz 1.63 SVN, not the trunk.

kapibara

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus-ide.org/pipermail/lazarus/attachments/20170217/4b3f7e13/attachment.html>

Kapibara Pas wrote

In Lazarus trunk, the message window and object inspector is alwas on top and hides everything thats behind it. It also hides the code completion window (ctrl+space) so you cant read some of it. See screenshot. This happened 1-2 months ago.

It works for me and for many other people. It must be a local config or build issue of some sort.

I was about to report this in the bugtracker when I saw that it is only for up to Laz 1.63 SVN, not the trunk.

I can see "1.7 (SVN)" there. It may be a user rights issue. All data may not be visible for everybody even if it should. Anyway, don't report unless somebody else can reproduce.

Juha

Hi again. This issue exist only with Lazarus trunk and started a few months ago. Release and fixes doesn't have that problem. If I back down a few revisions, the "always on top" stops. So it is highly unlikely that rights, builds, configs or similar has anything to do with it. I don't know exactly when (or why) this was introduced. Could prolly track it down, but already spent a weeks share of time with the "Iron curtain bug". ;-)

Btw, closing the "always on top" Message Window to be able to view the obscured code completion list hangs the list window and Lazarus has to be restarted. Linux GTK2.

kapibara

Kapibara Pas wrote

Could prolly track it down, but already spent a weeks share of time with the "Iron curtain bug". ;-)

Please bisect the guilty revision!

Bart

Bart, rev. 53831 introduced the bug. http://bugs.freepascal.org/view.php?id=13051

I uploaded a patch for each affected file and added a note.

lcl/interfaces/gtk2/gtk2wsforms.pp
lcl/interfaces/gtk2/gtk2globals.pp

Index: gtk2wsforms.pp
=================================================================== --- gtk2wsforms.pp (revision 53831)
+++ gtk2wsforms.pp (revision 53830)
@@ -724,12 +724,8 @@

   begin
     if AForm.HandleObjectShouldBeVisible and
       GTK_IS_WINDOW({%H-}PGtkWindow(AForm.Handle)) then

- begin
- gtk_window_set_type_hint({%H-}PGtkWindow(AForm.Handle),
- GtkWindowTypeHints[AForm.BorderStyle]); gtk_window_set_keep_above({%H-}PGtkWindow(AForm.Handle), GBoolean(AForm.FormStyle in fsAllStayOnTop))
- end
else
if (AForm.FormStyle in fsAllStayOnTop) and
not (csDestroying in AWinControl.ComponentState) then @@ -1041,16 +1037,10 @@
end;

 class procedure TGtk2WSHintWindow.ShowHide(const AWinControl: TWinControl);
-var
-  bVisible: boolean;
 begin
   if not WSCheckHandleAllocated(AWinControl, 'SetColor') then
     exit;
-
-  bVisible := AWinControl.HandleObjectShouldBeVisible;
-  if bVisible then
-    gtk_window_set_type_hint(PGtkWindow(AWinControl.Handle), GDK_WINDOW_TYPE_HINT_TOOLTIP);
-  Gtk2WidgetSet.SetVisible(AWinControl, bVisible);
+  Gtk2WidgetSet.SetVisible(AWinControl, AWinControl.HandleObjectShouldBeVisible);
   InvalidateLastWFPResult(AWinControl, AWinControl.BoundsRect);
 end;

Index: gtk2globals.pp
=================================================================== --- gtk2globals.pp (revision 53831)
+++ gtk2globals.pp (revision 53830)
@@ -73,18 +73,7 @@

var

   Styles : TStrings;

-
-const
- //(bsNone, bsSingle, bsSizeable, bsDialog, bsToolWindow, bsSizeToolWin);
- GtkWindowTypeHints: array[TFormBorderStyle] of TGdkWindowTypeHint = (
- GDK_WINDOW_TYPE_HINT_NOTIFICATION,
- GDK_WINDOW_TYPE_HINT_DIALOG,
- GDK_WINDOW_TYPE_HINT_NORMAL,
- GDK_WINDOW_TYPE_HINT_DIALOG,
- GDK_WINDOW_TYPE_HINT_UTILITY,
- GDK_WINDOW_TYPE_HINT_UTILITY
- );
-
+
var

   DefaultPangoLayout: PPangoLayout = nil;

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus-ide.org/pipermail/lazarus/attachments/20170217/23feb7e7/attachment.html>

Uploaded my tiny fix , there too

Kapibara Pas wrote

I uploaded a patch for each affected file and added a note.

Kapibara Pas wrote

Bart, rev. 53831 introduced the bug. http://bugs.freepascal.org/view.php?id=13051 I uploaded a patch for each affected file and added a note.

I can confirm that I am seeing this bug (messages window always on top), and that the applying gtk2_modaldlg1.patch from that bug report fixes it for for me. I am using the XFCE window manager on Fedora.

Colin

I am also using XFCE, but on Debian 9

kapibara wrote

I am also using XFCE, but on Debian 9

Please open a bugreport about it.
Mention the revision that caused this for you.
Don't forget to mention you use XFCE, it may be significant.

Bart

I added my comment to http://bugs.freepascal.org/view.php?id=13051 (It looks like different manifestations of the same underlying problem)

Colin

No need, the issue has been discussed on mantis
http://bugs.freepascal.org/view.php?id=13051 . It was a consequence of a wrong patch from the issue report.

I commited a fix.

Ondrej