Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / lazarus / 2017-10

Pascalscript / testers please

4 messages · 2 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Martin Frb

I updated the version of PascalScript shipped with Lazarus.

As we still have a few patches applied, I wonder how well it works on each platform.

If you like to test....

To test use Lazarus trunk (1.9).
  Revision: 56200
  Date: 25 October 2017 22:33:11
or later.

Only trunk has the latest version of pascalscript, and any test against older versions will not the testcase components\PascalScript\dunit\ifps3.lpi and run it.

Please report:
- fpc versions
- OS
- CPU/ 32/64Bit
- test results
- if you have: test results with Lazarus 1.8 or 1.6.4 (same old version of PascalScript)

You may also check in the IDE, go to options => EditorMacroScripting and see if "scripting active" is shown.

Thanks

Reply by email

kapibara
to Martin Frb

The testcase runs 100% fine under Linux Debian 9 - 64 bit. Even 64 bit constructors work now. This is very good news!

A long time ago, FPC rev. 26683 broke pascalscript's 64 bit support for constructors so I didn't expect that to work. A while ago I was trying to fix it, after three days of looking I found the responsible version and lines of code and then had a discussion with Carlo Kok about it: https://github.com/remobjects/pascalscript/issues/154

The code that needed fixing was written in assembler (pascalscripts x64.inc) which I don't understand, and Carlo didn't say he fixed it. So I'm curious who did, you or Carlo?

Martin Frb wrote 32 lines
I updated the version of PascalScript shipped with Lazarus. As we still have a few patches applied, I wonder how well it works on each platform. If you like to test.... To test use Lazarus trunk (1.9).    Revision: 56200    Date: 25 October 2017 22:33:11 or later. Only trunk has the latest version of pascalscript, and any test against older versions will not help at all. Open the testcase  components\PascalScript\dunit\ifps3.lpi and run it. Please report: - fpc versions - OS - CPU/ 32/64Bit - test results - if you have: test results with Lazarus 1.8 or 1.6.4 (same old version of PascalScript) You may also check in the IDE, go to options => EditorMacroScripting and see if "scripting active" is shown. Thanks

Reply by email

Martin Frb
to kapibara
kapibara wrote 13 lines
The testcase runs 100% fine under Linux Debian 9 - 64 bit. Even 64 bit constructors work now. This is very good news! A long time ago, FPC rev. 26683 broke pascalscript's 64 bit support for constructors so I didn't expect that to work. A while ago I was trying to fix it, after three days of looking I found the responsible version and lines of code and then had a discussion with Carlo Kok about it: https://github.com/remobjects/pascalscript/issues/154 The code that needed fixing was written in assembler (pascalscripts x64.inc) which I don't understand, and Carlo didn't say he fixed it. So I'm curious who did, you or Carlo?

I submitted a pull request for the 64bit constructor earlier today.

Actually the asm code didn't need changes. The 2 issues where
- which register to use for what data.  Compile an fpc example with -al and see what fpc uses. Then luckily all necessary changes existed in the 32 bit include, so I could copy it with minor changes.
- a wrong typecast of a 64 bit address to 32 bit.

I didnt know when this was changed in fpc, so the fix now breaks it for older fpc  < 3.0

Reply by email

kapibara
to Martin Frb: I updated the version of PascalScript shipped with Lazarus. As we still have a few…

Well, I got so excited and forgot to give full information:

Latest Lazarus trunk and Free Pascal Compiler version 3.0.4rc1 [2017/08/05] for x86_64

OS: Debian 9 - 64 bit

CPU: Intel(R) Pentium(R) CPU G3258 @ 3.20GHz

Results: 30/30 success, 0 errors, 0 failures

Time elapsed: 00.00.00.237

Options => EditorMacroScripting says "Scripting active"

//Roger
Martin Frb wrote 32 lines
I updated the version of PascalScript shipped with Lazarus. As we still have a few patches applied, I wonder how well it works on each platform. If you like to test.... To test use Lazarus trunk (1.9).    Revision: 56200    Date: 25 October 2017 22:33:11 or later. Only trunk has the latest version of pascalscript, and any test against older versions will not help at all. Open the testcase  components\PascalScript\dunit\ifps3.lpi and run it. Please report: - fpc versions - OS - CPU/ 32/64Bit - test results - if you have: test results with Lazarus 1.8 or 1.6.4 (same old version of PascalScript) You may also check in the IDE, go to options => EditorMacroScripting and see if "scripting active" is shown. Thanks

Reply by email