Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / lazarus / 2017-10

Request for merge to 1.8

6 messages · 2 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Juha Manninen
to FTurtle
FTurtle wrote
Could revisions 56094, 56095 be merged to 1.8 ? (Arrange ToolBarConfig categories in a natural way.) Report: https://bugs.freepascal.org/view.php?id=32557

Only bug fixes should go to 1.8 now. Arranging categories differently is not a bug fix really.
There is another problem with merging: I refactored and simplified the code a little earlier, removing a useless indirection. r56094 may not merge easily. Could you please test the merging.

Juha

Reply by email

FTurtle
to Juha Manninen
There is another problem with merging: I refactored and simplified the code a little earlier, removing a useless indirection. r56094 may not merge easily. Could you please test the merging.

I attached patch.

FTurtle -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.lazarus-ide.org/pipermail/lazarus/attachments/20171022/6facdacc/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: patch.diff Type: application/octet-stream Size: 2685 bytes Desc: not available URL: <http://lists.lazarus-ide.org/pipermail/lazarus/attachments/20171022/6facdacc/attachment.obj>

Reply by email

FTurtle
to Juha Manninen: On Sun, Oct 22, 2017 at 11:43 AM, FTurtle via Lazarus Only bug fixes should go to 1.8…
Could you please test the merging.

Some changes was merged, some - not.
But I found only one thing that affects functionality for users:

Now in TToolBarConfig.UpdateButtonsState we have:

trunk:
btnAddDivider.Enabled := True;
fixes:
btnAddDivider.Enabled:=(lvToolbar.Selected = nil) or (lvToolbar.Selected.Caption  cIDEToolbarDivider);

Thus, in fixes button "Add divider" prohibited when in right list selected divider. It is not error, rather a flaw.

FTurtle -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.lazarus-ide.org/pipermail/lazarus/attachments/20171023/731e9bd0/attachment.html>

Reply by email

Juha Manninen
to FTurtle

Sorry FTurtle but I would rather keep this change in trunk only. People may have different opinions about the order. This is a typical change that must happen in the development version and not be pushed to the release at last minute.
Besides, you as a semi-developer of Lazarus will use mostly trunk I guess.

Juha

Reply by email