Hi,

Ondrej, I think you last worked on this? Not sure if you are still busy with this, otherwise I'll raise bug reports in Mantis for it.

* The edit box is too small. eg: on my screen, default view, brand new lazarus profile... the edit box is about 2cm wide, where as the class combobox dropdown is 13cm.

* The class combobox has tons of duplicates. It didn't before, thus making it pretty useless.

* There used to be an option to match text on the left only, or anywhere. This option is now gone.

I'm using the latest Lazarus trunc (updated yesterday).

Regards,
- Graeme -

Graeme Geldenhuys wrote

* There used to be an option to match text on the left only, or anywhere. This option is now gone.

Another bug.

* In now remembers the last searched text between Procedure List usages. So now searching for something new, I first have to select and delete the previous search text, then I can type my new search. I want to start typing immediately, like I use to do.

Regards,
- Graeme -

Graeme Geldenhuys wrote

* There used to be an option to match text on the left only, or anywhere. This option is now gone.

And yet another bug

* The Objects dropdown has a "<none>" option. This then displays all procedures or functions - things not in a Class, Record or Object. Selecting that options does nothing. In fact the dropdown doesn't seem to function at all any more.

Could we not rather revert all latest modifications??? The dialog is now completely f****d.

Regards,
- Graeme -

Graeme Geldenhuys wrote

Ondrej, I think you last worked on this?

Come on. Recently I have been bombed by so many people that think/guess/believe something without actually checking it. I unfortunately got already somehow allergic to this attitude. You are welcome to open SVN and see the log for the file ide/procedurelist.pas.

Ondrej

Ondrej Pokorny wrote

Come on. Recently I have been bombed by so many people that think/guess/believe something without actually checking it.

Appologies - I meant no harm.

As for checking the SVN log, SubVersion doesn't accurately reflect the author of a patch (unlike Git), instead it only shows the person that applied the patch. Commit message also doesn't always reveal this information either.

Either way, I now looked at the history and see Juha applied a patch (r50908) in December, from Alexey Torgashin. I suspect that is the patch that massively broke procedure list. I'll revert it locally and see if it resolves the problems.

Again, sorry for getting the author of the changes wrong.

Regards,
- Graeme -

Graeme Geldenhuys wrote

Ondrej, I think you last worked on this? Not sure if you are still busy with this, otherwise I'll raise bug reports in Mantis for it.

Actually I am the guilty one. I made it a modeless IDE window and used ListViewFilter component for the filter.
Yes, some things broke more. On the other hand the behavior felt partly broken already earlier.
Earlier you mentioned other things that broke already before my edits, like missing icons. I don't know what caused them. There is another mail thread about it.

Don't report yet. I will look at this within coming 2 weeks.

Juha

Juha Manninen wrote

On the other hand the behavior felt partly broken already earlier.

"Felt broken" and "is broken" are very different things. :) I use Procedure List daily - it's 90% of how I navigate the code I work on. So it works pretty well for me, and doesn't require mouse usage, and is optimised for keyboard usage. The only local mod I made (before yesterday's svn update) was to save/restore column widths to a INI file. I didn't know the preferred method for the whole of Lazarus IDE.

Anyway, I'll say again, the Procedure List in Trunk is unusable now. I reverted your patch to make it usable here. My suggestion is to revert your patch now and push to Trunk. At least then it will be usable again for everybody else using trunk. Then, at your own convenience, you can rework your patch until it is ready.

Regards,
- Graeme -

Graeme Geldenhuys wrote

Again, sorry for getting the author of the changes wrong.

No problem, just check the things first - it's mostly easy.

Furthermore I wouldn't say it is that bad that Juha introduced some regressions during the rewrite - if you want Lazarus to be developed further, there will be always regressions in the trunk. That's a part of the game. I am quite sure he'll be able to tidy things up. If he doesn't fix them quickly enough for you, you can still try to do it yourself. I even sometimes experience that it takes more time to fill an issue report than to actually fix a bug :)

Ondrej

Ondrej Pokorny wrote

Furthermore I wouldn't say it is that bad that Juha introduced some regressions during the rewrite - if you want Lazarus to be developed

I think it is pretty bad if you make changes that breaks 90% of the functionality and then you commit your changes and don't do anything further on it for 3 months. I will not accept such patches for fpGUI, tiOPF and OnGuard - the open source projects I manage and maintain. Neither will Linus do that for Linux. Why must it be okay for the Lazarus project.

Granted, SubVersion's workflows are normally very different from Git. With Git, developers have access to local-only commits (so doesn't need to share immediately with the world), they also normally work in "feature branches" and once the work is done, then merge it into "master" (aka Trunk). This way a "feature" can bake until it is ready - and not break things for everybody in the interim.

If he doesn't fix them quickly enough for you, you can still try to do it yourself.

I implemented the Procedure List functionality for Lazarus - I know how it works and what it is supposed to do. I'm not going to keep fixing things that others break on it.

Regards,
- Graeme -

Graeme Geldenhuys wrote

I implemented the Procedure List functionality for Lazarus - I know how it works and what it is supposed to do. I'm not going to keep fixing things that others break on it.

Unfortunately this happens all the time :(

Ondrej

2016-02-28 2:13 GMT-03:00 Ondrej Pokorny :

If is the case, i can revert the patch and ask the author to rework it to match the expected functionality

Luiz
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20160228/fd9ec91b/attachment.html>

I reverted r50908 in r51748. I think only that one revision was involved. I planned to work on the issue sooner but something else always came up. It is also true I don't fully understand the original filter logic. I must study it later.
Currently I am travelling with a mini-laptop and won't do real development now.

Graeme, do you know how to fix the other regressions that happened sometime earlier, like the missing icon thing? Patches are welcome.

Juha

hi,

Luiz Americo Pereira Camara wrote

If is the case, i can revert the patch and ask the author to rework it to match the expected functionality

Yes, I think this would be the best action forward.

Regards,
Graeme

Hi Juha,

Thanks for reverting the previous change.

Juha Manninen wrote

Graeme, do you know how to fix the other regressions that happened sometime earlier, like the missing icon thing? Patches are welcome.

Yes, not a problem. I'll make a patch and submit it to Mantis. I'll also create a patch to "more officially" save/restore the column widths.

Regards,
Graeme

Graeme Geldenhuys wrote

I'll also create a patch to "more officially" save/restore the column widths.

Maybe that should wait a little. Ondrej is making a generic configuration API for storing column widths of all IDE ListViews. ProcedureList can use the same.

Juha

Juha Manninen wrote

Maybe that should wait a little. Ondrej is making a generic configuration API for storing column widths

OK, thanks for letting me know.

Regards,
Graeme