Hi,

Just curious: if I ask code completion in a class

TMyClass = Class(TMYParentClass)
Protected
Procedure Valid|

Cursor is at |. I ask the codetools to complete in order to override a method in the parent class.
It doesn't show a procedure that it I KNOW is present in the parent class.

Then it dawned on me: the procedure exists, but is Public. I changed the visibility to public, and then I got the procedure.

So:
do the codetools refuse to show identifiers with less restricted visibility ? (so in a protected section, I will not get public)

Is this intentional ?

I can imagine it is confusing to the beginner and experienced dev alike...

Michael.

Please report the bug.

Mattias

Hi,
?
It is a bug? I know this behaviour for a long time and I always believed it is by design. ?
V.
______________________________________________________________

Please report the bug.

Mattias

Hi, ? It is a bug? I know this behaviour for a long time and I always believed it is by design.

FPC gives a warning, so it is bad coding, but it is not forbidden.

Maybe it would be better to show them in the completion box with some warning marker.

Mattias

Vojt?ch ?ih?k wrote

It is a bug? I know this behaviour for a long time and I always believed it is by design.

I also came across it and it confused me for a second as well. Then I realized my mistake.

But anyway, you can do it and the code compiles, so CodeTools should allow it. During the compilation you get a hint about "overriden method has lower visibility [...]", if I remember correctly.

So yes, to avoid confusion I would say the visibility filter is unnecessarily restrictive.

+ What bugs me even more is that protected methods are not available with the inherited keyword:

procedure TMyClass2.Foo;
begin
   inherited Proc // CodeTools do not list Proc that is in protected
section of parent class from different unit. It works without the
"inherited" keyword, though
end;

I have to check why.

Ondrej

Mattias Gaertner wrote

Maybe it would be better to show them in the completion box with some warning marker.

+1 for that idea.

Regards,
- Graeme -

My public PGP key: http://tinyurl.com/graeme-pgp

Fixed this one in r51425. Hopefully with no regressions.

Ondrej

If you complete it like this:

TMyClass = Class(TMYParentClass)
Protected
Valid|

CodeTools list it (and also add it correctly as "procedure Valid;
override;").

So yes, it is a bug.

Ondrej

Fixed this one as well in r51426. The methods are shown in gray. Good night :)

Ondrej

+11111111 !

Michael.