r50058-50059 change "EditorToolBarOptions" node's values in environmentoptions.xml
after:
<EditorToolBarOptions Position="Left" Count="27">
<Button1 Name="Save"/>
<Button2 Name="SaveAll"/>
<Button3 Name="---------------"/>
<Button4 Name="Jump to Implementation"/>
<Button5 Name="---------------"/>
<Button6 Name="Open package file"/>
<Button7 Name="Open"/>
<Button8 Name="Open project"/>
<Button9 Name="CloseAll"/>
<Button10 Name="---------------"/>
<Button11 Name="Build project/program"/>

before:
<EditorToolBarOptions Position="Left" Count="31">
<Button1 Name="IDEMainMenu/File/itmFileOpenSave/itmFileSave"/> <Button2 Name="IDEMainMenu/File/itmFileOpenSave/itmFileSaveAll"/> <Button3
Name="IDEMainMenu/Search/itmJumpings/itmJumpToSection/itmJumpToInterfaceUses"/> <Button4 Name="---------------"/>
<Button5
Name="IDEMainMenu/Package/itmPkgOpening/itmPkgOpenPackageFile"/> <Button6 Name="IDEMainMenu/File/itmFileOpenSave/itmFileOpen"/> <Button7
Name="IDEMainMenu/Project/itmProjectOpenSection/itmProjectOpen"/> <Button8 Name="IDEMainMenu/File/itmFileOpenSave/itmFileCloseAll"/> <Button9 Name="---------------"/>
<Button10 Name="IDEMainMenu/Run/itmRunBuilding/itmRunMenuBuild"/> <Button11
Name="IDEMainMenu/Run/itmRunBuilding/itmRunMenuAbortBuild"/>

Yes, they changed. What's the problem?

Ondrej

In r50059 toolbarconfig.pas
procedure TIDEToolBarOptionsBase.SaveButtonNames(XMLConfig: TXMLConfig;
SubPath: String);
..
XMLConfig.SetDeleteValue(SubPath + 'Button' + IntToStr(I+1) + '/Name',
ButtonNames[I], '');
   has only this line, but loadbuttonnames has
ButtonName := XMLConfig.GetValue(SubPath + 'Button' + IntToStr(I) +
'/Name', '')
if ButtonName = '' then  // Old format
ButtonName := XMLConfig.GetValue(SubPath + 'Buttons/Name' + IntToStr(I)
+ '/Value', '');

this is from my environmentoptions.xml after add "build project" menu item, but its Caption has added shortcut and when save in environmentoptions.xml like this. You can see extra added "/" char, tag end chars.
And I wanna ask question, if I'm not misunderstood, in new format, captions are writing, if its yes its a problem.

<Button11 Name="Build project*/*program"/>
<Button12 Name="Compile project/program"/>
<Button13 Name="Abort building"/>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151015/8d598d18/attachment.html>

Not captions but command/button names.
I am still interested what the actual problem is.

Ondrej
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151015/24122b34/attachment.html>

I upgrade to r50070 then remove damaged lines, and readd old style values in environmentoptions.xml but same result. some buttons deleted, added some sperate lines
-) I removed all defined "desktop"s from menu, then from "editor toolbar settings" --> "restore default" reset IDE result is, After "Configure Toolbar" button 2 sparate doted lines and one dotted lines on end. -) Click to "Configure Toolbar" then direct click ok button, after "Configure Toolbar" button 2 sparate doted lines be one line, second line removed
-) Click to "Configure" button open "Toolbar Configuration" form, add "Build ( Shift + F9)" [I changed shortcut] to right site, then click to Ok button, then Re click to "Configure" button, Added "Build ( Shift + F9)" item been dotted sparated line

I hope helpfull

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151015/589c9ce7/attachment.html>

FreeMan wrote

I upgrade to r50070 then remove damaged lines, and readd old style values in environmentoptions.xml but same result...

You still have not explained what was the original problem you encountered. Did some of your configured buttons disappear?
Did they show wrong hints?
Something else?

Juha

Tell us namely what buttons disappeared. Maybe it was on purpose. I removed some buttons. Now only commands from MainIDE and SourceEditor are available as buttons - but all of them should be. So tell us what you miss.

Ondrej
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151015/99eeffdd/attachment.html>

I wrote problem, and how to do it, but sorry for my english.

Ok, I'll try one more time.
this is my old style IDE toolbar settings from environmentoptions.xml <EditorToolBarOptions Position="Left" Count="31">
<Button1 Name="IDEMainMenu/File/itmFileOpenSave/itmFileSave"/> <Button2 Name="IDEMainMenu/File/itmFileOpenSave/itmFileSaveAll"/> <Button3
Name="IDEMainMenu/Search/itmJumpings/itmJumpToSection/itmJumpToInterfaceUses"/> <Button4 Name="---------------"/>
<Button5
Name="IDEMainMenu/Package/itmPkgOpening/itmPkgOpenPackageFile"/> <Button6 Name="IDEMainMenu/File/itmFileOpenSave/itmFileOpen"/> <Button7
Name="IDEMainMenu/Project/itmProjectOpenSection/itmProjectOpen"/> <Button8 Name="IDEMainMenu/File/itmFileOpenSave/itmFileCloseAll"/> <Button9 Name="---------------"/>
<Button10 Name="IDEMainMenu/Run/itmRunBuilding/itmRunMenuBuild"/> <Button11
Name="IDEMainMenu/Run/itmRunBuilding/itmRunMenuAbortBuild"/> <Button12 Name="IDEMainMenu/Run/itmRunBuilding/itmRunMenuCompile"/> <Button13 Name="---------------"/>
<Button14 Name="IDEMainMenu/Run/itmRunnning/itmRunMenuRun"/> <Button15 Name="IDEMainMenu/Run/itmRunnning/itmRunMenuStop"/> <Button16
Name="IDEMainMenu/Run/itmRunnning/itmRunMenuResetDebugger"/> <Button17 Name="---------------"/>
<Button18 Name="IDEMainMenu/Run/itmRunnning/itmRunMenuStepInto"/> <Button19 Name="IDEMainMenu/Run/itmRunnning/itmRunMenuStepOver"/> <Button20 Name="---------------"/>
<Button21 Name="IDEMainMenu/Source/itmSourceTools/Message Composer"/>
<Button22 Name="---------------"/>
<Button23
Name="IDEMainMenu/Package/itmPkgOpening/itmPkgOpenPackageOfCurUnit"/> <Button24 Name="---------------"/>
<Button25 Name="SourceEditor/First static section/InsertToDo"/> <Button26 Name="IDEMainMenu/View/itmViewMainWindows/ViewToDoList"/> <Button27 Name="---------------"/>
<Button28 Name="IDEMainMenu/Search/itmJumpings/itmJumpBack"/> <Button29 Name="IDEMainMenu/Search/itmJumpings/itmJumpForward"/> <Button30 Name="---------------"/>
<Button31
Name="IDEMainMenu/Search/itmCodeToolSearches/itmSearchProcedureList"/> </EditorToolBarOptions>

If toolbar On Top, lookat to Red square in, two sparated lines

If toolbar OnLeft

This screenshot Configure settings, can see sparated lines (dotted lines) I'm not add thats.And See this mail's on top, toolbar settings data

This screenshot after Save settings, I mean click Ok Button just. Not changed anythink, just click ok. And data like this.

<EditorToolBarOptions Position="Left" Count="31">
<Button1 Name="Save"/>
<Button2 Name="SaveAll"/>
<Button3 Name="Jump to Interface uses"/>
<Button4 Name="---------------"/>
<Button5 Name="Open package file"/>
<Button6 Name="Open"/>
<Button7 Name="Open project"/>
<Button8 Name="CloseAll"/>
<Button9 Name="---------------"/>
<Button10 Name="---------------"/>
<Button11 Name="Abort building"/>
<Button12 Name="---------------"/>
<Button13 Name="---------------"/>
<Button14 Name="Run program"/>
<Button15 Name="Stop program"/>
<Button16 Name="Reset debugger"/>
<Button17 Name="---------------"/>
<Button18 Name="Step into"/>
<Button19 Name="Step over"/>
<Button20 Name="---------------"/>
<Button21 Name="---------------"/>
<Button22 Name="---------------"/>
<Button23 Name="Open package of current unit"/>
<Button24 Name="---------------"/>
<Button25 Name="---------------"/>
<Button26 Name="---------------"/>
<Button27 Name="---------------"/>
<Button28 Name="Jump back"/>
<Button29 Name="Jump forward"/>
<Button30 Name="---------------"/>
<Button31 Name="Procedure List ..."/>
</EditorToolBarOptions>

Problem not just this damages. I can not add "Build ( Shift + F9)" in toolbar still. I wrote this, in last my mail.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151015/5d02e743/attachment-0001.html> -------------- next part --------------
A non-text attachment was scrubbed...
Name: hcfaacbe.
Type: image/jpeg
Size: 14573 bytes
Desc: not available
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151015/5d02e743/attachment-0004.jpe> -------------- next part --------------
A non-text attachment was scrubbed...
Name: jdffeied.
Type: image/jpeg
Size: 12185 bytes
Desc: not available
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151015/5d02e743/attachment-0005.jpe> -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/jpeg
Size: 16990 bytes
Desc: not available
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151015/5d02e743/attachment-0006.jpe> -------------- next part --------------
A non-text attachment was scrubbed...
Name: eegjdhaj.
Type: image/jpeg
Size: 9219 bytes
Desc: not available
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151015/5d02e743/attachment-0007.jpe>

FreeMan wrote

Problem not just this damages. I can not add "Build ( Shift + F9)" in toolbar still. I wrote this, in last my mail.

Ok, I see that The "Build" button cannot be added. I can confirm the bug and will check why it happens.

I am sorry but I won't study the rest of your email. I don't have the time to solve image ciphers. Just write down a list of buttons that you have a problem with.

Ondrej
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151015/114685a3/attachment.html>

Thank you,
next time just write problem or screenshot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151015/fd150003/attachment.html>

FreeMan wrote

Thank you, next time just write problem or screenshot

I don't care what but it has to be simply understandable. E.g. in the last email you wrote down the old list and the new list. Instead you should have checked what buttons are missing in the new list and send only those (obviously it is much easier for you than for me because you KNOW what buttons you added and what did not appear. I have to check a lot of lines of XML code and will certainly miss something and lose a lot of time with it).

Ondrej

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151015/58caa7fa/attachment.html>

Patch attached (Juha?).

Mattias, I see you added a version info into the file. Good! Unfortunately I cannot use it for determining if the buttons are saved in IDEMenuCommand format (old) or the IDEButtonCommand format (new) because when loading the MenuCommands are not available yet. Therefore I changed the FindItemByMenuPathOrName procedure that updates the button name and writes it back. It doesn't use the version info, though.

Ondrej
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151015/24bdf3a7/attachment.html>
-------------- next part --------------
Index: components/ideintf/toolbarintf.pas
===================================================================
--- components/ideintf/toolbarintf.pas	(revision 50072)
+++ components/ideintf/toolbarintf.pas	(working copy)
@@ -88,8 +88,8 @@
       const aCommand: TIDECommand): TIDEButtonCommand; overload;
     function AddButton(const aCommand: TIDECommand): TIDEButtonCommand; overload;
     function FindCreateCategory(const aName, aDescription: string): TIDEToolButtonCategory;
-    function FindItemByName(aName: string): TIDEButtonCommand;
-    function FindItemByMenuPathOrName(aName: string): TIDEButtonCommand;
+    function FindItemByName(const aName: string): TIDEButtonCommand;
+    function FindItemByMenuPathOrName(var aName: string): TIDEButtonCommand;
     function FindItemByCommand(const aCommand: TIDECommand): TIDEButtonCommand;
     property Items[Index: Integer]: TIDEToolButtonCategory read GetItems; default;
   end;
@@ -396,26 +396,22 @@
   inherited Destroy;
 end;
-function TIDEToolButtonCategories.FindItemByMenuPathOrName(aName: string
+function TIDEToolButtonCategories.FindItemByMenuPathOrName(var aName: string
   ): TIDEButtonCommand;
 var
-  i: Integer;
   xMI: TIDEMenuItem;
 begin
-  i := LastDelimiter('/', aName);
-  if (i > 0) then
+  Result := FindItemByName(aName);
+  if Resultnil then Exit;
+
+  //find by path from aName (backwards compatibility)
+  xMI := IDEMenuRoots.FindByPath(aName, False);
+  if Assigned(xMI) and Assigned(xMI.Command) then
   begin
-    //find by path from aName (backwards compatibility)
-    xMI := IDEMenuRoots.FindByPath(aName, False);
-    if Assigned(xMI) and Assigned(xMI.Command) then
-    begin
-      Result := FindItemByCommand(xMI.Command);
-      if Assigned(Result) then
-        Exit;
-    end;
-    Delete(aName, 1, i);
+    Result := FindItemByCommand(xMI.Command);
+    if Assigned(Result) then
+      aName := xMI.Command.Name;
   end;
-  Result := FindItemByName(aName);
 end;
 function TIDEToolButtonCategories.FindCreateCategory(const aName,
@@ -448,7 +444,8 @@
   Result := nil;
 end;
-function TIDEToolButtonCategories.FindItemByName(aName: string): TIDEButtonCommand;
+function TIDEToolButtonCategories.FindItemByName(const aName: string
+  ): TIDEButtonCommand;
 var
   i: Integer;
 begin
Index: ide/toolbarconfig.pas
===================================================================
--- ide/toolbarconfig.pas	(revision 50072)
+++ ide/toolbarconfig.pas	(working copy)
@@ -625,12 +625,15 @@
 begin
   for I := 0 to SL.Count - 1 do
   begin
-    Value := SL.Strings[I];
+    Value := SL[I];
     if Value = '' then Continue;
     if Value = cIDEToolbarDivider then
       MI := nil
     else
+    begin
       MI := IDEToolButtonCategories.FindItemByMenuPathOrName(Value);
+      SL[I] := Value;
+    end;
     AddListItem(MI);
   end;
   FillToolBar;
@@ -765,6 +768,7 @@
       else
       begin
         mi := IDEToolButtonCategories.FindItemByMenuPathOrName(ButtonName);
+        Options.ButtonNames[i] := ButtonName;
         if Assigned(mi) then
           AddButton(mi);
       end;

Applied. Thanks.

Mattias

Thank you fixed.
1-) After "Configure Tookbar" Button has two dotted line there. Why? I'm not added.

2-) How to add spacer (dotted line) in "Toolbar configuration" --> "Toolbar commands" ?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151016/abba3981/attachment-0001.html> -------------- next part --------------
A non-text attachment was scrubbed...
Name: bcfhghdj.
Type: image/jpeg
Size: 5063 bytes
Desc: not available
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151016/abba3981/attachment-0001.jpe>

I cannot reproduce. Explain better.

2-) How to add spacer (dotted line) in "Toolbar configuration" --> "Toolbar commands" ?

The same as before. There is an "Add divider" button - unfortunately without an image.

Ondrej
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151016/5a687b91/attachment.html> -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/jpeg
Size: 5063 bytes
Desc: not available
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151016/5a687b91/attachment.jpe>

I get that screenshot, when start IDE. Open "options" from main IDE menu or click "Configure toolbar" button, click "ok" button then dotted line count is one. Close IDE, then start lazarus again two dotted line, like a that screenshot.
"<Button1 Name="Save"/>" this is first button in setting, I mean NO added devider.

I founded it, top on "Clear selection"

Ondrej

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151016/7c5eb85e/attachment.html> -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/jpeg
Size: 5063 bytes
Desc: not available
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151016/7c5eb85e/attachment.jpe>

Hmm interesting. I am seeing other problem: even the first "separator" (before the configure button) is deleted in my IDE. So your separators are not deleted for some reason.
This is an old issue. IIRC it happened already in EditorToolbar when it was not a part of the IDE but was in an external package.

Ondrej
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151016/9f514ad6/attachment.html> -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/jpeg
Size: 5063 bytes
Desc: not available
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151016/9f514ad6/attachment.jpe>

Thank you. Is need report new issue? or not.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151016/6b2c19ef/attachment.html> -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/jpeg
Size: 5063 bytes
Desc: not available
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151016/6b2c19ef/attachment.jpe>

FreeMan wrote

Thank you. Is need report new issue? or not.

The editor toolbar needs refactoring in this respect. The "options" tool button should not be there should be a popup menu with "Options" item as it is everywhere else. So no report is needed as I will refactor it in any case.

Ondrej
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151016/ab7e81fa/attachment.html>

Ok,
Thank you for your help Ondrej

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151016/6f8431ff/attachment.html>

FreeMan wrote

Ok, Thank you for your help Ondrej

http://bugs.freepascal.org/view.php?id=28865

Please test if you have double separators even with the patch.

Ondrej
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151016/c2466765/attachment.html>

Patch working well.
Thank you Ondrej

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151017/a021a047/attachment.html>