Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / lazarus / 2015-10

Request for review patch #27921

6 messages · 4 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

patspiper
to LacaK: I am not sure if this is proper maillist to write this kind of request. Can please…
LacaK wrote 5 lines
Hi, I am not sure if this is proper maillist to write this kind of request. Can please somebody review patch in bug report http://bugs.freepascal.org/view.php?id=27921 and if no objections commit them.

The patch doesn't work on my WinCE device. I would like Bart to test your patch as well to gather more data on this.

While at it, pls test the patch for
http://bugs.freepascal.org/view.php?id=21282 especially that the patch touches lcl code.

You can mail me directly if you like.

Stephano

Reply by email

LacaK
to patspiper

D?a 14.10.2015 o 22:56 patspiper nap?sal(a):

Show quoted text 9 lines
On 13/10/15 09:28, LacaK wrote: > Hi, > I am not sure if this is proper maillist to write this kind of request. > Can please somebody review patch in bug report > http://bugs.freepascal.org/view.php?id=27921 and if no objections > commit them. The patch doesn't work on my WinCE device. I would like Bart to test your patch as well to gather more data on this.

Hm, strange.
For me it works (I have tested it on WinCE 6 Motorola MC9190 device)

But you noticed, that Win32 widgetset has it implemented as my patch ? So it seems to me logical, that in WinCE it will be similar.

Thanks
-Laco.

Reply by email

patspiper
to LacaK
LacaK wrote 12 lines
D?a 14.10.2015 o 22:56 patspiper nap?sal(a): > On 13/10/15 09:28, LacaK wrote: >> Hi, >> I am not sure if this is proper maillist to write this kind of request. >> Can please somebody review patch in bug report >> http://bugs.freepascal.org/view.php?id=27921 and if no objections >> commit them. > > The patch doesn't work on my WinCE device. I would like Bart to test > your patch as well to gather more data on this. Hm, strange. For me it works (I have tested it on WinCE 6 Motorola MC9190 device)

Mine is Windows Mobile 6.5

But you noticed, that Win32 widgetset has it implemented as my patch ? So it seems to me logical, that in WinCE it will be similar.

In revision 18426, HandleUnicodeChar is the same for Win32 and WinCE. The divergence started with revision 18448 that had the same modification of your patch to resolve bug #0013044. Then came more changes in rev 26672 (bug #0015927) and 26729 (bug #0016950).

I asked Bart in the bug report to test your patch. If it works for him too then I'll commit it. If not then I could still commit it (based on bug report #18448). And in case there are side effects, we can always revert it.

On a separate note, pls test also the patch in
http://bugs.freepascal.org/view.php?id=21282).

Stephano

Reply by email

Bart
to patspiper: The patch doesn't work on my WinCE device. I would like Bart to test your patch as well…
patspiper wrote 6 lines
> Can please somebody review patch in bug report > http://bugs.freepascal.org/view.php?id=27921 and if no objections > commit them. The patch doesn't work on my WinCE device. I would like Bart to test your patch as well to gather more data on this.

I'll test as soon as I have some time.
Need to install the cross-compiler for 3.0.0rc1 (if tht exists) first.

Bart

Reply by email