Hi,

Mainly for Mattias, I suppose:

The SetString routine in the system unit has become a compiler procedure in 3.0:

{$ifdef FPC_HAS_CPSTRING}
Procedure fpc_setstring_ansistr_pansichar(out S : RawByteString; Buf : PAnsiChar; Len : SizeInt; cp: TSystemCodePage); rtlproc; compilerproc;
{$else}
Procedure SetString(out S : AnsiString; Buf : PAnsiChar; Len : SizeInt);
{$endif}
begin
   SetLength(S,Len);
{$ifdef FPC_HAS_CPSTRING}
   SetCodePage(S,cp,false);
{$endif}
   If (BufNil) then
     fpc_pchar_ansistr_intern_charmove(Buf,0,S,0,Len);
end;

This means the codetools are no longer able to find the SetString declaration.

Is there any way to fix this kind of things (i.e. find compiler procs) in the code tools ?

Michael.

Yes, see TIdentCompletionTool.GatherPredefinedIdentifiers() in IdentCompletionTool.pas

Add this line there:

     AddCompilerProcedure('SetString','out
S:RawByteString;Buf:PAnsiChar;Len:SizeInt;cp:TSystemCodePage');

Ondrej

Oh cool :-)
I didn't know this existed, I keep underestimating the Lazarus IDE ;) How to detect the compiler version ? Because it is only for 3.0+, I suppose.

Michael.

I think it is save to assume that Lazarus was compiled with the same FPC version that is also used for the sources in editor. Therefore you can use the same compiler directive:

{$ifdef FPC_HAS_CPSTRING}
    AddCompilerProcedure('SetString','out
S:RawByteString;Buf:PAnsiChar;Len:SizeInt;cp:TSystemCodePage');
{$endif}

Ondrej

This is definitely not so :-(
I compile lazarus with 2.6.4, but work with compiler set to 3.0 or even jvm.

That is how I bumped into the problem to begin with... :-)

Michael.

CodeTools know what compiler constants are defined in the target tool. You have to check if FPC_HAS_CPSTRING is defined. This should be possible but I don't know how to do it. You'll have to wait for Mattias' answer.

Ondrej

"Ondrej Pokorny" wrote

I think it is save to assume that Lazarus was compiled with the same FPC

version that is also used for the sources in editor. Therefore you can use the same compiler directive:

Not necessarily. As a compiler developer I often switch between versions depending on whether I want to use a non-released feature or a stable compiler...

Regards,
Sven
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20151010/2b9f421a/attachment.html>

if Scanner.Values.IsDefined('FPC_HAS_CPSTRING') then ...

Mattias

Great!

I added the procedure name to the list (see patch). It is shown without problems in the identifier completion window but it doesn't show any parameter hint help (ctrl+shift+space). I tried to register the procedure in "KeywordFuncLists.InternalInit" but it didn't help. Still no hint. What could be the problem?

Ondrej

Ondrej Pokorny wrote

I added the procedure name to the list (see patch).

Forgot the file...
-------------- next part --------------
Index: components/codetools/identcompletiontool.pas
===================================================================
--- components/codetools/identcompletiontool.pas	(revision 50030)
+++ components/codetools/identcompletiontool.pas	(working copy)
@@ -1353,6 +1353,8 @@
     AddCompilerFunction('Seg','var X','LongInt');
     AddCompilerProcedure('SetLength','var S:String;NewLength:Integer');
     AddCompilerProcedure('SetLength','var A:Array;NewLength:Integer');
+    if Scanner.Values.IsDefined('FPC_HAS_CPSTRING') then
+      AddCompilerProcedure('SetString','out S:RawByteString;Buf:PAnsiChar;Len:SizeInt');
     AddCompilerFunction('SizeOf','Identifier','Integer');
     AddCompilerFunction('Slice','var A:Array;Count:Integer','Array');
     AddCompilerProcedure('Str','const X[:Width[:Decimals]];var S:String');

On 11.10.2015 18:58, Ondrej Pokorny wrote: > I added the procedure name to the list (see patch). Forgot the file...

Thanks. Applied.

Mattias

KeywordFuncLists is for keywords.

The parameter hints are in codetools 'FindCodeContext'. I added it.

Mattias