Hi,

I just received notification that there is another pull request on Github if somebody wants to take a look.

https://github.com/graemeg/lazarus/pull/7

Regards,
- Graeme -

How to obtain a diff file from that?

Felipe Monteiro de Carvalho wrote

How to obtain a diff file from that?

Click on 'commits' then on the file link.

el es

Lukasz Sokol wrote

Click on 'commits' then on the file link.

This leads to: https://github.com/shenxh/lazarus/commit/633dc282555e9d12d945628d1c069bfcdba871d7

Which is *not* a valid input for tools like patch.

In this case it is small enough that I can merge manually, but for a big patch across multiple files it would be a huge problem.

thanks, I commited a modified version in 48424

Felipe Monteiro de Carvalho wrote

On Thu, Mar 19, 2015 at 11:26 AM, Lukasz Sokol wrote: > Click on 'commits' then on the file link. This leads to: https://github.com/shenxh/lazarus/commit/633dc282555e9d12d945628d1c069bfcdba871d7

You can then click the "View" button to see the complete new file which you can copy over your existing one. SVN will then show you the diff.

It doesn't seem that GitHub's web inteface allows downloading of patch files. Seeing a I use the git mirror, I quickly created a patch file for you - see attached. Hope that helps.

Regards,
- Graeme -

Felipe Monteiro de Carvalho wrote

thanks, I commited a modified version in 48424

Ah sorry, I was reading and replying in sequence. I didn't realise you already made the commit.

Regards,
- Graeme -

2015-03-19 10:44 GMT-03:00 Graeme Geldenhuys
:

https://github.com/shenxh/lazarus/commit/633dc282555e9d12d945628d1c069bfcdba871d7.patch

Luiz
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20150319/33c822b7/attachment.html>

If you prefer:
https://github.com/shenxh/lazarus/commit/633dc282555e9d12d945628d1c069bfcdba871d7.diff

Luiz

2015-03-19 10:51 GMT-03:00 luiz americo pereira camara :

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20150319/4a5389fc/attachment.html>

luiz americo pereira camara wrote

https://github.com/shenxh/lazarus/commit/633dc282555e9d12d945628d1c069bfcdba871d7.patch

Thanks Luiz, that is handy to know. So simply append ".patch" to the commit URL. Nice. I'll remember that for next time I get Lazarus pull requests.

Regards,
- Graeme -