Hi,

I've recently been using the Lazarus GUI Testrunner for work purposes and was amazed at how outdated the interface is [based on FPTest, DUnit2 or DUnitX's GUI TestRunners].

Improvements are easy to do at this point, but I have quite a few things that I want to add. The question is, how should I do this? Break the changes up into small patches and wait for each to be applied before the next. Or can I supply one patch that overhauls the GUI Testrunner completely?

Regards,
- Graeme -

I think it should be somewhere in between.
If the changes can logically be grouped then small paches are good, but they can be uploaded and committed at one go.
Small patches would make it easier later to analyse and find out potential problems.

Regards,
Juha

Juha Manninen wrote

If the changes can logically be grouped then small paches are good, but they can be uploaded and committed at one go.

OK thanks. I'll do that.

Regards,
- Graeme -

Juha Manninen wrote

If the changes can logically be grouped then small paches are good, but they can be uploaded and committed at one go.

I've made various changes so far, but need to split things up first because I got a bit carried away with improvements. ;-)

Of the changes I have a set of improvements that affects both FPCUnit (FPC 3.1.1 - could possibly be back ported to FPC fixes branch too) and LCL's GUI Test runner. What would be the best way to handle this?

Obviously I first need to share my FPCUnit changes on Mantis and see if it gets approved. I can then contribute the changes for the Text Test Runner (to FPC) and GUI Test Runner (to Lazarus). But how does Lazarus handle changes that might require FPC 3.1.1? Wrap it in IFDEF's?

Regards,
- Graeme -

[...] But how does Lazarus handle changes that might require FPC 3.1.1? Wrap it in IFDEF's?

Yes. Other ideas?

Mattias