Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / lazarus / 2015-02

ATT: received patches/pull requests on git mirror (github)

7 messages · 4 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Graeme Geldenhuys

Hi,

I received two pull requests for possible additions to Lazarus via my Git mirror on Github. I explained to the author that the mirror is just a downstream repository, but if somebody wants to review those, they are shown here:

https://github.com/graemeg/lazarus/pull/5
https://github.com/graemeg/lazarus/pull/6

Via the github website you can click on the "Files changed" tab, then click on "View" to download the whole (changed) file.

Regards,
- Graeme -

fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal http://fpgui.sourceforge.net/

Reply by email

zeljko
to Graeme Geldenhuys: I received two pull requests for possible additions to Lazarus via my Git mirror on…
Graeme Geldenhuys wrote 9 lines
Hi, I received two pull requests for possible additions to Lazarus via my Git mirror on Github. I explained to the author that the mirror is just a downstream repository, but if somebody wants to review those, they are shown here: https://github.com/graemeg/lazarus/pull/5 https://github.com/graemeg/lazarus/pull/6

Maybe Mattias should look into those requests. They're about LazUTF8 unit.

zeljko

Reply by email

Mattias Gaertner
to zeljko: Maybe Mattias should look into those requests. They're about LazUTF8 unit. zeljko
Show quoted text 12 lines
On 02/12/2015 03:23 PM, Graeme Geldenhuys wrote: > Hi, > > I received two pull requests for possible additions to Lazarus via my > Git mirror on Github. I explained to the author that the mirror is just > a downstream repository, but if somebody wants to review those, they are > shown here: > > https://github.com/graemeg/lazarus/pull/5 > https://github.com/graemeg/lazarus/pull/6 Maybe Mattias should look into those requests. They're about LazUTF8 unit.

No, they are about lazreport.

I only saw the diffs, so maybe I misunderstand the context, but they look wrong to me.
UTF8CharacterStrictLength returns 0 if invalid and 1..4 if ok.

Mattias

Reply by email

Juha Manninen
to zeljko: I like this idea. Maybe Juha can use it. zeljko
zeljko wrote 5 lines
> Here is another one, but this is from a while back. > > https://github.com/graemeg/lazarus/pull/4 I like this idea. Maybe Juha can use it.

Heh, it is already implemented. See :
http://bugs.freepascal.org/view.php?id=25903
His patch was not usable because it enabled multi-line selection and broke some existing features. Then he lost his interest and I implemented a simpler version of it.

It will all be in Lazarus 1.4. I hope we get RC1 soon.

Juha

Reply by email

Mattias Gaertner
to Graeme Geldenhuys: I received two pull requests for possible additions to Lazarus via my Git mirror on…
Show quoted text 12 lines
Hi, I received two pull requests for possible additions to Lazarus via my Git mirror on Github. I explained to the author that the mirror is just a downstream repository, but if somebody wants to review those, they are shown here: https://github.com/graemeg/lazarus/pull/5 https://github.com/graemeg/lazarus/pull/6 Via the github website you can click on the "Files changed" tab, then click on "View" to download the whole (changed) file.

It seems someone misunderstood UTF-8.
I deprecated the UTF-8 helper functions in lazreport because none is needed.

Mattias

Reply by email