fpc trunk r29110
lazarus trunk r46966
vista 32-bit

i just updated fpc trunk and lazarus trunk... fpc compiled ok... lazarus fails with

lresources.pp(3089,67) Error: Identifier not found "RT_RCDATA"

***************************************************************************
* TASK: build lazbuild, startlazarus and necessary tools...
* CMND: make OPT="-gl -gh -dHEAPTRC_WINDOW" lazbuild lcl basecomponents starter bigidecomponents lhelp
*
[...]
c:/freepascal/binutils/i386-win32/cp.exe -f Makefile.compiled units/i386-win32/CodeTools.compiled
make[1]: Leaving directory `c:/freepascal/laz/components/codetools' make -C lcl LCL_PLATFORM=nogui
make[1]: Entering directory `c:/freepascal/laz/lcl' c:/freepascal/binutils/i386-win32/rm.exe -f units/i386-win32/alllclunits.ppu c:/freepascal/binutils/i386-win32/gmkdir.exe -p units/i386-win32 c:/freepascal/fpc/trunk/bin/i386-win32/ppc386.exe -gl -Fu../packager/units/i386-win32 -Fu../components/lazutils/lib/i386-win32 -Fu. -Fuforms -Fuwidgetset -Fiinclude -FE. -FUunits/i386-win32 -gl -gh -dHEAPTRC_WINDOW -di386 alllclunits.pp
Free Pascal Compiler version 2.7.1 [2014/11/22] for i386 Copyright (c) 1993-2014 by Florian Klaempfl and others Target OS: Win32 for i386
Compiling alllclunits.pp
Compiling checklst.pas
Compiling lclproc.pas
Compiling lclstrconsts.pas
Writing Resource String Table file: lclstrconsts.rsj Compiling lcltype.pp
Compiling .\widgetset\wsreferences.pp
Compiling graphtype.pp
Compiling graphics.pp
Compiling lclversion.pas
Compiling intfgraphics.pas
Compiling icnstypes.pas
Compiling graphics.pp
Compiling lmessages.pp
Compiling lresources.pp
Compiling dynqueue.pas
lresources.pp(3089,67) Error: Identifier not found "RT_RCDATA" lresources.pp(5781) Fatal: There were 1 errors compiling module, stopping Fatal: Compilation aborted
make[1]: *** [alllclunits.ppu] Error 1
make[1]: Leaving directory `c:/freepascal/laz/lcl' make: *** [lazbuild] Error 2

Add the windows-unit to the uses section of lresources as a quick fix.

Joost.

Joost van der Sluis wrote

Add the windows-unit to the uses section of lresources as a quick fix.

And what to do on non-windows systems?

Maybe better copy the RT_RCDATA definition and ifdef it for 2.7.1?

As a side note:
FPResource := FindResource(HInstance, PChar(ResName), PChar(RT_RCDATA));

The cast to PChar seems a little redundant given the definition of RT_RCDATA?

Bart

On 11/22/14, Joost van der Sluis wrote: > Add the windows-unit to the uses section of lresources as a quick fix.

Done.

And what to do on non-windows systems?

That compiles unchanged.

Mattias

i hesitate to do that for several reasons... but i'm also interested in what changed elsewhere to break this... the lresources.pp file that i have is dated 2014 Mar 17 10:02... i've looked through the svn log of the last few days since my last update and haven't found anything obvious but i've also not dug in very deeply...

thanks for your reply!

Would it he better if for consistency we export the RT_* constants from System as well on Windows platforms?

Regards,
Sven
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20141123/efc9e1c7/attachment.html>

i pulled your update last evening and compiled... it seems to have worked...

With 'quick-fix' I meant that you could do this change locally to avoid the problem. Not that it should be committed as a definitive fix.

I think it's a bug in fpc. Sven?

Regards,

Joost.

the problem. Not that it should be committed as a definitive fix.

I think it's a bug in fpc. Sven?

I already fixed it yesterday evening. I readded RT_RCDATA for Win32 and Win64 (WinCE didn't have it there and other platforms have it in System). But I added it with a deprecated message, because the correct solution is to use the one in the Windows unit (or maybe it would be better if we'd enable the RT_* constants in System for Windows as well).

Regards,
Sven
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20141124/28d0053a/attachment.html>