Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / lazarus / 2014-09

Why lazchmhelp.pas sets InheritHandle conditionally on fpc version?

3 messages · 2 people ·

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Luca Olivetti

I saw in the 1.2.4 source this:

{$if FPC_FULLVERSION<20604}
Proc.InheritHandles := false;
{$endif}

Why is it conditional?
Maybe I'm biased by my bad experience with it being true by default, but I think it should be always set to false (apart from the fact that it didn't work in fpc, and it has been fixed exactly in 2.6.4, making the above completely useless).

BTW, in my local copy I also modify lazhelphtml.pas

--- lcl/lazhelphtml.pas (revisi?n: 45586)
+++ lcl/lazhelphtml.pas (copia de trabajo)
@@ -367,6 +367,7 @@
   try
     BrowserProcess:=TProcessUTF8.Create(nil);
     try
+      BrowserProcess.InheritHandles:=false;
       BrowserProcess.CommandLine:=CommandLine;
       BrowserProcess.Execute;
     finally

Bye

Luca Olivetti Wetron Automation Technology http://www.wetron.es Tel. +34 935883004 Fax +34 935883007

Reply by email

Mattias Gaertner
to Luca Olivetti
Show quoted text 8 lines
I saw in the 1.2.4 source this: {$if FPC_FULLVERSION<20604} Proc.InheritHandles := false; {$endif} Why is it conditional?

It is not conditional in 1.3.

Show quoted text 18 lines
Maybe I'm biased by my bad experience with it being true by default, but I think it should be always set to false (apart from the fact that it didn't work in fpc, and it has been fixed exactly in 2.6.4, making the above completely useless). BTW, in my local copy I also modify lazhelphtml.pas --- lcl/lazhelphtml.pas (revisi?n: 45586) +++ lcl/lazhelphtml.pas (copia de trabajo) @@ -367,6 +367,7 @@ try BrowserProcess:=TProcessUTF8.Create(nil); try + BrowserProcess.InheritHandles:=false; BrowserProcess.CommandLine:=CommandLine; BrowserProcess.Execute; finally

1.3 has the above code.

Mattias

Reply by email

Luca Olivetti
to Mattias Gaertner

El 02/09/14 11:19, Mattias Gaertner ha escrit:

Show quoted text 13 lines
On Tue, 02 Sep 2014 09:54:50 +0200 Luca Olivetti wrote: > I saw in the 1.2.4 source this: > > {$if FPC_FULLVERSION<20604} > Proc.InheritHandles := false; > {$endif} > > > Why is it conditional? It is not conditional in 1.3.

[...]

1.3 has the above code.

I should have checked trunk.

Thank you

Luca Olivetti Wetron Automation Technology http://www.wetron.es Tel. +34 935883004 Fax +34 935883007

Reply by email