I have posted in the bugtracker (
http://bugs.freepascal.org/view.php?id=26495 ) a patch to the editortoolbar package.

I summarize the new features:

1. The configuration allows positioning at the four sides of the editor window
2. The configuration includes a Show/Hide checkbox
3. Jump Back/Jump Forward are provided as initial defaults
4. It registers a new entry in Main Menu/View to access configuration also when the toolbar is hidden

Implementation notes.

With this implementation Lazarus/Ide code is left untouched, unless one wants a different Menu Icon, which should then be added to Lazarus resources. I had prepared one, but the one currently used appears to be unused elsewhere, and looks appropriate to me.

If the package is included into the default Lazarus packages list, the feature will be available by default.

If the user chooses to hide the toolbar, a Box is shown when exiting configuration, telling where to find in the main menu the entry to access configuration. It's intended to avoid a number of "How can I restore the toolbar I have hidden by mistake?".

The Jump Back/Forward entries are added when there are no user defined buttons. Meaning that they'll be added not only at startup, but also if the user deletes all user buttons. I don't believe it to be an issue, because an empty toolbar doesn't make much sense. But, if such is the case, the available workaround is to leave in just a divider. If Graeme provides a better implementation, he's welcome.

That's all folks!

Giuliano

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20140718/d38f9256/attachment.html>

Giuliano Colla wrote

It registers a new entry in Main Menu/View to access configuration also when the toolbar is hidden

An idea: the menu item could be checked and affect the visibility directly. I moved the 'Component Palette' and 'IDE Speed Buttons' check-items lower in View menu.
Now EditorToolbar item comes after them and having it checked would be intuitive.
Then the config dialog would not need visibility setting and no warning was needed.

EditorToolbar still has issues not related to this patch:

A user can add the same item many times from available items to selected items. This is a bug and should be fixed. The arror should be disabled if the item already is there. The tree item could also be drawn disabled but this is not crucial.

There is no splitter between the available and selected panes. It is a common convention to have one with such a GUI.

Not related to EditorToolbar, but the Jump Back/Forward icons don't look good. They have binoculars which hints for some kind of search window but there is none. A logical icon would be an arrow but it should be different from other arrow icons around the IDE.

Juha

18-07-2014 13:24 tarihinde, Giuliano Colla yazd??:

I have posted in the bugtracker ( http://bugs.freepascal.org/view.php?id=26495 ) a patch to the editortoolbar package.

For left and right position, need a few increase with, hard to click, "Jump to" button's dropdown icon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20140719/54f70fe8/attachment.html> -------------- next part --------------
?PNG

IHDRhM??j0
liCCPiccx????Ka??0???????!????A1?????N?;=?N"Z\*Z????-?? ?&?? "???%j?{????????x?`^W{d0j?U??????? ?D??\?????>??}????HY? 0F^PL?!/?s;??q?<?T?2????xA????>?x\???c?XX?Y??<?J?2? r??J?>?K????>?6 ?
2??I?3?????r????obT?MPmpW?]???????e?3S[?O?'+???????c?{??_???m?'??5??[???zs??O??>py=??s??OuL??zR?#?i??0Qb?z|??????#P?????0????o?ahMg??? pHYsaa
???izTXtauthorx?K+JM?M?36?G?z??bIDATx??] tT???L&??? ?YB "IXeM??P at m??Pm?*ZO{??vPj?V??PA ;sg&?d?$t?srs??????~??IN?8z?????????jZ?r?????28(?Aii??C?`o??n?Z??????f?X?5??Kh??#??B|?p?""?!???\? ???aM&????8???rr???>..????+WjjL?!A ?BB??r???5??D??;?A??? ?,Oj?p???8????$Nf4Fck?V??B?P? Z?(??I$??? wP]]j??s?I? ???J???v????U"?????A??F????lp?)?JK ?D?%?!?G:??????
?p??b
??G?r??f???V?$<\???$??(t?F#???A???i?]?b??N?.-=y2&?o???:9y?? ?????/Y?i??????s8????76??????v?Ry??????V??d??cB??n2?????Lr?Db?u?.pTV??Q||\\||D?R?P?%&??????92?????-PC?? ????????l
?J????????????????N?P?????V?9??????????? ?R)???A?>3?????H?%?U?R?U? ??+p???tN?H?K?e?jm?????\???r?B???^? .?fS*??H?T??V, ^???X??W#<?&????????
?????????????N????H??)Z??????s?Vy???}?~?????????n?????? 6n\?x!GR?2O<1??A2??%????v?K??CB?{n????`??z???(???? ?()0Zj?????K
???v?}?????I$]?dG7?8?#&H?_v??V??`v!?D???/?j?$????D?yjq?V?????l+(?Q??????=??b???.]????????Ec???`?? ??,?.???k????????p~?wt???~z??5k?"??/GO>????p?bER??=??e??/?j???l6 @ ??1H~?? ???~"^8f???J??*?>??c?????R?^~???\?G?W?Z???z=???pM????7?|????h??_?h?????o?_?L?#:CB??w????v????w????????_??G;w????????#9R?_y???^??Gy?W??9G??I??????g????[?DTYYX?w?J??p?v;i???b?V???? |???aq5?5?=m6?Y?????{???DZ??X???E?s?j=????g?y??????8z???+?????F ??u?;w????oJCG ??5?'d2j??????9s&LHJ????[?MM??Vk]]y????????A+V??a4??BxN,?F??f??h??=M?>m????^?Y??????????_l?Xhh????t???3??kn>|????~????|??Q??????J???^???v?>u??-%e????????4?\?g?????I&C,?V???`??dj??1#?]?L!!??????G?Z?????s?'???]\??R_?????????w??y???Vkj???/L??F???????22F?=?i???????=s?B? ?'?+???"p????P(?$??l???G?t??o??{??u??''/_?m[hhBBV?`?P5?f( B?_?w???m???&???+)?s?V????q?Dq??cmm??%TW.???VU?t?+0???????!?f??"? F`trjj?~???7X??5??2?}???={???!????:?QQtt?>?????z?.????nD0??????(?????????????A?x??ZZ JMU*?????F??[?u?;??????|)B?-?-?C??Ku.??|?MV??d?L?e0???3?a?ct??? FhhhKK[?T???e0X?R?F????8?*<?_??????0 at O*
?&z'f'tp???t?? :?'????0???J??( ? Sf?????py}?$?????HG?????l??=?t?K???*U????_??UxxddX???????c"Q#?
?RB?? ???'"?]?Z?? (?W?/???R??%??B????
????U????? ?d?;]3?zt<r???N??
3?=????????.?????N??u????y??-[?[z???pb??[????????????\?""P??????????_L???_??-??5j?3??/>??_? S(BC?fOAJ??u?/??S??p6'_?o??d??P?w2?&4??w[\???iHr??l8?>?rH???k?n??&o???????"#e2wu??"??/??^??-(()??7r?|mm[[] ,?g???N???????
FGt ??Y,?r
??tXT??n???L6[yyMMk???EE.??b??????????ze?F??5???e8r!R:???J???6?Nh6.?r?????A??>??2dHBBx8?$|??w?9r???-?? {|?#??O at liAu9??(????sr???????KK??o?!,????f???i??l?6??\?v?m?Z?F?1s?~Y?Qfye??e????p8O????3?c???<@? ??g?v???C {??Q??<?x?^?,0x??&ONOg??H????pF?:??Y???]????-??f5\ ?`{???YP?+????N??????Ko???1?:nI1????????>`???_|?q#??$)?N\M? 44?????eeRit4j

?????FpE??V?r???(????????ee???2
???
d?f?v????V?
???Kx?<??n???z?E?bXD?8??}4/o??={?n???1?J?Z???v6`H$re??p2?J?8??f?U????SPEs:?1??H`??:u???VH???<y?????P_???x1????dg??$??6n??923????-??)??OO_?l??N~?e??l8?;X???Y?????g?cq9xE+*????"tS.???2???{?B?????r]%????b:I9??????R=?#?-#F????g6[ccSSQ???+V?u??]??f??*2?????'?x?q??8?F;c???`???????`??L:e??T ?1???nB? ???d>?%K?5????h????L?b4B??re?^8??9?kZ???7<t??u?6&G??0????6>?^??lt? ??`.?K?
S???`?=????????~??'??n???o??^?????q???Y????Z[?9?:,Sv?7????"???? ??????$??Z?9? ?bbf?????????I?????M???k????v/G??????v???????Q'???r?O"P-_~????d? #??_?? r??j????%%??L?`C?o??E??f? ?U??GC??y??y??<)i??M??G%'?r?0?.=}????y????{ ?HQ']U??????\ C??R[[_????cN?X??5*>~???/CB|?w?{????o?}?]Kp??C=??3????{??Y?z??g? ??Y>Y{S??see11?2???\^?V??$?"l????KJN???1b??^???|&?????w???GF??? ??}(???7
?}???z?aD?(??{BC??JJ?oh??PZ?????R)L$c????/??

????u??HB???????W???]u????'2?9r???m????
8?1Tz\l?Z???t]>?Q(?=???O??????f??U??????}???h?y???w?"?#M?0???UWWU :bDzz?>}9B?;=z?HG?]??4?egO?8iRz??Q?????>|????w???B????u??6???~??yy??D????uU????2??T?q?G
N???k}??TR)yE??RR???m?????^b2\Y???????x?????0??a?????tuw????o\\G6???o??u???CSSo?y??[o????/>?Pkn???????~??Y??o???????%$$'??|??????FN??}?????<?????????c????;?)++'g????7mZ?? S???;o??????Ew??n?p7?8p`DDa???g???]?b2?[?iEd ?<.&???? y?uu?
??8??h?K?????4?`?g<??>??XW?;a?????n7n????gA???9???]???z??;????8?\i?????#????e?f?O?c~???=??3g?????p=??
pyyc?DF? ????`!L????_??????????*L?CA=???= |??t.?
??,????j9"]G?]??p?i4--??"?????m?%???????(??Y??)?<b???p??xnJB???o??I.?P??j?????dd??????qE??|=?u???F?%s|?>?/???????????#
:"\p??)S?N??8??9?????.]?x? (=F??3??3??u??z?[O`KN2d?P???g????D????
???Q?o?H?J%h9q????r??????=l?ji?h?BD:`n??IS??Tx?&]??A?UT???{??i??>o??)s???K???+UU??? K{_???4rdn???3g?y????:??9r????;:???/.>p`?~??,X???????'??Cz?nS?q??h?8???????d???o????????Z?rc??[?~??? ??o?????W???????bf?[???m???~?Q?????S<?????wA
-;>?v??Yb?????E?'2?~ ????g:?z?:4==+?~????n??u??_"??hLNFo????)qK???) ??{?????W?r?????u???}?u?
??J???$??????????????%l?v??d?S????kj??.\???Z[Z?\?i?&%EGK$??]????:???9d#8?T????????{q?#?X??#(?;+k??
????CC8u??f???????????????hd?H?????????#???w????G6{??8???3?*??3KH???2?p??7WA?Z???{x?y'?????z??C????\^??T??????P?K?$Q?????dJN???H????Wb?W> ?~?5e?w?;sj?H??R^*?q ?j??s???,?y?g4.e?9???K???,iNh????????????"??????WU???)I???????????9?a??~?:>?R|0??:< r?8k[?Z|f3{??GB????W1?V"-Y? ??H?8?<???????????p?c?lk????_????"22-m???f?%?J???????n??DIj?J$(a2M???*?&'?:???**.r4~?? 7?\SS]]Y)????%'c?Bq ?^#?;???b???ya?2w<?????????|????8????D?+?w.#?Al?N
???(???H?X??9U?7.'???L6,,?????????????)???:t?????O???1"%??D???1q??+???s6+??T9???7s8??R)?????<?????????U????X???n??v?A???I???#???,???k?c??r9???h?????4p:??L??????p??V;kVN???tW?????H???(????{A?Wd????z,???Vh?4az????XEe?1??o????c?? 8Os&??j?9??UUqq?9?? Du UX5g>??=&e???rrci??A"%8????K?b?9~NC??A_ e???Q?? ?'????v=??
??^??????$o??J??????7-u??r$?G???????!L11QX}B*"?o?o?V!?????f?:u?jE??J?N???g???????t$?9G 3?p?i???.?g%p?????4eIW???>?Kh??s?????
2?????TX?2??d?%a?'_??Ez?j????j????????&$????F???D?3S?s>??^%??H:?????? R?c???S???9+ql2^u???:A?Q2?< ??w?G{?VSbP?.q?S]?&?r????????CgZ???oZ[a?$????9???????LC????Q?C?[om?|?Rcck??(?????w???XgSB?1?p??F?*qB ??N?q?+???K8??L??c??[{x?U?a?f-H???????????.R??R???O?{????b??*?bSYy???G?Z+??P????"b!?????p??
p?}??o&p?????L??Z??
?F`??x!g}???n???????[?j?))??RiB?Fc0L?>jTn.?XxDp|s??????m??H?dV%_8?????c|?7???????/B?:??\?o???.???D?$Z?Z?xrae2?#?+s???X???qc~??S_}UX??s???a??i?~?9????t????Y?ok??%?-|??s????<?<'.j?? ???s????????T??2???:c,???9??n???JwF???iO??(H(?1-????O?:????u?<
??
P?I?q?O?=c`?X~RY?!~?????b\?zW?<??yO?K??q!?6`^Cj? 8?]\i???g??? .?v??`??+..?#???6?'?y??t???m?jW
????Sd[??DGDu??\???t<=???X?EihOp?U??????????????%?H??)???"?_?h_???G??R? ??4?j'g???????.u?i???` ???
?N:?#???IEND?B`?

Il 19/07/2014 12:50, Juha Manninen ha scritto:

I had the same idea, but I stumbled into a difficulty: I don't know how to implement it! :-(
I tried to look for how it's made in other entries, but I got lost. A hint?
[...]

I'll look in both those issues.

Not related to EditorToolbar, but the Jump Back/Forward icons don't look good. They have binoculars which hints for some kind of search window but there is none. A logical icon would be an arrow but it should be different from other arrow icons around the IDE.

I'll dig into GPL available icons to see if I can find something better. No use to reinvent the wheel.

Giuliano

Il 19/07/2014 14:30, FreeMan ha scritto:

You're right, but this isn't a issue of the editortoolbar package: it's a general issue of the TToolbar component, which rearranges and resizes the buttons depending on orientation. Widening the Toolbar doesn't help, one just gets blank space on the right, after the control. I believe that the horizontal orientation has been ironed up much better than the vertical one.

Giuliano

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20140720/dfe85fb6/attachment.html> -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/png
Size: 7757 bytes
Desc: not available
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20140720/dfe85fb6/attachment.png>