Hi, Lazarus developers,

following the discussion of a few days ago about editortoolbar package, I'm preparing an enhancement patch.
What I've done:

1) Added an option in Editortoolbar configuration, to select its position (Top,Bottom,Right,Left)

2) Added a "Show toolbar" checkbox in Editor -> General -> Misc, and an eoEditorToolBar to TSynEditorOption2.

What is missing:

1) A better implementation of the Show Toolbar option. Currently Editortoolbar uses SourceEditorManagerIntf, which doesn't expose (or if it does I didn't find how) the current editor options. My quick and dirty solution has been just to read the editor configuration file. As a consequence, a change is only taken in charge when restarting the IDE, or when starting a new project.
Any suggestions?

2) Including Editortoolbar among the default IDE packages. I've never done such a thing, and I don't know how to do it in a clean way. Moreover it has to be seen if:

a) It is desirable to do it. Given that it can be switched off I would be in favor.

b) It is desirable to keep it as a separate package from the SynEdit suite, or it should become the umptieth SynSomething.

Again: suggestions?

Giuliano

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20140715/9e956c8e/attachment.html>

Giuliano Colla wrote

1) Added an option in Editortoolbar configuration, to select its position (Top,Bottom,Right,Left)

Good.

2) Added a "Show toolbar" checkbox in Editor -> General -> Misc, and an eoEditorToolBar to TSynEditorOption2.

How do you do that from the package code? Or, did you modify the IDE's code?

IdeOptionsIntf has the interface for options.
Maybe you should keep the option checkbox somewhere else. It makes sense in the Editor -> General -> Misc only if the package is installed all the time.

It is possible. Especially new users keep requesting such a feature. For them it should be installed by default.
One addition please: add the "jump backward" and "jump forward" (Ctrl-H, Ctrl-Shift-H) buttons there by default. They are the single most requested operations. Once people learn to use shortcuts, they are not as important any more.

b) It is desirable to keep it as a separate package from the SynEdit suite, or it should become the umptieth SynSomething.

Now you are on wrong tracks. EditorToolbar is a misleading name. It is more like IdeToolbarLocatedInEditor. It supports all commands, including for Designer and Package editor.

Juha

Il 15/07/2014 20:16, Juha Manninen ha scritto:

I modified IDE code (editoroptions.pp and
editor_general-miscoptions.pas, assuming that the toolbar would be provided as a default.

I'll look into it. Thanks for the hint.

As we already steel some pixels from the editor window, I was thinking to provide as a starting default a number of usual edit functions (Undo/redo - Cut/Copy/Paste - Search/Search in Files - Jump Back/Jump Forward). Then users may add/remove what they need.

You're right. This should help to find a better position for the show/hide option, and a better location for the package. I'll give a look into it.

Juha Manninen wrote

One addition please: add the "jump backward" and "jump forward" (Ctrl-H, Ctrl-Shift-H) buttons there by default. They are the single most requested operations. Once people learn to use shortcuts, they are not as important any more.

Very good idea. If Giuliano doesn't know how to do that, I'll submit a patch with (or after) his, adding that change.

Regards,
- Graeme -

Giuliano Colla wrote

I was thinking to provide as a starting default a number of usual edit functions (Undo/redo - Cut/Copy/Paste - Search/Search in Files - Jump Back/Jump

I wouldn't. I think everybody knows those shortcuts as they are common in all editors.

The "Jump To" is a editor toolbar feature hence it was on there by default. The "Jump Back/Forward" has a Lazarus IDE specific shortcut most don't know (in the beginning). So these two can be justified as default items.

The Cut/Copy/Paste etc just takes up toolbar space, and means others will have to go through the trouble to delete them if not needed. I know I will. ;-)

Regards,
- Graeme -

Yes, It's only space consumer... Copy/Cut/Paste are known even by my father. (LOL). I don't think that buttons are needed...

V?clav Val??ek

Dne 15.7.2014 20:48, Graeme Geldenhuys napsal(a):

Il 15/07/2014 20:43, Graeme Geldenhuys ha scritto:

Please go ahead with your patch. You're more familiar with your code than I am, and your implementation will certainly be better than mine. If you let me have it as soon as it's ready I can incorporate it in my work in progress without waiting for the svn update process.

Giuliano