Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / lazarus / 2014-05

Attn Mattias: is r45063 correct? Fixed building lhelp under FPC 2.6.4

2 messages · 2 people ·

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Reinier Olislagers

Saw this
r45063
lhelp: fixed building lhelp under fpc 2.6.4

---
branches/fixes_1_2/components/chmhelp/packages/idehelp/lazchmhelp.pas 2014/05/17 18:55:25 45062
+++
branches/fixes_1_2/components/chmhelp/packages/idehelp/lazchmhelp.pas 2014/05/17 18:57:08 45063
@@ -283,6 +283,9 @@

   //  Exit;
   Proc := TProcessUTF8.Create(nil);
+  {$if FPC_FULLVERSION<20400}
+  Proc.InheritHandles := false;
+  {$endif}
   {$if (fpc_version=2) and (fpc_release<5)}
   Proc.CommandLine := Lazbuild+' '+WS+' '+PCP+' '+LHelpProject;
   {$else}

However, that tests for FPC up to and including FPC 2.3, not 2.6.4 and up Either:
1. the description of the fix is wrong
2. the fix is wrong
3. I haven't had enough coffee or there's something else wrong with me...

Thanks,
Reinier

Reply by email

Mattias Gaertner
to Reinier Olislagers
Show quoted text 26 lines
Saw this r45063 lhelp: fixed building lhelp under fpc 2.6.4 --- branches/fixes_1_2/components/chmhelp/packages/idehelp/lazchmhelp.pas 2014/05/17 18:55:25 45062 +++ branches/fixes_1_2/components/chmhelp/packages/idehelp/lazchmhelp.pas 2014/05/17 18:57:08 45063 @@ -283,6 +283,9 @@ // Exit; Proc := TProcessUTF8.Create(nil); + {$if FPC_FULLVERSION<20400} + Proc.InheritHandles := false; + {$endif} {$if (fpc_version=2) and (fpc_release<5)} Proc.CommandLine := Lazbuild+' '+WS+' '+PCP+' '+LHelpProject; {$else} However, that tests for FPC up to and including FPC 2.3, not 2.6.4 and up Either: 1. the description of the fix is wrong 2. the fix is wrong 3. I haven't had enough coffee or there's something else wrong with me...

You are right. It should be 20604. Fixed.

Mattias

Reply by email