Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / lazarus / 2013-05

[WINCE] Please stop generate debug file.

7 messages · 4 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Zaher Dirkey

Hi, Would you please stop generate a debug file for wince

lclproc.pas line 1695

procedure DebugLn(const s: string);
begin
  {$ifdef WinCE}
  if DebugNestAtBOL and (s  '') then
    DbgAppendToFile(ExtractFilePath(ParamStr(0)) + Str_LCL_Debug_File,
DebugNestPrefix+s)
  else
    DbgAppendToFile(ExtractFilePath(ParamStr(0)) + Str_LCL_Debug_File, s);
  {$else}
  // First of all verify if a widgetset has override DebugLn
  if DebugLnProc  nil then
  begin
    DebugLnProc(s);
    Exit;
  end;
I am using last revision of Lazarus, FPC 2.6 on Windows XP SP3 Best Regards Zaher Dirkey -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20130524/4e24f4d1/attachment.html>

Reply by email

Martin
to Zaher Dirkey

Is this about "debugln" does not log correctly, or about something gets logged, that you did not want to be logged?

I think the question is what is calling debugln.
- If your code does, then it should log.
- If it is in the IDE (but you wouldn't run that on wince) then that is correct to.
- If something else calls debugln, then that probably needs to be stopped.

Zaher Dirkey wrote 32 lines
Hi, Would you please stop generate a debug file for wince lclproc.pas line 1695 procedure DebugLn(const s: string); begin {$ifdef WinCE} if DebugNestAtBOL and (s '') then DbgAppendToFile(ExtractFilePath(ParamStr(0)) + Str_LCL_Debug_File, DebugNestPrefix+s) else DbgAppendToFile(ExtractFilePath(ParamStr(0)) + Str_LCL_Debug_File, s); {$else} // First of all verify if a widgetset has override DebugLn if DebugLnProc nil then begin DebugLnProc(s); Exit; end; -- I am using last revision of Lazarus, FPC 2.6 on Windows XP SP3 Best Regards Zaher Dirkey -- _______________________________________________ Lazarus mailing list http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20130524/fb10ee89/attachment.html>

Reply by email

Zaher Dirkey
to Martin
Martin wrote 6 lines
I think the question is what is calling debugln. - If your code does, then it should log. - If it is in the IDE (but you wouldn't run that on wince) then that is correct to. - If something else calls debugln, then that probably needs to be stopped.

?I am not use it at all, LCL in WINCE send ?this debug lines, it is even in release version of my exe, i think Filipe will understand me.

Best Regards
Zaher Dirkey
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20130524/a523c196/attachment.html>

Reply by email

Martin
to Zaher Dirkey
Zaher Dirkey wrote 15 lines
On Fri, May 24, 2013 at 9:17 PM, Martin < <mailto:>> wrote: I think the question is what is calling debugln. - If your code does, then it should log. - If it is in the IDE (but you wouldn't run that on wince) then that is correct to. - If something else calls debugln, then that probably needs to be stopped. I am not use it at all, LCL in WINCE send this debug lines, it is even in release version of my exe, i think Filipe will understand me.

Ok, so this a messages somewhere in the LCL or in the wince code of the LCL.

I only ask because you pointed to the code of the logger. But that code is not responsible. Any call to it, in the LCL, should be ifdefed.

Or it should go via LazLoggerBase or LazLoggerDummy, instead of LCLProc. -------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20130524/3ae8b64b/attachment.html>

Reply by email

Paul van Helden
to Martin

I get these in my lcldebug.log on Wince:

TWinControl.DoDockClientMsg DockPanel:TPanel
Control=MobileWelcomeForm:TMobileWelcomeForm
DestRect=l=579,t=102,r=819,b=550
TWinControl.DoDockClientMsg DockPanel:TPanel
Control=OpenMapForm:TOpenMapForm DestRect=l=823,t=420,r=1063,b=720 TWinControl.DoUnDockClientMsg DockPanel:TPanel
Client=MobileWelcomeForm:TMobileWelcomeForm Client.Parent=DockPanel:TPanel TWinControl.DoRemoveDockClient DockPanel:TPanel
MobileWelcomeForm:TMobileWelcomeForm
TWinControl.DoUnDockClientMsg DockPanel:TPanel
Client=OpenMapForm:TOpenMapForm Client.Parent=DockPanel:TPanel TWinControl.DoRemoveDockClient DockPanel:TPanel OpenMapForm:TOpenMapForm

I thought perhaps I'm the only one docking windows on Wince!

Martin wrote 31 lines
On 24/05/2013 19:42, Zaher Dirkey wrote: On Fri, May 24, 2013 at 9:17 PM, Martin wrote: > I think the question is what is calling debugln. > - If your code does, then it should log. > - If it is in the IDE (but you wouldn't run that on wince) then that is > correct to. > - If something else calls debugln, then that probably needs to be stopped. > I am not use it at all, LCL in WINCE send this debug lines, it is even in release version of my exe, i think Filipe will understand me. Ok, so this a messages somewhere in the LCL or in the wince code of the LCL. I only ask because you pointed to the code of the logger. But that code is not responsible. Any call to it, in the LCL, should be ifdefed. Or it should go via LazLoggerBase or LazLoggerDummy, instead of LCLProc. -- _______________________________________________ Lazarus mailing list http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20130525/036e98e4/attachment.html>

Reply by email

Felipe Monteiro de Carvalho
to Paul van Helden

Yes, the code needs to be rewritten. It was written before a system was created to allow widgetsets to override debugln. It also needs a variable in the widgetset class to allow the user to choose if he wants the log or not.

Felipe Monteiro de Carvalho

Reply by email

Martin
to Felipe Monteiro de Carvalho
Felipe Monteiro de Carvalho wrote 5 lines
Yes, the code needs to be rewritten. It was written before a system was created to allow widgetsets to override debugln. It also needs a variable in the widgetset class to allow the user to choose if he wants the log or not.

but the code in lclproc.pas is no longer used.

LazLogger is unesd instead. LCLProc just forwards to LazLogger

And it has a widgetset-hook
And it can be disabled in app or at compile time

Show quoted text 12 lines
TWinControl.DoDockClientMsg DockPanel:TPanel Control=MobileWelcomeForm:TMobileWelcomeForm DestRect=l=579,t=102,r=819,b=550 TWinControl.DoDockClientMsg DockPanel:TPanel Control=OpenMapForm:TOpenMapForm DestRect=l=823,t=420,r=1063,b=720 TWinControl.DoUnDockClientMsg DockPanel:TPanel Client=MobileWelcomeForm:TMobileWelcomeForm Client.Parent=DockPanel:TPanel TWinControl.DoRemoveDockClient DockPanel:TPanel MobileWelcomeForm:TMobileWelcomeForm TWinControl.DoUnDockClientMsg DockPanel:TPanel Client=OpenMapForm:TOpenMapForm Client.Parent=DockPanel:TPanel TWinControl.DoRemoveDockClient DockPanel:TPanel OpenMapForm:TOpenMapForm
I checked some of them, in trunk they are IFDEFed. So they should not occur
      {$IFDEF VerboseDocking}

If they are not ifdefed in fixes, then someone needs to do an svn blame, find the revision, and if nothing else changed in that revision then it can be merged. If otherstuff changed, a patch for fixes branch can be accepted.

Reply by email