Hi,

I'm probably missing something here..

I have a ShellTreeView which is coupled with a ShellListView. At designtime I set ShelltreeView.Root to 'C:\' (I'm on Windows).

I build and run.
When the program starts the ShellTreeView has nothing selected and ShellListView is populated with all files in C:\

Now I select any node in ShellTreeView and ShellListView responds as expected.

The problem I'm having is that I cannot get back to the root (C:\) anymore, and by that I mean the situation as it was as startup, and populate ShellListView with the files in C:\.
If I query ShellTreeView.Root it is always some subfolder of C:\.

Both components have all properties unchanged (so all defaults).

I would have expected for ShellTreeView to look something like this:

C:\

foo bar Lazarus

But is shows like this:

foo bar Lazarus

Bart

Indeed, it could be improved to be like that.

See attached diff.
Would that be a viable approach?

Bart
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shell.diff
Type: text/x-patch
Size: 1651 bytes
Desc: not available
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20130404/cc2d844c/attachment-0001.bin>

Bart wrote

See attached diff. Would that be a viable approach?

Never mind, this (my patch) doesn't work.

Does Delphi's ShellTreeView have the same problem as I described? If not, I'll open a ticket in the bugtracker.

Bart

Bart wrote

Does Delphi's ShellTreeView have the same problem as I described?

Yes, it would be great if someone checked this. I don't have Delphi, so can't check.

Felipe Monteiro de Carvalho wrote

Yes, it would be great if someone checked this. I don't have Delphi, so can't check.

.Neither can I, but googling suggest that delphi indeed show the root like:

root

folder 1 folder 2

So you can get back to the root by clicking it.

I filed a bugreport: http://bugs.freepascal.org/view.php?id=24230

Bart

And if you set Root=C:\Documents and Settings\Someone\Otherfolder

Will it show the root as "C:\Documents and
Settings\Someone\Otherfolder" or as "Otherfolder" ?

Felipe Monteiro de Carvalho wrote

And if you set Root=C:\Documents and Settings\Someone\Otherfolder Will it show the root as "C:\Documents and Settings\Someone\Otherfolder" or as "Otherfolder" ?

It will not show the root at all, see original patch sort of worked, but only if you uses a fully qualified path for it.

Bart

The more I think about it, the more I feel the entire component should be replaced by a widgetset derived control.
* It will show "My Computer", "Desktop" "My Documents" etc in an OS/WidgetSet native way
* Editing a "node" will actually rename the folder (as users expect)

Bart

Attached a new patch.
It will enforce a fully qualified path for root, but will set the node text to what user specifies for root.

Can you try and see if it works for you?
The changes in getPathFromNode may need tweaking for WinCE, which I cannot test.

Bart

Bart wrote

Attached a new patch.

This time with the patch ;-)

Bart
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shell.diff
Type: text/x-patch
Size: 2379 bytes
Desc: not available
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20130406/58756e49/attachment.bin>

Committed in r40732.

Bart

Bart wrote

* Editing a "node" will actually rename the folder (as users expect)

Shouldn't file and directory management be left up to the file manager of each OS? If not, where is this going to end?

Regards,
- Graeme -

Bart wrote

Committed in r40732.

I was planning on reviewing it today. I don't like this chunk:

@@ -631,7 +641,6 @@
 begin
   // avoids crashes in the IDE by not populating during design
   if (csDesigning in ComponentState) then Exit;
-
   r := GetLogicalDriveStrings(SizeOf(Drives), Drives);
   if r = 0 then Exit;
   if r > SizeOf(Drives) then Exit;

The empty line marks the region for which the comment is valid, it should have been deleted.

Also:

+  if not FilenameIsAbsolute(Result) then
+    Result := GetRootPath() + Result;    // Include root directory

I think this is redundant, this entire part could be deleted I think.

On Windows the Explorer consists of just these two components, which implement most of its file management functionality. So either component *is* an OS (Windows) file manager. The OS file access rights are considered sufficient to protect the machine against the user.

Editing directory names is required whenever the user wants to save something into a new directory. Then the component allows to create a new directory first, then to rename it as desired.

DoDi

?? I don't un derstand what you mean by that last line. Anyhow it has been there before I started playing with it.

Without it, it didn't work at some time.
I'll re-test, because since I put that one in, I've changed some more.

Bart

Well, to be honest, current implementation kind of sucks. I made it a little better (I hope) with my changes to SetRoot and SetPath. At least it looks better and navigates better now. (Somebody needs to test this on WinCE!)

Ultimately, if we want some kind of Delphi compatibility, we should let the widgetset/OS do drawing/populating/interacting with FS, just like TSelectDirectoryDialog.

This is however far beyond my capabilities.

Bart

Bart wrote

> The empty line marks the region for which the comment is valid, ?? I don't un derstand what you mean by that last line. Anyhow it has been there before I started playing with it.

Felipe means that you removed an empty line but you shouldn't because it carried information.
Anyway, it does not affect the functionality for sure.

Juha

OK, now I understand.
Didn't notice that.

Restored in r40753

Bart