Hi all,

I'm currently working on the ValueListEditor.
I have some questions on the behaviour of the KeyOptions property that I cannot find an answer to, simply because my Delphi is too old, and it does not have a TValueListEditor at all, and the Embarcadero DocWiki (http://docwiki.embarcadero.com/Libraries/XE3/en/Vcl.ValEdit.TKeyOptions) doesn't provide clear answers either.

So, for anyone that has a recent Delphi here are my questions:

1)
keyDelete: "The user can delete the selected name/value pair by pressing the Delete key."

When does this happen.
- If the user presses Delete in "key" column, or also in "value" column?
- Does it happen if the user is editing the cell (if keyEdit is set)?

2)
keyDelete: the Embarcadero docwiki does not specify: must keyEdit be set in order to set keyDelete (like it is, for keyAdd)?

3)
keyAdd: if the user presses Insert, an empty row is added. (first attempt at implementing this in r40418)
- if you are in an empty row, does it still insert a new one?

Please only provide answer obtained by "black box" testing. Just build a Delpi app and see how it functions.
Do NOT, I repeat do NOT, look at the Delphi source code. Our implementation needs to be clean.

Thanks in advance.

Bart

Bart wrote

Please only provide answer obtained by "black box" testing. Just build a Delpi app and see how it functions. Do NOT, I repeat do NOT, look at the Delphi source code. Our implementation needs to be clean.

Just commenting on this black box testing:
It is OK for somebody else to look at Delphi source and then answer your questions based on that code.
Only copying or otherwise duplicating the Delphi source is not OK. However, these features are easy to test without looking at the source.

If you don't get other answers, I can check with Delphi later. Now I have other things.
I believe most list members have at least Delphi 7 which is enough for testing ValueListEditor.

Regards,
Juha

Delphi 2010 Pro:

Per default property Keyoptions is empty and nothing happens pressing insert, delete ...

You can only select the value and edit it.

If property keyoptions is [keyEdit,keyAdd,keyDelete,keyUnique] and you press Control plus keyDelete, the whole line is deleted. Doesn't matter which column is selected!

- Does it happen if the user is editing the cell (if keyEdit is set)?

YES !!!

2) keyDelete: the Embarcadero docwiki does not specify: must keyEdit be set in order to set keyDelete (like it is, for keyAdd)?

keyDelete can be set, even if keyedit is false !

No !
You just hit the insert key and get ONE new row next to current row.

John Landmesser wrote

Per default property Keyoptions is empty and nothing happens pressing insert, delete ... You can only select the value and edit it.

Same in Lazarus

If property keyoptions is [keyEdit,keyAdd,keyDelete,keyUnique] and you press Control plus keyDelete, the whole line is deleted. Doesn't matter which column is selected!

So, you must press Ctrl+Delete? (Delphi DocWiki says Delete, which IMHO is rather odd).

> - Does it happen if the user is editing the cell (if keyEdit is set)? YES !!!

OK

> keyDelete: the Embarcadero docwiki does not specify: must keyEdit be > set in order to set keyDelete (like it is, for keyAdd)? keyDelete can be set, even if keyedit is false !

Strange, but I'll make it so.

OK, just like Lazarus behaves now.

Thank you very much for your feedback!!

Bart