Hello,

First, sorry for my various requests. I'm contributing to improves this beautiful class.

So, how to show a download progress?

I think that the method "ReadResponse" should have two callbacks, like as "AContentLenght" and "AContentPosition". What do you think?

Thank you!

2013/1/23 silvioprog

Hm... If you change this internal funcion to a class method ...:

  Function Transfer(LB : Integer) : Integer;
  begin
    Result:=FSocket.Read(FBuffer[1],LB);
    If Result<0 then
      Raise EHTTPClient.Create(SErrReadingSocket);
    if (Result>0) then
      Stream.Write(FBuffer[1],Result);
  end;

... the progress of download will be possible, getting the currenty stream size (or position?). :)

ps. i don't tested with chuncked content. :/

2013/1/23 silvioprog

What do you think about implementa this method?:

(...)
public
    procedure ReadingResponse(const ASize, APosition: Int64); virtual;
(...)

Called internally by ReadResponse. (triggered by normal and chunked reading)

2013/1/23 silvioprog

Or only:

    procedure ReadingResponse(AStream: TStream); virtual;

2013/1/23 silvioprog

[...]

I was thinking to myself... an initial idea:

http://pastebin.com/41GTFsws

Please post a feature request.

I think one event

   TOnProgressEvent = (Sender : TObject; BytesRead,ContentLength : Int64) of object;

should be enough.

Michael.

2013/1/23 Michael Van Canneyt

Done:

http://bugs.freepascal.org/view.php?id=23734

Depending on how you implement it, i think that i can do a "download resumed".