Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / lazarus / 2012-06

./lcl/intfgraphics.pas and tiff

5 messages · 4 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

ik

Hello,

There are two issues at the moment I found with ./lcl/intfgraphics.pas :
1. Misspelled TTiffIDF to TTiffIFD
2. at line 635
procedure DoCreateImage(ImgFileDir: TTiffIDF); {$IF FPC_FULLVERSION>=20701}override;{$ENDIF}

FPC (from the latest svn revision - r21482), does not contain such method.

I can send a patch to fix the first problem, but I need to better understand the need for the second one.
It might that the code was not yet been committed, or it was removed.

What should I do with the second "fix" ?

Thanks,
Ido
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20120604/803ddd7f/attachment.html>

Reply by email

ik
to ik
ik wrote 19 lines
Hello, There are two issues at the moment I found with ./lcl/intfgraphics.pas : 1. Misspelled TTiffIDF to TTiffIFD 2. at line 635 procedure DoCreateImage(ImgFileDir: TTiffIDF); {$IF FPC_FULLVERSION>=20701}override;{$ENDIF} FPC (from the latest svn revision - r21482), does not contain such method. I can send a patch to fix the first problem, but I need to better understand the need for the second one. It might that the code was not yet been committed, or it was removed. What should I do with the second "fix" ? Thanks, Ido

Ignore it, the fpc tree had a commit, and even the first problem "gone". -------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20120604/35f72b07/attachment.html>

Reply by email

Mattias Gaertner
to ik
Show quoted text 24 lines
On Mon, Jun 4, 2012 at 1:23 PM, ik wrote: > Hello, > > There are two issues at the moment I found with ./lcl/intfgraphics.pas : > 1. Misspelled TTiffIDF to TTiffIFD > 2. at line 635 > procedure DoCreateImage(ImgFileDir: TTiffIDF); {$IF > FPC_FULLVERSION>=20701}override;{$ENDIF} > > FPC (from the latest svn revision - r21482), does not contain such method. > > I can send a patch to fix the first problem, but I need to better > understand the need for the second one. > It might that the code was not yet been committed, or it was removed. > > What should I do with the second "fix" ? > > Thanks, > Ido > Ignore it, the fpc tree had a commit, and even the first problem "gone".

The fpc commit came shortly before the lazarus commit. The tiff reader now supports reading multi page files, tiles, CMYK and a few other improvements.
The TTiffIDF was a typo and was fixed to TTiffIFD.

Mattias

Reply by email

Bernd
to Mattias Gaertner

2012/6/4 Mattias Gaertner :

Show quoted text 6 lines
> Ignore it, the fpc tree had a commit, and even the first problem "gone". The fpc commit came shortly before the lazarus commit. The tiff reader now supports reading multi page files, tiles, CMYK and a few other improvements. The TTiffIDF was a typo and was fixed to TTiffIFD.

Unfortunately it wont compile with the 2.6 branch anymore now. I think the only solution would be an $ifdef for the next few years until 2.6 will be considered "old and unsupported"

Reply by email

Reinier Olislagers
to Bernd
Bernd wrote 11 lines
2012/6/4 Mattias Gaertner : >> Ignore it, the fpc tree had a commit, and even the first problem "gone". > > The fpc commit came shortly before the lazarus commit. > The tiff reader now supports reading multi page files, tiles, CMYK and > a few other improvements. > The TTiffIDF was a typo and was fixed to TTiffIFD. Unfortunately it wont compile with the 2.6 branch anymore now. I think the only solution would be an $ifdef for the next few years until 2.6 will be considered "old and unsupported"

Issue was partly fixed; there's still an include file: lcl/include/tiffimage.inc
that needs fixing.

See
http://bugs.freepascal.org/view.php?id=22199
for patch

Thanks,
Reinier

Reply by email