Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / lazarus / 2012-06

Remove unused lines depend on SYN_LAZARUS and FPC defines

7 messages · 2 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Zaher Dirkey

Hi, Matrin

I am working again to remove unused lines that depend on SYN_LAZARUS and FPC defines (now SynEditHighlighter.pas)
and noticed LoadFromBorlandRegistry and LoadFromRegistry become unsufule if i removed, can i remove this functions too?

I am using last revision of Lazarus, FPC 2.6 on Windows XP SP3

Best Regards
Zaher Dirkey
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20120602/c66c956d/attachment.html>

Reply by email

Martin
to Zaher Dirkey
Zaher Dirkey wrote 9 lines
Hi, Matrin I am working again to remove unused lines that depend on SYN_LAZARUS and FPC defines (now SynEditHighlighter.pas) and noticed LoadFromBorlandRegistry and LoadFromRegistry become unsufule if i removed, can i remove this functions too? I am using last revision of Lazarus, FPC 2.6 on Windows XP SP3

OK

Reply by email

Zaher Dirkey
to Martin
Martin wrote 16 lines
On 01/06/2012 22:13, Zaher Dirkey wrote: > Hi, Matrin > > I am working again to remove unused lines that depend on SYN_LAZARUS and > FPC defines (now SynEditHighlighter.pas) > and noticed LoadFromBorlandRegistry and LoadFromRegistry become unsufule > if i removed, can i remove this functions too? > > > I am using last revision of Lazarus, FPC 2.6 on Windows XP SP3 > OK

Thanks

I removed, UseUserSettings and EnumUserSettings in SynHighlighterPas.pas also LoadFromRegistry SaveToRegistry become not useful because it load and save Delphi options
SynHighlighterAny has this function also?

if it ok, i will send the patch in bug tracker.

I am using last revision of Lazarus, FPC 2.6 on Windows XP SP3

Best Regards
Zaher Dirkey
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20120602/b88278eb/attachment.html>

Reply by email

Martin
to Zaher Dirkey
Zaher Dirkey wrote 18 lines
On Sat, Jun 2, 2012 at 12:23 AM, Martin < <mailto:>> wrote: On 01/06/2012 22:13, Zaher Dirkey wrote: Hi, Matrin I am working again to remove unused lines that depend on SYN_LAZARUS and FPC defines (now SynEditHighlighter.pas) and noticed LoadFromBorlandRegistry and LoadFromRegistry become unsufule if i removed, can i remove this functions too? I am using last revision of Lazarus, FPC 2.6 on Windows XP SP3 OK

I was to quick only checked LoadFromBorlandRegistry

Show quoted text 11 lines
Thanks I removed, UseUserSettings and EnumUserSettings in SynHighlighterPas.pas also LoadFromRegistry SaveToRegistry become not useful because it load and save Delphi options SynHighlighterAny has this function also? if it ok, i will send the patch in bug tracker. I am using last revision of Lazarus, FPC 2.6 on Windows XP SP3

Actually why are load/ save not useful ? (assuming windows) They are incomplete, but they save some of the actual config

I don't even know, why the current Load code is disabled. probably some minol issue (if the save code compiles)...
I don't have the time to test them now.

Best to keep the "functional changes" to separate discussion. that makes it easier to clean the ifdef.

----
LoadFromBorlandRegistry can still go ....
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20120601/72be8138/attachment.html>

Reply by email

Zaher Dirkey
to Martin
Martin wrote
I don't even know, why the current Load code is disabled. probably some minol issue (if the save code compiles)...

It is only load from Delphi registry, and i think it is deprecated now, and not compatiple, if we remove Delphi load, LoadFromRegistry become empty, i can keep it but empty to override it somewhere.

Best to keep the "functional changes" to separate discussion. that makes

it easier to clean the ifdef.

Hmm, yes, but i can't see that ancients functions without remove it, it is kind of cleanup,

I don't have the time to test them now.

I can postpone this modification if u like.

All above this changes, finished and compiled now, so no more discusses.

Best Regards
Zaher Dirkey
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20120602/7f5e5bc3/attachment.html>

Reply by email

Martin
to Zaher Dirkey
Zaher Dirkey wrote 15 lines
On Sat, Jun 2, 2012 at 12:59 AM, Martin < <mailto:>> wrote: I don't even know, why the current Load code is disabled. probably some minol issue (if the save code compiles)... It is only load from Delphi registry, and i think it is deprecated now, and not compatiple, if we remove Delphi load, LoadFromRegistry become empty, i can keep it but empty to override it somewhere. >Best to keep the "functional changes" to separate discussion. that makes it easier to clean the ifdef. Hmm, yes, but i can't see that ancients functions without remove it, it is kind of cleanup,

We can decide that in a 2nd step

and further more, when they can be tested.

>I don't have the time to test them now. I can postpone this modification if u like.

Would be good. one patch ifdef.

then we can see.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20120601/65c24886/attachment-0001.html>

Reply by email

Zaher Dirkey
to Martin
Martin wrote

We can decide that in a 2nd step

Show quoted text 14 lines
and further more, when they can be tested. >I don't have the time to test them now. I can postpone this modification if u like. Would be good. one patch ifdef. then we can see.

Done
http://bugs.freepascal.org/view.php?id=22180

Best Regards
Zaher Dirkey
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20120602/77a8bc38/attachment.html>

Reply by email