Hi,
I would like to implement a "Prompt on replace" checkbox in TReplaceDialog. This might however not be Delphi compatible.
Does anyone object if I would implement this?
Bart
Mailing lists / lazarus / 2011-11
TReplaceDialog: feature request
9 messages · 4 people · –
- Bart 5
- Mattias Gaertner 2
- Felipe Monteiro de Carvalho 1
- Maxim Ganetsky 1
Reply by email Subscribe to this list Your subscription
Read-only archive. Use j and k to move between messages.
?
Bart hat am 8. November 2011 um 18:00 geschrieben:
Hi, I would like to implement a "Prompt on replace" checkbox in TReplaceDialog. This might however not be Delphi compatible.?
Why not??
?
?
Does anyone object if I would implement this??
?
Mattias
?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20111108/ef876c12/attachment.html>
I would like to implement a "Prompt on replace" checkbox in TReplaceDialog. This might…
Bart wroteDoes anyone object if I would implement this?
Rarely do objections to implementing something exist. The important part is how it is done. And the key thing is that whatever you do should be backwards compatible, unless you have a very good reason (like the previous implementation being completely broken or implemented in a wrong way)
And without seeing at least a very initial patch it is hard to say if you are doing it correctly.
Felipe Monteiro de Carvalho
Felipe Monteiro de Carvalho wrote 5 lines
Rarely do objections to implementing something exist.
...
And without seeing at least a very initial patch it is hard to say if
you are doing it correctly.
I'll give it a try then and post it in the bugtracker.
Bart
Rarely do objections to implementing something exist. The important part is how it is…
Yeah,
Nice one. I opened the replagedialogform in the IDE (lcl/relacedlgunit.pas), and somehow this action added to package LCL Base a dependency on LCL (10 times!), which caused a circular dependency in the installed packages.
I manually had to remove the 10 added dependencies to LCL in the LCL Base package.
WTF!
Bart
Rarely do objections to implementing something exist. The important part is how it is…
Hi Mattias and Felipe,
I have implemented (and tested) such a feature and posted it on the bugtracker: http://bugs.freepascal.org/view.php?id=20654
I think I managed to code it according to the current coding style.
Could either of you review the patch?
Bart
Nice one. I opened the replagedialogform in the IDE (lcl/relacedlgunit.pas), and somehow…
09.11.2011 4:09, Bart ?????:
Show quoted text 9 lines
Yeah,
Nice one. I opened the replagedialogform in the IDE
(lcl/relacedlgunit.pas), and somehow this action added to package LCL
Base a dependency on LCL (10 times!), which caused a circular
dependency in the installed packages.
I manually had to remove the 10 added dependencies to LCL in the LCL
Base package.
WTF!
You use fresh Lazarus revision, don't you?
Best regards,
Maxim Ganetsky mailto:
Nice one. I opened the replagedialogform in the IDE (lcl/relacedlgunit.pas), and somehow…
Show quoted text 9 lines
Yeah,
Nice one. I opened the replagedialogform in the IDE
(lcl/relacedlgunit.pas), and somehow this action added to package LCL
Base a dependency on LCL (10 times!), which caused a circular
dependency in the installed packages.
I manually had to remove the 10 added dependencies to LCL in the LCL
Base package.
WTF!
Please test with svn trunk revision 33427.
Mattias
09.11.2011 4:09, Bart ?????: You use fresh Lazarus revision, don't you? Maxim Ganetsky …
@Maxim and Mattias
You use fresh Lazarus revision, don't you?
I'm at revision 33269.
Revisions are going very fast this time of year, 158 revisions in 6 days... I'll correct some issues in my patch first and then I'll update.
Bart