Hi,

Lazarus 0.9.31 r32144 FPC 2.4.4 i386-win32-win32/win64

Anyone has the same problem?

Drop a SynMemo on a form
Leave all properties unchanged
Build
Run

In Synmemo set cursor at end of last line
Press Enter (once ore more)
(A new line is created)
Press Ctrl+Z
The line is removed, but the cursor stays where it was. In the gutter the linenumbers get updated correctly.

Press Enter again: the synmemo throws an exception "TApplication.HandleException Invalid stringlist index 2"

Does not happen in the IDE source editor b.t.w.

Bart

Yes, exactly the same here.
Using Lazarus 0.9.31 r32230M FPC 2.7.1 i386-win32-win32/win64

Dirk.

And it's TSynMemo only, TSynEdit works.

BTW, something I have been wondering for a long time: What is everyones facination with TSynMemo?

It's 99.9% identical with TSynEdit (except for the extra bug), it has only the folowing differenes
- it may publish less properties that TSynEdit. Not sure, but it has it's own list what is published, and TSynEdit publishes everything, so TSynMemo is less or equal
- it adds to wrapper function:
Clear and Append => thay are 100% equal to Lines.Clear and Lines.Append
- and it adds CharIndexToRowCol and RowColToCharIndex

The last 2 are the only things that actually have some functionality. Is really everyone using them?
Is everyone treating their text as one long text (contains all the lines) and need to know the BytePos of a XY pos?
Isn't it much easier to treat the text as individual lines? Actually I heard quite a few times people ask, how they do the reverse in TMemo, and here we are TSynEdit already dealing in XY, and everyone needs the BytPos..

I really do not understand it....

LOL, I often questioned that on SynEdit upstream. At least there the TSynMemo implemented some EM_xxx messages handling. I vote for removing TSynMemo from the ComponentPalette ;-)

It's 99.9% identical with TSynEdit (except for the extra bug), it has only the folowing differenes

This makes the bug all the more weird.

- it may publish less properties that TSynEdit. Not sure, but it has it's own list what is published, and TSynEdit publishes everything, so TSynMemo is less or equal

TSynMemo doesn't publish any additional properties (except some
IFDEF-out, including some obsolete ones). TSynEdit publish or
implement the following additional properties:
    property ShareOptions;
    property Beautifier;
    property BlockIndent;
    property OnMouseEnter;
    property OnMouseLeave;
    property IncrementColor;
    property HighlightAllColor;
    property BracketHighlightStyle;
    property BracketMatchColor;
    property FoldedCodeColor;
    property MouseLinkColor;
    property LineHighlightColor;
    property DefaultSelectionMode;
    property OnSpecialLineMarkup;
    property OnStatusChange;
    property OnClickLink : TMouseEvent read FOnClickLink write FOnClickLink;
    property OnMouseLink: TSynMouseLinkEvent read FOnMouseLink write
FOnMouseLink;

Best regards,
Fl?vio

Not at all

If foo is TSynEdit // pretty much doesn't work for TSynMemo => they both come from TCustomSynEdit

SharedOptions is public? not published?

Only now, when I was going to report the bug I realized what you meant :-/ That's exactly the problem.
TSynEditUndoCaret.PerformUndo and TSynEditUndoSelCaret.PerformUndo check for TSynEdit.
TSynEditPlugin.GetEditor and TSynBaseCompletion.Execute should also be updated. I can make a patch (and/or report a bug in mantis) if you wish. And regardless of these bugs there's no reason for TSynMemo not to inherit from TSynEdit.

SharedOptions is public? not published?

Yes, I just didn't feel the need to single it out since it was unimportant in the context.

Best regards,
Fl?vio

did I miss some? I fixed several files

Fl?vio Etrusco wrote

TSynEditUndoCaret.PerformUndo and TSynEditUndoSelCaret.PerformUndo check for TSynEdit.

Thanks for fixing it.
And I will make my class TSynEdit derived based upon your comments. (It was old D3 code)

Bart