Hello,

I just updated the latest SVN truck version (Revision : 31692)

Compiling of the our winCE project will fail with message :

C:\lazarus\lcl\interfaces\wince\wincewscomctrls.pp(69,20) Error: There is no method in an ancestor class to be overridden: "class TWinCEWSCustomNotebook.GetPageRealIndex(const
TCustomNotebook,LongInt):LongInt;"

-Tee-

It is Felipe's work in progress I think.

Bart

Right, this widgetset deserves an update.

Please remove that method from wincewscomctrls.TWinCEWSCustomNotebook, and try again.

DoDi

Bart wrote

It is Felipe's work in progress I think.

Are you sure? I think that not ... I checked wince after my changes. It could be Hans-Peter's patch, however.

Felipe Monteiro de Carvalho wrote

Are you sure? I think that not ... I checked wince after my changes. It could be Hans-Peter's patch, however.

Yes, it was ...

http://svn.freepascal.org/cgi-bin/viewvc.cgi/trunk/lcl/interfaces/win32/win32wscomctrls.pp?root=lazarus&r1=31686&r2=31685&pathrev=31686

I didn't spot this when applying the patch =(

Works...

-TP-

It should be fixed in rev 31701

Hans-Peter Diettrich wrote

Eventually another Delphi compatible rename should be made. As I just found out, Delphi defines PageIndexFromTabIndex for my TabToPageIndex. But since this is a private method in TPageControl, and the LCL used other names for the same purpose, a rename is not required.

But does the Delphi one do the same as yours? From the name I'd guess it does the opposite.

Hans-Peter Diettrich wrote

I'd suggest to remove GetPageRealIndex from the widget classes at all, to prevent possibly incompatible overrides. When ever required, a widget should use PageToTabIndex instead of GetPageRealIndex, and TabToPageIndex for NotebookPageRealToLCLIndex.

I removed GetPageRealIndex in trunk

It is Felipe's work in progress I think.

Yes, based on my supplied patch, that's why I can explain what remains to do.

The mapping between logical Pages and visible Tabs in the TCustomNotebook was scattered into multiple unrelated places, e.g. TCustomPage and the widgetsets. The new TCustomNotebook does this mapping itself, in TabToPageIndex and PageToTabIndex, and these methods should be used by the widgetsets.

I'd suggest to remove GetPageRealIndex from the widget classes at all, to prevent possibly incompatible overrides. When ever required, a widget should use PageToTabIndex instead of GetPageRealIndex, and TabToPageIndex for NotebookPageRealToLCLIndex.

Eventually another Delphi compatible rename should be made. As I just found out, Delphi defines PageIndexFromTabIndex for my TabToPageIndex. But since this is a private method in TPageControl, and the LCL used other names for the same purpose, a rename is not required.

DoDi

The added methods cover both directions.

From the name I'd guess it does the opposite.

From and To can be a bit confusing ;-)

DoDi