Hello,

I'm trying to build Lazarus 0.9.31 r23597:28822M FPC 2.4.2 x86_64-linux-gtk 2
and I have problem at this code (/synunihighlighter/synunidesigner.pas):

  {$IFDEF SYN_LAZARUS}
  PageControl.ShowTabs:=false;
  {$ENDIF}

It looks like that ShowTabs does not exists for the TNotebook component for some reason.

Thanks,
Ido

LINESIP - Opening the source for communication
http://www.linesip.com
http://www.linesip.co.il
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20110102/92b4f26b/attachment.html>

2011/1/2 ik :

Probably caused by r28850. Felipe, do you know how it can be fixed?

Vincent

2011/1/2 ik :

If you have something like:

PageControl: TNotebook;

It is pretty obvious that the code is broken. It should be:

PageControl: TPageControl;

I fixed TNotebook, so obviously any code which depended on the old wrong behavior is broken.

Vincent Snijders wrote

Probably caused by r28850. Felipe, do you know how it can be fixed?

Probably just changing the declaration of the control from TNotebook to TPageControl should fix the issue.

2011/1/2 ik :

Another idea would be only removing this line. Does it work if you remove this line?

2011/1/3 Felipe Monteiro de Carvalho :

I fixed TNotebook, so obviously any code which depended on the old wrong behavior is broken.

Can you document this on a new page like
http://wiki.lazarus.freepascal.org/Lazarus_0.9.30_release_notes for the 0.99 release?

Vincent

On Mon, Jan 3, 2011 at 02:55, Felipe Monteiro de Carvalho <

No, you have also removed the ActivePage and it's successor, and it makes a lot of problems with existed code.

How can I set now a new active page for example ? (If I'll understand that, I think I can patch things).

Ido
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20110103/49186e56/attachment.html>

2011/1/3 ik :

No, you have also removed the ActivePage and it's successor, and it makes a lot of problems with existed code.

Which place exactly uses this property? Is it also around a {$IFDEF SYN_LAZARUS} ?

How can I set now a new active page for example ? (If I'll understand that, I think I can patch things).

Setting the page by index:

file lcl/extctrls.pas

TNotebook = ...
...

    property PageIndex: Integer read GetPageIndex write SetPageIndex default -1;

...

On Mon, Jan 3, 2011 at 11:25, Felipe Monteiro de Carvalho <

You have a lot of occurrences such as :
synunidesigner.pas at line 825.

And they do not use {$IFDEF SYN_LAZARUS} ?

But the code expect to assign the TPage class and not an index, so it require to change the whole way things are working there.

Why did the ActivePage and ActivePageComponent where removed ?

Ido
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20110104/5cbc02e6/attachment-0001.html>

2011/1/4 ik :

And they do not use {$IFDEF SYN_LAZARUS} ?

...

But the code expect to assign the TPage class and not an index, so it require to change the whole way things are working there. Why did the ActivePage and ActivePageComponent where removed ?

They were not removed. The entire control was removed because it was implemented in a completely wrong way. A new version was written from zero.

You are correct, ActivePage is still unimplemented, but it does not assign a TPage class. It assigns a string:

http://docwiki.embarcadero.com/VCL/en/ExtCtrls.TNotebook.ActivePage

There is no method in Delphi to assign a TPage to a TNotebook as far as I saw in the docs. Of course one could be added.

On Tue, Jan 4, 2011 at 13:35, Felipe Monteiro de Carvalho <

But the code there try to do just that with ActivePageComponent :(

Ido

LINESIP - Opening the source for communication
http://www.linesip.com
http://www.linesip.co.il
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20110104/ef82b34c/attachment.html>

I have created a bug report with a patch to fix the issue: http://bugs.freepascal.org/view.php?id=18390

Ido

LINESIP - Opening the source for communication
http://www.linesip.com
http://www.linesip.co.il
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20110104/700a00ce/attachment.html>