In TGraphicControl Canvas.ClipRect have value depend on the Parent of this control (e.g. Form), while in Win32 it get based on Left and Top of the Control
it is make problem with Controls use Canvas.ClipRect and InvalidateRect, like TGrid.

Lazarus SVN #27109

Thanks in advance.

Zaher Dirkey wrote

like TGrid.

Sorry TGird is TWinControl, but I have TGraphicControl use ClipRect.

2010/8/17 Zaher Dirkey :

May be related to http://bugs.freepascal.org/view.php?id=15508 -- similar problem on Win32

That bug for SetClipRect, the bug in my hand when make InvalidateRect to a for TGraphicControl, in Win32 received correct ClipRect, in WinCE nop I think it is depend on MoveWindowOrg.

PaintControls draw the controls after move the coordinates by call MoveWindowOrg(DC, Left, Top) at this time the ClipRect (ClipBox) must be moved in WinCE but that not happened.

Thanks

2010/8/17 Zaher Dirkey :

PaintControls draw the controls after move the coordinates by call MoveWindowOrg(DC, Left, Top) at this time the ClipRect (ClipBox) must be moved in WinCE but that not happened.

MoveWindowOrg is very problematic under Windows CE, it basically destroys all native drawing of controls if overused.

Maybe we need a flag which warns the LCL that the platform doesn't support WindowOrg, and then it will use absolute positions like was done before.

On Tue, Aug 17, 2010 at 8:03 AM, Felipe Monteiro de Carvalho <

Yes it is WinCE issue, i have tested with native API, ClipRect not moved to new coordinates, but MoveWindowOrg worked in WinCE

--------------------------------------------------------
procedure TForm1.Paint;
var
  R: TRect;
  sdc: Integer;
begin
  inherited Paint;
  Windows.GetClipBox(Canvas.Handle, @R);
  Log(PrintRect(R));
  sdc := SaveDC(Canvas.Handle);
  MoveWindowOrg(Canvas.Handle, 100, 100);
  Windows.GetClipBox(Canvas.Handle, @R);
  Log(PrintRect(R));
  RestoreDC(Canvas.Handle, sdc);
  Windows.GetClipBox(Canvas.Handle, @R);
  Log(PrintRect(R));
end;
--------------------------------------------------------
The next example it used to test MoveWindowOrg and it is worked,
--------------------------------------------------------
procedure TForm1.Button3Click(Sender: TObject);
var
  R: TRect;
begin
  R:= Rect(10, 100, 60, 150);
  Canvas.Brush.Style := bsClear;
  Canvas.Pen.Color := clGreen;
  Canvas.Rectangle(R);
  MyMoveWindowOrg(Canvas.Handle, 50, 50);
  Canvas.Brush.Style := bsClear;
  Canvas.Pen.Color := clGreen;
  Canvas.Rectangle(R);
end;
--------------------------------------------------------

What if implement the GetClipRect in WinCE wedgetset to offset the rect depenf on the new coordinaed by call GetWindowsOrgEx, I will test it

function TWinCEWidgetSet.GetClipBox(DC : hDC; lpRect : PRect) : Longint;
var
  P: TPoint;
begin
  Result := Windows.GetClipBox(DC, Windows.LPRECT(lpRect));
  LCLIntf.GetWindowOrgEx(DC, @P);
  OffsetRect(lpRect^, -P.x, -P.y);
end;

Thanks

On Tue, Aug 17, 2010 at 8:03 AM, Felipe Monteiro de Carvalho <

Hi,
Before #22551 the WinCE and my controls work perfect in all devices that i have, now i have this problems, what it is changed why we lost that, not only ClipRect, it is drawing the Graphic controls on Sony Ericsson X1 Xperia, it have special DC (Canvas), i still work on it to understand the problem.

Thanks

I-Mate Shapes draw as it designed
http://flic.kr/p/8taG5n

X1 Hi density screen, it do somthing to make the control bigger, but there is trouble in draw Shapes
http://flic.kr/p/8tdFXL

I only see 2 screenshots, without any information about how the drawing is being done, if the app is hiresaware, why it should be wrong, etc.

The code of the app would be good too.

On Tue, Aug 17, 2010 at 11:53 PM, Felipe Monteiro de Carvalho <

Thanks for your replay.

First screen I-Mate the good, the second the bad drawing for the same app.

On Tue, Aug 17, 2010 at 11:53 PM, Felipe Monteiro de Carvalho <

The code of the app would be good too.

We can add ExcludeClipRect to GetClibBox (Canvas.ClipRect) , ExcludeClipRect the rect must offset before call it, depend on the SetWindowOrgEx values.

Best regards

Hello,

Could you please paste the code that you are using to draw?

Without actual code it is hard to guess the problem.

thanks,

On Wed, Aug 18, 2010 at 8:41 AM, Felipe Monteiro de Carvalho <

http://lazarus.freepascal.org/index.php/topic,10237.new.html#new Include the example to test the problem.

I don't see your drawing code in that forum post.

2010/8/19 Felipe Monteiro de Carvalho :

I don't see your drawing code in that forum post.

Download the attachement.
http://lazarus.freepascal.org/index.php?action=dlattach;topic=10237.0;attach=991

The TMyControl.Paint method contains the drawing code.

Vincent

Interresting, I couldn't see the attachment because I wasn't logged to the forum...

I just checked your code. Indeed, I think that SetWindowOrg is somehow badly affecting the ClipRect.

But, on the other hand, are you aware that you can make your drawing without any use of the ClipRect? You just need to draw everything to a TBitmap and then copy the bitmap in one quick step to the screen.

Using a TCustomControl descendent instead of a TGraphicControl will probably also help.

It would be good if you could add this to the bug tracker and upload there the test app as well.

thanks,

Here is an example code of how to double buffer with a TBitmap:

http://wiki.freepascal.org/Developing_with_Graphics#Create_a_custom_control_which_draws_itself

On Fri, Aug 20, 2010 at 12:31 PM, Felipe Monteiro de Carvalho <

But, on the other hand, are you aware that you can make your drawing without any use of the ClipRect? You just need to draw everything to a TBitmap and then copy the bitmap in one quick step to the screen.

Double buffer eat the memory, and slow painting in slow devices.

Using a TCustomControl descendent instead of a TGraphicControl will probably also help.

Yes it is help, but my controls worked for more than 2 years with my customer hands on slow devices, why i should now to convert to heavy kind controls, TGraphicControl more light for me.

It would be good if you could add this to the bug tracker and upload there the test app as well.

I will make a patch to resolve that problem (just correcting the rect of ClipRect and ExcludeClipRect in WinCE wedgets) and post it with bug tracker.

Thanks

Zaher Dirkey wrote

I will make a patch to resolve that problem (just correcting the rect of ClipRect and ExcludeClipRect in WinCE wedgets) and post it with bug tracker.

I posted a bug tracker with a patch
http://bugs.freepascal.org/view.php?id=17249

Thanks

Hi, i reopened the bug with new patch.

Thanks in advance.