Hello List,

Zaher have posted 3 patches to add better BiDi support and also wrote about it in the malling list.
It seems that the bug reports that contain the patches was not even looked at.

The patches located at:
http://bugs.freepascal.org/view.php?id=16387
http://bugs.freepascal.org/view.php?id=16247
http://bugs.freepascal.org/view.php?id=16196

Are there any ways we can make it easier for the development team to look/apply such patches ?

Thanks,
Ido
http://ik.homelinux.org/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20100504/1a9628e9/attachment.html>

ik wrote

The patches located at: http://bugs.freepascal.org/view.php?id=16387 http://bugs.freepascal.org/view.php?id=16247 http://bugs.freepascal.org/view.php?id=16196

Thanks, I will look today/tomorow.

Are there any ways we can make it easier for the development team to look/apply such patches ?

It is simple not easy to apply / review / fix all the things which are listed in the bug tracker. It has > 900 open issues and every needs some attention.

It would be very nice if reporters mark check their bugs from time to time and update their status if it is changed. Today I resolved about 10 reports which were already fixed but nobody noticed. And each of them required testing from my side.

Best regards,
Paul Ishenin.

Sorry.
We are all quite busy at the moment at other parts of lazarus. See the svn log.

Well, you could add test examples.

I applied them with small modifications.

Mattias

It seems that the bug reports that contain the patches was not even looked at.

A bit impatient? It has been there for just 3 days.

I sometimes have patches in mantis laying around for > 2 months before they are applied by one of the managers.
The managers are busy people, they have to devide their time between all of us reporters/developers.

As it is now, your patches are applied, mine are still not. I don't think it's a good idea if everyone who posts a patch announces this on this list in order to grab the attention of one of the managers (but that's just my opinion).

Bart

I do not think that 2 months are a good time to wait. Personally I think there should be some additional commit rights for some users in the projects, and the load might spread better.

Does your patches important for you ? If so, try to make them a priority. As I said, the Lazarus theme must have additional "blood" in the development, that reduce some load.
Further more, what are you doing in order to help the theme to apply your patches, deal with your bugs etc... ?

Ido
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus.freepascal.org/pipermail/lazarus/attachments/20100504/cdf74f13/attachment.html>

Hi, First i thanks for applying the patches,

There is problem with mantis that not send email notification of our issues when the status is changes, it is force us to check it every day depend on our eyes, as
i think it is Mantis bug
Mantis not send email notification for owned or monitored bugs.

http:/msg05114.html

Another problem, it is when make patch1, then need to make patch2 depend on patch1, how can send the patch diff file between 1 and 2, for that we need to applying the patch1, or must there is another way, someone use git to make it but i have no change with it.

Thanks

On Tue, May 4, 2010 at 12:19 PM, Mattias Gaertner <

There is test project for most controls

http://bugs.freepascal.org/view.php?id=16197
But it is need to cleanup, remove my own paths, you can leave it in the bug tracker.

I applied them with small modifications.

Thanks, and this there is i small bug need to apply a new small patch http://bugs.freepascal.org/view.php?id=16387

Thanks in advance.

Bart wrote

I sometimes have patches in mantis laying around for> 2 months before they are applied by one of the managers. The managers are busy people, they have to devide their time between all of us reporters/developers.

If some of your patches are still not applied please point them.

Best regards,
Paul Ishenin.

Is this a one-time request or should we post a reminder to the list if a patch isn't applied or acknowledged in a timely manner? If so, what should be considered a "timely manner"? Shouldn't it be decided a single way to group patches for easy browsing/handling?

Best regards,
Fl?vio

Fl?vio Etrusco wrote

Is this a one-time request or should we post a reminder to the list if a patch isn't applied or acknowledged in a timely manner? If so, what should be considered a "timely manner"? Shouldn't it be decided a single way to group patches for easy browsing/handling?

There are no rules here. There is nothing bad I think to remind about a waiting patch in the tracker if it is not applied withing a week.

Best regards,
Paul Ishenin.

Paul Ishenin wrote

If some of your patches are still not applied please point them.

http://bugs.freepascal.org/view.php?id=15904 (although there is discussion about the solution)
http://bugs.freepascal.org/view.php?id=15295

B.t..w. none of these are urgent. I just saw an opportunity to fix them.

Bart

On Tue, May 4, 2010 at 12:19 PM, Mattias Gaertner <

Just need to apply very small patch (
Bidi_Menu_GTK2_Fix.patch<http://bugs.freepascal.org/file_download.php?file_id=11391&type=bug>), to close the bug.
http://bugs.freepascal.org/view.php?id=16387

With many thanks