Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / lazarus / 2010-04

"Refactor" main menu item

3 messages · 2 people ·

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Juha Manninen

Hi

I uploaded a patch for issue #15333: Menu structure revamp, Refactoring

It implements "Refactor" menu and moves 3 items from Edit- and Search-menus there. I believe there will be more items in future.

The menu structure should be changed at least for these reasons:
1. Refactor is logically different from Edit and Search.
2. Delphi has a Refactor menu.
3. Lazarus also has a Refactoring menu as an editor popup menu. It has more items, some of which could be added to main Refactor menu, too. Later the popup menu could be improved, too.

I would like to get this applied. Or, if this is not the way to do it, please give feedback.
Some patches are still hanging in bug tracker for months. How to improve that?

Regards,
Juha

Reply by email

Martin
to Juha Manninen

MessageComposer doesnt compile with it

C:\lazarus_latest\components\messagecomposer\messagecomposer.pas(858,46) Error: Identifier not found "itmEditMenuCodeTools"

Have you tested all other packages (as far as they come with lazarus?

Removing stuff from the various "intf" units is dangerous business. Even if you fix all packages that come with Lazarus, You should leave them in, and mark them as deprecated.

Martin

Juha Manninen wrote 28 lines
Hi I uploaded a patch for issue #15333: Menu structure revamp, Refactoring It implements "Refactor" menu and moves 3 items from Edit- and Search-menus there. I believe there will be more items in future. The menu structure should be changed at least for these reasons: 1. Refactor is logically different from Edit and Search. 2. Delphi has a Refactor menu. 3. Lazarus also has a Refactoring menu as an editor popup menu. It has more items, some of which could be added to main Refactor menu, too. Later the popup menu could be improved, too. I would like to get this applied. Or, if this is not the way to do it, please give feedback. Some patches are still hanging in bug tracker for months. How to improve that? Regards, Juha -- _______________________________________________ Lazarus mailing list http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

Reply by email

Juha Manninen
to Martin
Show quoted text 10 lines
MessageComposer doesnt compile with it C:\lazarus_latest\components\messagecomposer\messagecomposer.pas(858,46) Error: Identifier not found "itmEditMenuCodeTools" Have you tested all other packages (as far as they come with lazarus? Removing stuff from the various "intf" units is dangerous business. Even if you fix all packages that come with Lazarus, You should leave them in, and mark them as deprecated.

Ok, itmEditMenuCodeTools was the only identifier removed. It should be left where it is then.
I should have tested with packages more.

Juha

Reply by email