-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

does anybody know details about how exactly the JEDI code formatter works? I think i have found a bug and i want to fix it. Although i already filed a bug with the JCF project i think it will take some time until it is fixed in Lazarus too and I think it is only a few lines of code, so i can make my own workaround until then (and maybe send the patches to jcf if i'm faster than them).

Here is the bug: when i have a program

program foo;
const
    x = 1;
begin
end.

the code formatter will remove the indentation before the x which looks quite ugly. indentation of const blocks work only in units, not in programs or libraries (tested with the current download of jcf from their sourceforge page).

I think this should be easy to fix if I only knew where to look in all the many source files of the jcf. Can anybody point me into the right direction?

Bernd
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iD8DBQFLdh+FxT6R4jlFoh0RAmhKAKDM+DQQa6xVH+rU9X7cweBT3AKOFQCg5i0K hAFiHTbxiwZzpbkGr+kVAXY=
=bh78
-----END PGP SIGNATURE-----

If the bug is fixed in the JCF code repository then I will update lazarus version. I do this from time to time.

Best regards,
Paul Ishenin.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Paul Ishenin wrote

If the bug is fixed in the JCF code repository then I will update lazarus version. I do this from time to time.

I have found the bug and fixed it. Here is the fix:

C:\lazarus\components\jcf2\Process\Indent\Indenter.pas starting in line 113:

change this to:

This is only called once near the end of the file at line 638 and seems to be part of another prior bugfix. The bug in the bugfix 1898723 and my fix for the fix will only ever happen if the setting "indent for procedures in library" is DISabled, else all this code won't be executed at all.

I'll continue to test this a bit although I think it is safe and could already be sent upstream.

Bernd
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iD8DBQFLdq2ixT6R4jlFoh0RArzKAJ96SN143sG8RpPTJzT4AS8mWKRFIwCffITQ m5r/8Z7sz7uont0zX0oAWQA=
=E/5A
-----END PGP SIGNATURE-----

Well, I see another problem:

jcf doesn't recognize operator overloading.

2010/2/13 Bernd Kreuss :

Guionardo Furlan wrote

Well, I see another problem: jcf doesn't recognize operator overloading.

Actually, this was implemented. Can you give an example of code which is not recognized?

Best regards,
Paul Ishenin.

Sure. I've created a new form to demonstrate:

unit Unit1;
{$mode objfpc}{$H+}
interface

uses
Classes, SysUtils, FileUtil, LResources, Forms, Controls, Graphics, Dialogs,
StdCtrls;

type

{ TForm1 }

 TForm1 = class(TForm)
   Button1: TButton;
   procedure Button1Click(Sender: TObject);
 private
   { private declarations }
 public
   { public declarations }
 end;
var
 Form1: TForm1;
operator ** (b1: byte; b2: byte): integer;
implementation
operator**(b1: byte; b2: byte): integer;
var i : Integer;
begin
  Result:=1;
  for i:=1 to b2 do
    Result:=Result*b1;
end;

{ TForm1 }

procedure TForm1.Button1Click(Sender: TObject);
var
 i:      integer;
 b1, b2: byte;
begin
 b1 := 10;
 b2 := 3;
 i  := b1 ** b2;
 ShowMessage(IntToStr(i));
end;
initialization
 {$I unit1.lrs}
end.

The code is OK, and compiles 100%.

When I command Ctrl-D, I get this from JCF:

http://picasaweb.google.com/lh/photo/_ixt2_gM792PLJ9-ISZ4uw?feat=directlink [image: jcf.png]

2010/2/15 Paul Ishenin :

not

Guionardo Furlan wrote

operator**(b1: byte; b2: byte): integer;

Yes, I see. The error happens only when you have operator in the interface section.

Best regards,
Paul Ishenin.

Fixed in r23718. I will push this upstream later.

Best regards,
Paul Ishenin.

I have found another bug on JCF:
I have copied the minium code to reproduce error, only the offending line: ----
unit Unit1;

{$mode objfpc}
interface
uses
   Classes, SysUtils;
implementation
initialization
ShowMessage('Est? soportado. Solicite m?s informaci?n en la p?gina del
proyecto. Gracias');
end.
------

JCF: unit1.pas Exception Exception Spaces to end is -1 on ) at on line 13 position 94 line is
ShowMessage('Est? soportado. Solicite m?s informaci?n en la p?gina del proyecto. Gracias');
JCF: IDE Aborted due to error

Seems to be related with a with an acute.

Thanks, Paul.

2010/2/16 Paul Ishenin