Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / lazarus / 2009-10

StateImages support in TListView

32 messages · 6 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Boian Mitov
to Paul Ishenin

Hi Paul,

Thank you!
I can probably work, on the Windows side, but I am not familiar enough with the rest of the platforms :-( .
I am prting some design packages so they can be compiled both in Delphi and Lazarus, and some of them rely on both images and status images in the ListView.
Are status images or something equivalent available in Qt and Carbon ?

With best regards,
Boian Mitov

------------------------------------------------------- Mitov Software
www.mitov.com
-------------------------------------------------------

Show quoted text 5 lines
No. But maybe you have some? Best regards, Paul Ishenin.

Reply by email

Unknown author
to dmitry boyarintsev

Hi Dmitry,
Even though SmallImages is supported, you can't actually display them can you, because vsReport only displays columns?
So doesn't that essentially mean that assigning the SmallImage property is largely useless? Or am I missing something?

Dominique.

dmitry boyarintsev wrote 9 lines
On Thu, Oct 22, 2009 at 12:40 AM, wrote: > It would be nice if under Mac OS X, any sort of Images in ListViews were > supported. SmallImages property is supported by Carbon TListView. But vsReport is the only ViewStyle supported. thanks, dmitry

Reply by email

dmitry boyarintsev
to Unknown author
?Even though SmallImages is supported, you can't actually display them can you, because vsReport only displays columns? So doesn't that essentially mean that assigning the SmallImage property is largely useless? Or am I missing something?

vsReport display only columns. But if SmallImages are assigned, the title of the first column is preceeded with images from SmallImages list, of if the ListView item has ImageIndex >= 0. Assigning SmallImages is very useful.

See the screenshot at the project: http://sourceforge.net/projects/devwork/ It uses TListView with SmallImages and ViewStyle = vsReport

Assiging LargeImages as well as using other ViewStyles are useless (for now), but there's a bug report about it, already.

thanks,
dmitry

Reply by email

Unknown author
to dmitry boyarintsev

I've never noticed the small icons to the left in vsReport view.

I will check it out tonight.

Dominique.

dmitry boyarintsev wrote 15 lines
On Thu, Oct 22, 2009 at 6:53 PM, wrote: > ?Even though SmallImages is supported, you can't actually display them > can > you, because vsReport only displays columns? > So doesn't that essentially mean that assigning the SmallImage property > is > largely useless? Or am I missing something? vsReport display only columns. But if SmallImages are assigned, the title of the first column is preceeded with images from SmallImages list, of if the ListView item has ImageIndex >= 0. Assigning SmallImages is very useful. See the screenshot at the project:

http://sourceforge.net/projects/devwork/

Show quoted text 7 lines
It uses TListView with SmallImages and ViewStyle = vsReport Assiging LargeImages as well as using other ViewStyles are useless (for now), but there's a bug report about it, already. thanks, dmitry

Reply by email

Boian Mitov
to Paul Ishenin: No. But maybe you have some? Paul Ishenin.

Hi Paul,

Thank you!
I am already looking into the options to add experimentally the support for it in Windows, and will do my best to do it for Qt. I have just noticed that the ListView has indeed StateImages property, so somebody has already started adding the support, but the work is just not finished, so any work I do obviously will be beneficial :-) . I will see how far I can get.
I think, it is better to work to add the functionality in Lazarus rather than altering the design packages to work around the limitation.

With best regards,
Boian Mitov

------------------------------------------------------- Mitov Software
www.mitov.com
-------------------------------------------------------

Earlier message 5 lines
----- Original Message ----- >> Are there plans for StateImages support in TListView ? > > No. But maybe you have some?

Reply by email

Unknown author
to dmitry boyarintsev: vsReport display only columns. But if SmallImages are assigned, the title of the first…

For my app having SmallImages viewable would be better, but I think the client will accept this version for now.

Thanks for pointing it out.

Dominique.

dmitry boyarintsev wrote 15 lines
On Thu, Oct 22, 2009 at 6:53 PM, wrote: > ?Even though SmallImages is supported, you can't actually display them > can > you, because vsReport only displays columns? > So doesn't that essentially mean that assigning the SmallImage property > is > largely useless? Or am I missing something? vsReport display only columns. But if SmallImages are assigned, the title of the first column is preceeded with images from SmallImages list, of if the ListView item has ImageIndex >= 0. Assigning SmallImages is very useful. See the screenshot at the project:

http://sourceforge.net/projects/devwork/

Show quoted text 13 lines
It uses TListView with SmallImages and ViewStyle = vsReport Assiging LargeImages as well as using other ViewStyles are useless (for now), but there's a bug report about it, already. thanks, dmitry -- _______________________________________________ Lazarus mailing list http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

Reply by email

Boian Mitov
to Unknown author

I am adding the StateImage support for the Windows version, and it seems that adding missing properties is not that difficult. The architecture of the LCL implementations seems very straightforward and simple to expand on. You can probably spend some time to add the missing functionality in the TWSCustomListView descendant class for the platform where it is missing. If you are familiar with the platform, it seems very straightforward ;-) . Indeed it is so simple that even I seem to be able to do it :-D .

With best regards,
Boian Mitov

------------------------------------------------------- Mitov Software
www.mitov.com
-------------------------------------------------------

Earlier message 9 lines
----- Original Message ----- From: To: "Lazarus mailing list" Sent: Thursday, October 22, 2009 4:14 PM Subject: Re: [Lazarus] StateImages support in TListView > For my app having SmallImages viewable would be better, but I think the > client will accept this version for now.

Reply by email

Boian Mitov
to Paul Ishenin: No. But maybe you have some? Paul Ishenin.

Hi Paul,

It seems that I have completed the implementation in Windows, and so far it seems to work well. I am now working to change the ListView item editor to allow editing the state.
In the next few days I will see if I can figure out how to implement the same functionality in Qt.
What is the recommended way to get the changes in the repository?

With best regards,
Boian Mitov

------------------------------------------------------- Mitov Software
www.mitov.com
------------------------------------------------------- ----- Original Message ----- > No. But maybe you have some?

Reply by email

Paul Ishenin
to Boian Mitov
Boian Mitov wrote 5 lines
It seems that I have completed the implementation in Windows, and so far it seems to work well. I am now working to change the ListView item editor to allow editing the state. In the next few days I will see if I can figure out how to implement the same functionality in Qt.

Very good.

What is the recommended way to get the changes in the repository?

First of all you need to perform all this changes using svn version: http://wiki.lazarus.freepascal.org/Installing_Lazarus#Installing_from_source_2

For windows use tortoise svn.

Then after editing you can do a patch and attach it to the bug tracker issue. Then one of the developers can take it and apply.

Best regards,
Paul Ishenin.

Reply by email

Boian Mitov
to Paul Ishenin

Hi Paul,

Thank you!
Actually somebody already had even prepared the design editor for StateImages . I had to only set the components to Visible and uncomment 2 commented out lines of code :-D .
Are there any other Windows SVN UIs aside from tortoise . I have had bad experience with tortoise CVS in the past since it is Windows Explorer plug-in. It used to slow down my system, and occasionally crash the Windows explorer, so I am very nervous about installing tortoise SVN.

With best regards,
Boian Mitov

------------------------------------------------------- Mitov Software
www.mitov.com
-------------------------------------------------------

Earlier message 8 lines
----- Original Message ----- From: "Paul Ishenin" To: "Lazarus mailing list" Sent: Thursday, October 22, 2009 6:50 PM Subject: Re: [Lazarus] StateImages support in TListView > For windows use tortoise svn.

Reply by email

Paul Ishenin
to Boian Mitov
Boian Mitov wrote
Are there any other Windows SVN UIs aside from tortoise . I have had bad experience with tortoise CVS in the past since it is Windows Explorer plug-in. It used to slow down my system, and occasionally crash the Windows explorer, so I am very nervous about installing tortoise SVN.

You can install a command line client. Then you will be able to checkout the sources using:

mkdir lazarus
svn co http://svn.freepascal.org/svn/lazarus/trunk lazarus

But I think you will have more pleasure with tortoise svn anyway. It has much more usability than command line tool.

Best regards,
Paul Ishenin.

Reply by email

Boian Mitov
to Paul Ishenin: Very good. First of all you need to perform all this changes using svn version:…

Hi Paul,

I have checked it out with QSvn.

I can't rebuild it from command line however. The instruction is for rebuilding in Unix command line, and make returns errors : MAKE Version 5.4 Copyright (c) 1987, 2009 CodeGear Error makefile 14: Command syntax error
Error makefile 17: Command syntax error
Error makefile 18: Command syntax error
Error makefile 21: Command syntax error
Error makefile 23: Command syntax error
Error makefile 24: Command syntax error
Error makefile 27: Command syntax error
Error makefile 29: Command syntax error
Error makefile 30: Command syntax error
Error makefile 31: Command syntax error
Error makefile 34: Command syntax error
Error makefile 35: Command syntax error
Error makefile 38: Command syntax error
Error makefile 39: Command syntax error
Error makefile 40: Command syntax error
Error makefile 42: Command syntax error
Error makefile 43: Command syntax error
....
....
...

I also tried nmake from Microsoft :

Microsoft (R) Program Maintenance Utility Version 6.00.8168.0 Copyright (C) Microsoft Corp 1988-1998. All rights reserved.

makefile(12) : fatal error U1033: syntax error : '=' unexpected Stop.

Are there any instructions how to rebuild in Windows? I will run now rebuild from the Lazarus GUI. Is that the correct option?

With best regards,
Boian Mitov

------------------------------------------------------- Mitov Software
www.mitov.com
-------------------------------------------------------

First of all you need to perform all this changes using svn version: http://wiki.lazarus.freepascal.org/Installing_Lazarus#Installing_from_source_2

Reply by email

Boian Mitov
to Boian Mitov

I figured :
lazbuild --build-ide=

With best regards,
Boian Mitov

------------------------------------------------------- Mitov Software
www.mitov.com
------------------------------------------------------- ----- Original Message ----- > I have checked it out with QSvn.

I can't rebuild it from command line however. The instruction is for rebuilding in Unix command line, and make returns errors :

Reply by email

Paul Ishenin
to Boian Mitov: I have checked it out with QSvn. I can't rebuild it from command line however. The…
Boian Mitov wrote
Are there any instructions how to rebuild in Windows? I will run now rebuild from the Lazarus GUI. Is that the correct option?

You need to use the make program from the fpc bin directory.

For example my build_win32.bat file looks so:

@echo off
d:\programming\fpc\bin\i386-win32\make.exe bigide OPT="-gh" if ERRORLEVEL 2 goto buidend
del lazarus.win32.exe /Q
ren lazarus.exe lazarus.win32.exe
:buidend

Best regards,
Paul Ishenin.

Reply by email

Boian Mitov
to Paul Ishenin

Hi Paul,

Thank you!
I am actually rebuilding it from the IDE now. Is that a problem? I have just finished integrating my changes into the checked out version and rebuilding now.

With best regards,
Boian Mitov

------------------------------------------------------- Mitov Software
www.mitov.com
------------------------------------------------------- ----- Original Message ----- >

You need to use the make program from the fpc bin directory.

Reply by email

Paul Ishenin
to Boian Mitov
Boian Mitov wrote
I am actually rebuilding it from the IDE now. Is that a problem? I have just finished integrating my changes into the checked out version and rebuilding now.

No problems. I usualy build LCL from the IDE too. But usually use my build script when I want to rebuild the whole IDE since I don't need more packages than bigide target has.

Best regards,
Paul Ishenin.

Reply by email

Boian Mitov
to Paul Ishenin

Hi Paul,

I think I am done. I actually have a large number of packages that I am porting to the IDE - 20 or so packages with well over 200 components ;-) . They are all ported and work in Windows, and now I am porting the design time packages, and making them Delphi/Lazarus compatible.

How do I create the patch?

With best regards,
Boian Mitov

------------------------------------------------------- Mitov Software
www.mitov.com
------------------------------------------------------- ----- Original Message ----- > No problems. I usualy build LCL from the IDE too. But usually use my

build script when I want to rebuild the whole IDE since I don't need more packages than bigide target has.

Reply by email

Paul Ishenin
to Boian Mitov
Boian Mitov wrote 6 lines
I think I am done. I actually have a large number of packages that I am porting to the IDE - 20 or so packages with well over 200 components ;-) . They are all ported and work in Windows, and now I am porting the design time packages, and making them Delphi/Lazarus compatible. How do I create the patch?

Depends on the tool you use.

If it is tortoise svn then:
1. Right click on your lazarus folder
2. choose menu tortoise svn -> create patch ...
3. save it and create a bug report with it

If it is a command line tool then:
1. cd to the lazarus folder
2. execute: svn diff > mypatch.patch
3. create a bug report with it

Best regards,
Paul Ishenin.

Reply by email

Boian Mitov
to Paul Ishenin

Hi Paul,

Just did:

report: 0014881

I hope I have not screwed it ;-) . The patch file seems about right, but we will see.

With best regards,
Boian Mitov

------------------------------------------------------- Mitov Software
www.mitov.com
------------------------------------------------------- ----- Original Message ----- > If it is a command line tool then:

1. cd to the lazarus folder 2. execute: svn diff > mypatch.patch 3. create a bug report with it

Reply by email

Paul Ishenin
to Boian Mitov

Boian Mitov ?????:

I hope I have not screwed it ;-) . The patch file seems about right, but we will see.

On the first sight there are no problems except the changes in:

components/codetools/identcompletiontool.pas

Best regards,
Paul Ishenin.

Reply by email

Boian Mitov
to Paul Ishenin

Hi Paul,

I guess you can ignore it. Without it I can't recompile the IDE. I guess it is some code that is not used in the Lazarus any more but is marked for rebuild on my system from older Lazarus install.

With best regards,
Boian Mitov

------------------------------------------------------- Mitov Software
www.mitov.com
-------------------------------------------------------

Earlier message 26 lines
----- Original Message ----- From: "Paul Ishenin" To: "Lazarus mailing list" Sent: Thursday, October 22, 2009 11:13 PM Subject: Re: [Lazarus] StateImages support in TListView > Boian Mitov ?????: > >> I hope I have not screwed it ;-) . The patch file seems about right, but >> we will see. > > On the first sight there are no problems except the changes in: > > components/codetools/identcompletiontool.pas > > Best regards, > Paul Ishenin. > > > -- > _______________________________________________ > Lazarus mailing list > > http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus >

Reply by email

Graeme Geldenhuys
to Paul Ishenin: Very good. First of all you need to perform all this changes using svn version:…

2009/10/23 Paul Ishenin :

Show quoted text 6 lines
> What is the recommended way to get the changes in the repository? First of all you need to perform all this changes using svn version: http://wiki.lazarus.freepascal.org/Installing_Lazarus#Installing_from_source_2

You can also get the source code using Git. It should be a smaller and faster download than SVN. Plus you will end up having the full history and various branches - yet it is still a smaller download than a single SVN checkout.

http://wiki.lazarus.freepascal.org/git_mirrors

Regards, - Graeme - _______________________________________________ fpGUI - a cross-platform Free Pascal GUI toolkit http://opensoft.homeip.net/fpgui/

Reply by email

Unknown author
to Boian Mitov: I am adding the StateImage support for the Windows version, and it seems that adding…

Hi Boian,
I'd love to add the SmallImages functionality to Mac OS LCL, my limitation is time and lack of knowledge of the underlying Mac OS API calls necessary to implement this custom behaviour.

Once I've finished this port, I'll try and give something useful back the Lazarus and FreePascal projects.

Dominique.

"Boian Mitov" wrote
I am adding the StateImage support for the Windows version, and it seems that adding missing properties is not that difficult. The architecture of the LCL implementations seems very straightforward and simple to expand

on.

You can probably spend some time to add the missing functionality in the TWSCustomListView descendant class for the platform where it is missing.

If

Show quoted text 6 lines
you are familiar with the platform, it seems very straightforward ;-) . Indeed it is so simple that even I seem to be able to do it :-D . With best regards, Boian Mitov

Reply by email

Vincent Snijders
to Boian Mitov: I guess you can ignore it. Without it I can't recompile the IDE. I guess it is some code…
Boian Mitov wrote 6 lines
Hi Paul, I guess you can ignore it. Without it I can't recompile the IDE. I guess it is some code that is not used in the Lazarus any more but is marked for rebuild on my system from older Lazarus install.
An error on Item.Params.StrictDelimiter:=true; probably means you have an old fpc
version, you should use fpc 2.2.4.

Vincent

Reply by email

Boian Mitov
to Vincent Snijders

Hi Vincent,

Thank you!
I have installed the Lazarus recently from the fpc 2.3.1 mirror. My About box however sais 2.2.2 . How do I make sure it uses the right one?

With best regards,
Boian Mitov

------------------------------------------------------- Mitov Software
www.mitov.com
-------------------------------------------------------

Earlier message 25 lines
----- Original Message ----- From: "Vincent Snijders" To: "Lazarus mailing list" Sent: Friday, October 23, 2009 3:46 AM Subject: Re: [Lazarus] StateImages support in TListView > Boian Mitov schreef: >> Hi Paul, >> >> I guess you can ignore it. Without it I can't recompile the IDE. I guess >> it is some code that is not used in the Lazarus any more but is marked >> for rebuild on my system from older Lazarus install. >> > > An error on Item.Params.StrictDelimiter:=true; probably means you have an > old fpc version, you should use fpc 2.2.4. > > Vincent > > -- > _______________________________________________ > Lazarus mailing list > > http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

Reply by email

Vincent Snijders
to Boian Mitov
Boian Mitov wrote 6 lines
Hi Vincent, Thank you! I have installed the Lazarus recently from the fpc 2.3.1 mirror. My About box however sais 2.2.2 . How do I make sure it uses the right one?

By changing the compiler path in the environment options.

Vincent

Reply by email

Boian Mitov
to Boian Mitov: Just did: report: 0014881 I hope I have not screwed it ;-) . The patch file seems about…

Any hope of this patch being applied? This functionality is extremely critical for us. I am working to release Lazarus version OpenWire www.openwire.org ASAP, and this is a must have functionality. I am finishing the port of the design time packages and then the project will be ready for Lazarus release if the StateImages are available in Lazarus.

With best regards,
Boian Mitov

------------------------------------------------------- Mitov Software
www.mitov.com
-------------------------------------------------------

Earlier message 34 lines
----- Original Message ----- From: "Boian Mitov" To: "Lazarus mailing list" Sent: Thursday, October 22, 2009 11:07 PM Subject: Re: [Lazarus] StateImages support in TListView > Hi Paul, > > Just did: > > report: 0014881 > > I hope I have not screwed it ;-) . The patch file seems about right, but > we will see. > > With best regards, > Boian Mitov > > ------------------------------------------------------- > Mitov Software > www.mitov.com > ------------------------------------------------------- > ----- Original Message ----- > If it is a command line tool then: >> 1. cd to the lazarus folder >> 2. execute: svn diff > mypatch.patch >> 3. create a bug report with it > > > -- > _______________________________________________ > Lazarus mailing list > > http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

Reply by email

Boian Mitov
to Boian Mitov: Just did: report: 0014881 I hope I have not screwed it ;-) . The patch file seems about…

BTW: I have also posted the current version of OpenWire on SourceForge - https://sourceforge.net/projects/openwireproject/ , and if anybody is interested in working on the support for other operating systems than Windows, is welcome to join the project :-) . I am already working on a Linux port, but any help there will surely be also appreciated.

With best regards,
Boian Mitov

------------------------------------------------------- Mitov Software
www.mitov.com
-------------------------------------------------------

Earlier message 34 lines
----- Original Message ----- From: "Boian Mitov" To: "Lazarus mailing list" Sent: Thursday, October 22, 2009 11:07 PM Subject: Re: [Lazarus] StateImages support in TListView > Hi Paul, > > Just did: > > report: 0014881 > > I hope I have not screwed it ;-) . The patch file seems about right, but > we will see. > > With best regards, > Boian Mitov > > ------------------------------------------------------- > Mitov Software > www.mitov.com > ------------------------------------------------------- > ----- Original Message ----- > If it is a command line tool then: >> 1. cd to the lazarus folder >> 2. execute: svn diff > mypatch.patch >> 3. create a bug report with it > > > -- > _______________________________________________ > Lazarus mailing list > > http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

Reply by email