Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / lazarus / 2009-01

Unicode data

11 messages · 4 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

theo

In the charactermapdlg.pas unit (IDE) we use some code from unicode.org. Since we should add unicode.org copyright notice to this file, I've created a patch for this file:
http://www.theo.ch/lazarus/mypatchlic.diff

Vincent suggested to put the relevant code into a separate unit of the LCL. Now Im asking if /lcl is the right place and what would the best name for it?
unicodedata.pas
lclunicodedata.pas
lunicodedata.pas

Any thoughts about this?
Is there currently more code in the LCL which should go there?

Regards Theo

Reply by email

Mattias Gaertner
to theo
In the charactermapdlg.pas unit (IDE) we use some code from unicode.org. Since we should add unicode.org copyright notice to this file, I've created a patch for this file: http://www.theo.ch/lazarus/mypatchlic.diff

What parts are form unicode.org?

Vincent suggested to put the relevant code into a separate unit of the LCL.

Good idea.

Show quoted text 5 lines
Now Im asking if /lcl is the right place and what would the best name for it? unicodedata.pas lclunicodedata.pas lunicodedata.pas

lclunicodedata.pas

Any thoughts about this? Is there currently more code in the LCL which should go there?

I don't know any.

Mattias

Reply by email

theo
to Mattias Gaertner: On Mon, 26 Jan 2009 15:33:41 +0100 What parts are form unicode.org? Good idea.…

Hello

Could somebody apply the attached patch?

It contains the new file:
lcl/lclunicodedata.pas

Changes to:
ide/charactermapdlg.pas
lcl/Makefile.fpc
lcl/alllclunits.pp

I have never added a new unit to the LCL before, so I can only hope this is correct / enough.

Thanks
Theo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unidatapat.zip
Type: application/zip
Size: 5771 bytes
Desc: not available
Url : http://www.lazarus.freepascal.org/pipermail/lazarus/attachments/20090127/622cf1fe/attachment.zip

Reply by email

Mattias Gaertner
to theo
Show quoted text 15 lines
Hello Could somebody apply the attached patch? It contains the new file: lcl/lclunicodedata.pas Changes to: ide/charactermapdlg.pas lcl/Makefile.fpc lcl/alllclunits.pp I have never added a new unit to the LCL before, so I can only hope this is correct / enough.

Thanks.
Applied.

Mattias

Reply by email

Vincent Snijders
to theo: Hello Could somebody apply the attached patch? It contains the new file:…

2009/1/27 theo :

Show quoted text 12 lines
Hello Could somebody apply the attached patch? It contains the new file: lcl/lclunicodedata.pas Changes to: ide/charactermapdlg.pas lcl/Makefile.fpc lcl/alllclunits.pp

Thanks.

Now that it has been committed, do you want to contribute some docs for http://lazarus-ccr.sourceforge.net/docs/lcl/lclunicodedata/index.html too?

lazarus/docs/xml/lcl/lclunicodedata.xml is the file to be edited. You can use a text editor to fill in the template or use the FPDoc editor in the IDE or the stand alone doceditor/lazde

Vincent

Reply by email

Vincent Snijders
to theo
theo wrote 7 lines
Vincent Snijders schrieb: > do you want to contribute some docs > Yes, next weekend. I'm a busy atm. and it's not so urgent because the unit currently only contains some special code for the charactermapdlg.

Thanks. It is not urgent indeed, but it is nice that somebody committed to do it.

Vincent

Reply by email