Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / lazarus / 2008-11

TAChart: simple patch and a code cleanup question

4 messages · 2 people · –

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Alexander Klenin

Attached is a patch which adds two more styles to TSeriesPointerStyle type, useful when there is a need to draw value intervals on a chart.

I also would like to do some code cleanup (e.g. consistent re-indenting) and refactoring of TAChart code.
The patches will be fairly intrusive, touching almost every line of code. Will such patches be accepted?

Alexander S. Klenin Insight Experts Ltd. -------------- next part -------------- A non-text attachment was scrubbed... Name: chart_point_style_bracket.patch Type: application/octet-stream Size: 1333 bytes Desc: not available Url : http://www.lazarus.freepascal.org/pipermail/lazarus/attachments/20081105/5c52cd11/attachment.obj

Reply by email

Darius Blaszyk
to Alexander Klenin
Alexander Klenin wrote 7 lines
Attached is a patch which adds two more styles to TSeriesPointerStyle type, useful when there is a need to draw value intervals on a chart. I also would like to do some code cleanup (e.g. consistent re-indenting) and refactoring of TAChart code. The patches will be fairly intrusive, touching almost every line of code. Will such patches be accepted?

Thanks Alexander applied in r17240.

About the other patch, please create a report in the bugtracker under patches and assign it to me. I will know what to do. As to the patches themselves, I don't mind you cleaning up code and re-indenting stuff, but please split it up in separate patches, this way we will still be able to see what and why things changed. I prefer that as opposed to one huge patch.
Some remarks from my side about the current code;

- there's a label/goto construct in the code. will you clean that up as well please while your at it?
- I'm not sure if more TSeriesPointerStyles will follow from you, but I could imagine adding a box and whisker plot style point and an errorbar style (other variations on the theme as well) would be possible in the future. So what do you say about implementing a polymorphic TPointStyle class?

Regards, Darius

Reply by email

Alexander Klenin
to Darius Blaszyk
Darius Blaszyk wrote 6 lines
About the other patch, please create a report in the bugtracker under patches and assign it to me. I will know what to do. As to the patches themselves, I don't mind you cleaning up code and re-indenting stuff, but please split it up in separate patches, this way we will still be able to see what and why things changed. I prefer that as opposed to one huge patch.

Sure, I'll try to do this.

Show quoted text 5 lines
- I'm not sure if more TSeriesPointerStyles will follow from you, but I could imagine adding a box and whisker plot style point and an errorbar style (other variations on the theme as well) would be possible in the future. So what do you say about implementing a polymorphic TPointStyle class?

Good idea. However, what about backwards compatibility? I personally do not need it, since I have just started switching my project to Lazarus, and can easily adjust code, but what about the others? Is it ok to simply drop TSeriesPointerStyles?

Alexander S. Klenin Insight Experts Ltd.

Reply by email

Alexander Klenin
to Darius Blaszyk: Thanks Alexander applied in r17240. About the other patch, please create a report in the…
Darius Blaszyk wrote
Thanks Alexander applied in r17240.

Thanks. There is small spelling error on commit message: 'path' should be 'patch'

Show quoted text 6 lines
About the other patch, please create a report in the bugtracker under patches and assign it to me. I will know what to do. As to the patches themselves, I don't mind you cleaning up code and re-indenting stuff, but please split it up in separate patches, this way we will still be able to see what and why things changed. I prefer that as opposed to one huge patch.

First re-indenting patch submitted, see
http://bugs.freepascal.org/view.php?id=12577

Alexander S. Klenin Insight Experts Ltd.

Reply by email