Well, I think I've fixed the script with two simple lines.

The original build_lcl_html.sh (and build_gtkintf_html.sh as well) have the following around line 30 or so:
-----------------------------------
# create description file list
DescrFiles=''
for unit in $UnitList; do
ShortFile=`echo $unit | sed -e 's/\.pp\b//g' -e 's/\.pas\b//g'` DescrFiles="$DescrFiles --descr=../$XMLSrcDir$ShortFile.xml" done
-----------------------------------

ShortFile is the problem. It contains the extension of the unit files, however the actual .xml filenames don't. So I added the following two lines to remove either .pp or .pas extension, and the documentation is now built with the script on OS X:
-----------------------------------
# create description file list
DescrFiles=''
for unit in $UnitList; do
ShortFile=`echo $unit | sed -e 's/\.pp\b//g' -e 's/\.pas\b//g'` ShortFile=${ShortFile%.pp}
ShortFile=${ShortFile%.pas}
DescrFiles="$DescrFiles --descr=../$XMLSrcDir$ShortFile.xml" done
-----------------------------------

Maybe sed works differently on your computer, as far as I can tell, the sed -e command is there to strip the .pp or .pas extentsion.

Vincent

2008/10/15 Vincent Snijders :

yes, maybe it's getting confused by the multiple -e. have you tried sed 's/\(\.pp\|\.pas\)\b//g'? that sed should probably only run once, too (on the output of the ls).

henry

Henry Vermaak wrote

yes, maybe it's getting confused by the multiple -e. have you tried sed 's/\(\.pp\|\.pas\)\b//g'? that sed should probably only run once, too (on the output of the ls).

Yeah, I figured it was the sed command that was the problem. The thing is, there is no need to use sed there anyway, since bash string processing handles removing those two extensions in a much simpler manner, as my "fix" shows.

Alright, I don't know what the deal is with sed on OS X, if it's behaving properly or what (sed syntax has always eluded me). Anyway I've attached two patch files that correct build_lcl_html.sh and build_gtkintf_html.sh to work on OS X (and linux, too -- they may have worked on linux before the patch, but they work with the patch too, so I believe this should be the preferred solution on both platforms). Instead of adding two lines, I replaced the line that used sed with the built-in bash string processing to remove the .pp, and added one line to remove any .pas as well. Sed is just overkill here, and besides it doesn't work as written on OS X. And the new version is shorter by 12 bytes, too. :)

I did not notice that, because you change still did contain the sed call:

# create description file list
DescrFiles=''
for unit in $UnitList; do
ShortFile=`echo $unit | sed -e 's/\.pp\b//g' -e 's/\.pas\b//g'` ShortFile=${ShortFile%.pp}
ShortFile=${ShortFile%.pas}
DescrFiles="$DescrFiles --descr=../$XMLSrcDir$ShortFile.xml" done

Vincent

yes, i know about that way, since i use bash, but i thought it was bash specific? have you tested with other shells? you can also use "basename" to remove suffixes.

henry

On Wed, Oct 15, 2008 at 2:42 PM, Vincent Snijders <

The patch in my previous email removes the sed call, so the loop now looks like this:
DescrFiles=''
for unit in $UnitList; do
ShortFile=${unit%.pp}
ShortFile=${ShortFile%.pas}
DescrFiles="$DescrFiles --descr=../$XMLSrcDir$ShortFile.xml" done

Sorry, but something happened when I created the diff patch for one of the files. The two attached here should be the correct patch files (I actually double-checked them this time :)

Well, the script invokes bash to run itself (the she-bang on the first line causes this), so it doesn't matter if the user is calling it from some other shell.

Also "basename" is overkill for removing suffixes (it's actually a separate program, like sed), and you'd still need to call it twice to remove both suffixes.

2008/10/15 John Stoneham :

and what if bash is a symlink to something else? it's not uncommon at all to have different shells point at the one that's installed. certain versions of osx runs zsh (luckily that also supports ${name%pattern}).

Also "basename" is overkill for removing suffixes (it's actually a separate program, like sed), and you'd still need to call it twice to remove both suffixes.

that's why i said sed should be run _once_ over the whole output of ls. either way, i really don't care. if it works it works, it's not like we're worrying about performance.

henry

Thanks, applied in r17013.

Vincent

If there is a symlink from bash to something else, it better support all bash syntax....

Vincent