TCustomForm class

    property TextHeight: Longint read FDummyTextHeight write
FDummyTextHeight
                                 stored False;
For What?

I removed it.

Mattias

Removing TextHeight broke:

- All Orpheus property editors.
- All Orpheus test apps whose forms were converted from Delphi.
- All of my own apps whose forms were converted from Delphi.

Was this really necessary?

Thanks.

-Phil

Maybe it should never have been in a .lfm in the first place and the conversion was wrong.

Vincent

But did removing it add any value to Lazarus?

All I know is that what once worked no longer does.

TextHeight is probably a holdover from early versions of Delphi, but Delphi still puts TextHeight in the .dfm. So if you want better compatibility...

Thanks.

-Phil

Philip J wrote

But did removing it add any value to Lazarus?

Any value? Yes. Less confusion about unused properties.

How much value, maybe very little.

Me personally, no I don't want compatibility with unused Delphi ballast.

Vincent

Vincent,

I'm not sure if you appreciate the hassle this teeny, tiny change has caused. Now anyone who ever installed the ported Orpheus package, when they move to a newer Lazarus will discover that it no longer works. Period.

The fix is not difficult but I can't retroactively upgrade others' installations.

This is my main issue with Lazarus these days: How perfectly good code slowly "erodes" over time as Lazarus advances. It's almost impossible to keep up. Staying with a stable build is not an option since the widgetset improvements we need are often tied to LCL changes as well.

Thanks.

-Phil

My 2cents suggestions if the property is restored:
- use a dummy method instead of a field/variable? (mostly for the code cleanliness rather than the wastage of heap memory)
- would it work to make it write-only so it's not displayed in the Object Inpector?

Cheers,
Fl?vio

Sorry for the trouble, but there is hope.
Today I added LCLVersion to forms.
Now we can start writing an automatic lfm converter/clean up for the IDE.

Mattias

It's a pity that Borland didn't think about versioning when they created TReader/TWriter.

That's why we need a tool for that.

Mattias