Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / lazarus / 2003-09

Implementation of TOpenDialog multiple selectionsunder win32

5 messages · 3 people ·

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Mattias Gaertner
to Karl Brandt: The patch does the cited above, cleans creation of CommonDialogs and removes unused/buggy…
At 01:26 14-9-2003, Karl Brandt wrote: >The patch

Applied.

Show quoted text 8 lines
does the cited above, cleans creation of CommonDialogs and >removes unused/buggy code (LM_SETFILTER,LM_SETFILENAME). > >What's the expected by LCL when user clicks Cancel at Save/Open Boxes: >Set Filename to '' and clear Files or mantain previous values? I would expect the values I set before issuing execute. On OK it should change IMO. However if the user clicks cancel, the values have no meaning.

I agree, that on Cancel the values have no meaning. But I don't think, that a Cancel should automatically reset the dialog (and a Ok does not). IMO it is up to the application to initialize the dialog.

Show quoted text 11 lines
>The Patch does the former, being easy to change. > >BTW: In my system, all progs with Open/Save dialogs (compiled with FPC , >GCC,Delphi ... - includind MS ones) get a SIGSEG signal after first use >of the cited dlgs. Does someone is getting the same? >To see it, just load the exe with gdb. ??? You mean that you also get an AV when you use a standard Delphi Open/Save dialog component ? >Using WindowsXP Professional version 2002, no SR

Mattias

Marc Weustink
to Karl Brandt: The patch does the cited above, cleans creation of CommonDialogs and removes unused/buggy…
Karl Brandt wrote 5 lines
The patch does the cited above, cleans creation of CommonDialogs and removes unused/buggy code (LM_SETFILTER,LM_SETFILENAME). What's the expected by LCL when user clicks Cancel at Save/Open Boxes: Set Filename to '' and clear Files or mantain previous values?

I would expect the values I set before issuing execute. On OK it should change IMO. However if the user clicks cancel, the values have no meaning.

Show quoted text 6 lines
The Patch does the former, being easy to change. BTW: In my system, all progs with Open/Save dialogs (compiled with FPC , GCC,Delphi ... - includind MS ones) get a SIGSEG signal after first use of the cited dlgs. Does someone is getting the same? To see it, just load the exe with gdb.

??? You mean that you also get an AV when you use a standard Delphi Open/Save dialog component ?

Using WindowsXP Professional version 2002, no SR

Marc

Karl Brandt

The patch does the cited above, cleans creation of CommonDialogs and removes unused/buggy code (LM_SETFILTER,LM_SETFILENAME).

What's the expected by LCL when user clicks Cancel at Save/Open Boxes: Set Filename to '' and clear Files or mantain previous values? The Patch does the former, being easy to change.

BTW: In my system, all progs with Open/Save dialogs (compiled with FPC , GCC,Delphi ... - includind MS ones) get a SIGSEG signal after first use of the cited dlgs. Does someone is getting the same? To see it, just load the exe with gdb.

Using WindowsXP Professional version 2002, no SR

karl

-------------- next part --------------
A non-text attachment was scrubbed...
Name: zip00037.zip
Type: application/octet-stream
Size: 3873 bytes
Desc: "dlg.zip"
Url : http://localhost/pipermail/lazarus/attachments/20030913/cfd8c8f8/zip00037.obj

Marc Weustink
to Karl Brandt
Karl Brandt wrote 11 lines
Marc Weustink wrote: > >>BTW: In my system, all progs with Open/Save dialogs (compiled with FPC , >>GCC,Delphi ... - includind MS ones) get a SIGSEG signal after first use >>of the cited dlgs. Does someone is getting the same? >>To see it, just load the exe with gdb. > >??? You mean that you also get an AV when you use a standard Delphi >Open/Save dialog component ? Yes. In fact after any call to GetOpenFileName/GetSaveFileName.

???
THis sounds so basic that I probably mis the point. Everything is OK here. XPpro SP1 D7 SP1

>>Using WindowsXP Professional version 2002, no SR

Marc

Karl Brandt
to Karl Brandt: The patch does the cited above, cleans creation of CommonDialogs and removes unused/buggy…
Marc Weustink wrote 9 lines
> BTW: In my system, all progs with Open/Save dialogs (compiled with FPC > , GCC,Delphi ... - includind MS ones) get a SIGSEG signal after first > use of the cited dlgs. Does someone is getting the same? > To see it, just load the exe with gdb. ??? You mean that you also get an AV when you use a standard Delphi Open/Save dialog component ?

Yes. In fact after any call to GetOpenFileName/GetSaveFileName.

> Using WindowsXP Professional version 2002, no SR

karl