Sign in Join

Live chat for Free Pascal, Lazarus, Delphi and every Pascal programmer.

Mailing lists / lazarus / 2002-11

Patch for the win32 interface

3 messages · 3 people ·

Reply by email Subscribe to this list Your subscription

Read-only archive. Use j and k to move between messages.

Karl Brandt

I'm sending a patch (really 2) for the win32 interface.

It Fixes:
- the size of the forms (clientarea = windowarea, like in gtk interface)
- one bug added when interfaceLCL circle was broken, that was preventing TButton to work
- TListBox and TComboBox that is working partially now

Note: to make combobox work in win32, i had to modify TCustomComboBox.CreateHandle calling Assign method of the interface stringlist, just like in TCustomListBox.CreateHandle. At first look it doesn't break the gtk interface.

I applied the patch in one fresh copy of lcl (15 nov) and is running fine, if we can say this of the win32 port;-)
I hope the patch can be applied by someone

-------------- next part --------------
A non-text attachment was scrubbed...
Name: zip00005.zip
Type: application/octet-stream
Size: 3074 bytes
Desc: "win32patch.zip"
Url : http://localhost/pipermail/lazarus/attachments/20021115/95e8d2fc/zip00005.obj

Reply by email

Mattias Gaertner
to Karl Brandt
Show quoted text 16 lines
I'm sending a patch (really 2) for the win32 interface. It Fixes: - the size of the forms (clientarea = windowarea, like in gtk interface) - one bug added when interfaceLCL circle was broken, that was preventing TButton to work - TListBox and TComboBox that is working partially now Note: to make combobox work in win32, i had to modify TCustomComboBox.CreateHandle calling Assign method of the interface stringlist, just like in TCustomListBox.CreateHandle. At first look it doesn't break the gtk interface. I applied the patch in one fresh copy of lcl (15 nov) and is running fine, if we can say this of the win32 port;-) I hope the patch can be applied by someone

Thx. Applied.

Mattias

Reply by email

Tony Maro
to Karl Brandt: I'm sending a patch (really 2) for the win32 interface. It Fixes: - the size of the forms…
Mattias Gaertner wrote 7 lines
On Fri, 15 Nov 2002 20:11:49 -0200 Karl Brandt wrote: > I'm sending a patch (really 2) for the win32 interface. > > It Fixes: > - the size of the forms (clientarea = windowarea, like in gtk interface)

Now, my understanding of Delphi compatibility is that clientwidth should be the internal width of the window, and WIDTH should NOT and would dynamically change if a user changes window border sizes. If we go with clientwidth being equal to form.width then aren't we breaking Delphi compatibility in Winblows? We couldn't do that in GTK because GTK can't find out how wide a window border is was my understanding.

It's been a while since I worried about that in Delphi though, so perhaps I have it backwards.

One of these days I've gotta reboot into Windows (if I can remember how) and try out Lazarus in Win32 just to see how it's going.

-Tony

Reply by email